feat(app): R2 switch — the application runs its domain rules in the Rust core
Consumers now fed by the core (crates/core through @faunosteo/core-wasm):
- the sheet: the bundled payload is parsed and indexed by the core
(SheetHandle, SheetIndexData); SheetIndex reads precomputed tables only;
- the store: new report, add / remove / move observation, draft restore
(v2 migration + rebase) through the core, actions answering { ok };
- the editor click chain (zone.click), laterality and vertebra pickers
(zone.add_sides, vertebra.initial / sync / select), the findings picker
(finding.toggle by clicked leaf position), zone removal;
- the import: engine byte scan (TypeScript until R4), then the core's
layered reading and rebase in one call; the export: the core builds the
sheet snapshot, the frozen TypeScript engine writes the PDF (R4).
Lazy core: Home and the new-report form read the sheet availability from
the bundle and load the module on import / submit only; the auth shell
never references it. Degraded states (core_unavailable, invalid_sheet)
show the validated notice with a retry and never redirect or touch the
draft; an unreadable draft or archive is set aside under
osteo:quarantine:* (only content kinds; a failed write keeps it in place
and the editor stays), a rebase that flags items keeps the raw pre-rebase
draft. Four strings, wording validated by the owner.
Deleted: services/zoneInteraction.ts and its suite (13 cases ported to
cargo), the TypeScript Finding builder and vertebra selection rules of the
pickers, store rules, persistence parsing, hydrateReport. ESLint forbids
@faunosteo/domain in apps/app/src; the report:compare CLI keeps the frozen
domain until R4 (scripts/compare/sheet.ts). App suite 313/313 on the real
core (24 new tests: quarantine, degraded editor, core failures, N-1
reader); step6 goldens and the frozen envelopes unchanged.
This commit is contained in:
1 parent
794dfd9d0b
commit
74fcb37564
65 files changed
+2227
-1678
No files matched your search
@@ -1,6 +1,7 @@
|
||||
/**
|
||||
* T15 (STEP6 §7, §16): the home route on Step 6 archives, with
|
||||
* `importReportFromPdf` mocked. Every alert opens with a headline: complete
|
||||
* T15 (STEP6 §7, §16): the home route on Step 6 archives, with the byte
|
||||
* scan (`readAttachment`) mocked to hand over the attachment; the layered
|
||||
* read and the rebase run in the core (R2). Every alert opens with a headline: complete
|
||||
* restoration or partial recovery. Same sheet: archive kept in the store and
|
||||
* mirrored, complete + archive_ok. Other sheet: the report is rebased on the
|
||||
* loaded sheet (unresolved flags, labels from the archived snapshot, sheet
|
||||
@@ -27,12 +28,11 @@ import {
|
||||
import { MemoryRouter, Route, Routes } from 'react-router-dom'
|
||||
import type {
|
||||
Annotation,
|
||||
ArchiveReadOutcome,
|
||||
Report,
|
||||
ReportArchiveEnvelope,
|
||||
} from '@faunosteo/domain'
|
||||
} from '@faunosteo/core-wasm/types'
|
||||
import HomeRoute from '@/app/routes/HomeRoute'
|
||||
import { ImportError, importReportFromPdf } from '@/pdf/import'
|
||||
import { ImportError, readAttachment } from '@/pdf/import'
|
||||
import { useReportStore } from '@/state/reportStore'
|
||||
import { ARCHIVE_KEY } from '@/state/persistence'
|
||||
import { useLocaleStore } from '@/state/localeStore'
|
||||
@@ -42,9 +42,9 @@ import { archiveEnvelope, loadTestSheet, minimalReport } from '../helpers/sheet'
|
||||
|
||||
vi.mock('@/pdf/import', async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import('@/pdf/import')>()),
|
||||
importReportFromPdf: vi.fn(),
|
||||
readAttachment: vi.fn(),
|
||||
}))
|
||||
const importMock = vi.mocked(importReportFromPdf)
|
||||
const readMock = vi.mocked(readAttachment)
|
||||
|
||||
let sheet: SheetIndex
|
||||
|
||||
@@ -60,7 +60,7 @@ beforeEach(() => {
|
||||
activeObservationIndex: 0,
|
||||
})
|
||||
vi.stubGlobal('alert', vi.fn())
|
||||
importMock.mockReset()
|
||||
readMock.mockReset()
|
||||
})
|
||||
afterEach(() => {
|
||||
cleanup()
|
||||
@@ -69,23 +69,6 @@ afterEach(() => {
|
||||
|
||||
const OTHER_SHA = 'b'.repeat(64)
|
||||
|
||||
/** An outcome carrying a kept envelope (v3, nothing migrated). */
|
||||
function archived(
|
||||
report: Report,
|
||||
archive: ReportArchiveEnvelope | null,
|
||||
patch: Partial<ArchiveReadOutcome> = {},
|
||||
): ArchiveReadOutcome {
|
||||
return {
|
||||
report,
|
||||
origin: 'envelope_v1',
|
||||
migrated: false,
|
||||
unresolvedZones: 0,
|
||||
unresolvedFindings: 0,
|
||||
archive,
|
||||
...patch,
|
||||
}
|
||||
}
|
||||
|
||||
function reportWithHip(): Report {
|
||||
return minimalReport(sheet, {
|
||||
observations: [
|
||||
@@ -162,15 +145,14 @@ async function mountAndPickPdf(): Promise<void> {
|
||||
|
||||
const alertMock = () => vi.mocked(window.alert)
|
||||
/** The alert split on its blank lines: headline first, then the detail lines. */
|
||||
const alertLines = () =>
|
||||
(alertMock().mock.calls[0]![0] as string).split('\n\n')
|
||||
const alertLines = () => (alertMock().mock.calls[0]![0] as string).split('\n\n')
|
||||
const errorText = () => screen.queryByText(/./, { selector: 'p.text-red-700' })
|
||||
|
||||
describe('HomeRoute import of a Step 6 archive', () => {
|
||||
it('same sheet: keeps the archive in the store and its mirror, alerts archive_ok, no rebase', async () => {
|
||||
const report = reportWithHip()
|
||||
const archive = archiveEnvelope(sheet, report)
|
||||
importMock.mockResolvedValue(archived(report, archive))
|
||||
readMock.mockResolvedValue(archive)
|
||||
await mountAndPickPdf()
|
||||
await screen.findByTestId('editor-route')
|
||||
const state = useReportStore.getState()
|
||||
@@ -188,7 +170,9 @@ describe('HomeRoute import of a Step 6 archive', () => {
|
||||
|
||||
it('other sheet: rebases onto the loaded sheet, labels from the archived snapshot, alert with the count', async () => {
|
||||
const { report, archive } = staleReportAndArchive()
|
||||
importMock.mockResolvedValue(archived(report, archive))
|
||||
// The attachment is the envelope of the stale report (read by the core).
|
||||
expect(archive.report).toBe(report)
|
||||
readMock.mockResolvedValue(archive)
|
||||
await mountAndPickPdf()
|
||||
await screen.findByTestId('editor-route')
|
||||
const opened = useReportStore.getState().report!
|
||||
@@ -221,7 +205,7 @@ describe('HomeRoute import of a Step 6 archive', () => {
|
||||
})
|
||||
const archive = archiveEnvelope(sheet, report)
|
||||
archive.sheetSnapshot.ref.documentSha256 = OTHER_SHA
|
||||
importMock.mockResolvedValue(archived(report, archive))
|
||||
readMock.mockResolvedValue(archive)
|
||||
await mountAndPickPdf()
|
||||
await screen.findByTestId('editor-route')
|
||||
const opened = useReportStore.getState().report!
|
||||
@@ -237,9 +221,10 @@ describe('HomeRoute import of a Step 6 archive', () => {
|
||||
|
||||
it('snapshot rejected: the report opens, the alert names the reason, no archive kept', async () => {
|
||||
const report = reportWithHip()
|
||||
importMock.mockResolvedValue(
|
||||
archived(report, null, { snapshotRejected: 'caps' }),
|
||||
)
|
||||
// A label over the 512-character cap: the core drops the snapshot ('caps').
|
||||
const archive = archiveEnvelope(sheet, report)
|
||||
archive.sheetSnapshot.document.name.fr = 'x'.repeat(513)
|
||||
readMock.mockResolvedValue(archive)
|
||||
await mountAndPickPdf()
|
||||
await screen.findByTestId('editor-route')
|
||||
expect(useReportStore.getState().report).toEqual(report)
|
||||
@@ -256,7 +241,7 @@ describe('HomeRoute import of a Step 6 archive', () => {
|
||||
})
|
||||
|
||||
it('attachment_stripped → its error message, nothing opened', async () => {
|
||||
importMock.mockRejectedValue(new ImportError('attachment_stripped'))
|
||||
readMock.mockRejectedValue(new ImportError('attachment_stripped'))
|
||||
await mountAndPickPdf()
|
||||
await waitFor(() => expect(errorText()).not.toBeNull())
|
||||
expect(errorText()!.textContent).toBe(
|
||||
|
||||
Reference in new issue
Block a user