feat(app): R2 switch — the application runs its domain rules in the Rust core
Consumers now fed by the core (crates/core through @faunosteo/core-wasm):
- the sheet: the bundled payload is parsed and indexed by the core
(SheetHandle, SheetIndexData); SheetIndex reads precomputed tables only;
- the store: new report, add / remove / move observation, draft restore
(v2 migration + rebase) through the core, actions answering { ok };
- the editor click chain (zone.click), laterality and vertebra pickers
(zone.add_sides, vertebra.initial / sync / select), the findings picker
(finding.toggle by clicked leaf position), zone removal;
- the import: engine byte scan (TypeScript until R4), then the core's
layered reading and rebase in one call; the export: the core builds the
sheet snapshot, the frozen TypeScript engine writes the PDF (R4).
Lazy core: Home and the new-report form read the sheet availability from
the bundle and load the module on import / submit only; the auth shell
never references it. Degraded states (core_unavailable, invalid_sheet)
show the validated notice with a retry and never redirect or touch the
draft; an unreadable draft or archive is set aside under
osteo:quarantine:* (only content kinds; a failed write keeps it in place
and the editor stays), a rebase that flags items keeps the raw pre-rebase
draft. Four strings, wording validated by the owner.
Deleted: services/zoneInteraction.ts and its suite (13 cases ported to
cargo), the TypeScript Finding builder and vertebra selection rules of the
pickers, store rules, persistence parsing, hydrateReport. ESLint forbids
@faunosteo/domain in apps/app/src; the report:compare CLI keeps the frozen
domain until R4 (scripts/compare/sheet.ts). App suite 313/313 on the real
core (24 new tests: quarantine, degraded editor, core failures, N-1
reader); step6 goldens and the frozen envelopes unchanged.
This commit is contained in:
1 parent
794dfd9d0b
commit
74fcb37564
65 files changed
+2227
-1678
No files matched your search
@@ -0,0 +1,118 @@
|
||||
/**
|
||||
* R2 plan rev 2 (robustness BLOCKER 1): when the core cannot run, a reload of
|
||||
* the editor shows the degraded notice with a retry, never redirects to the
|
||||
* home page, and never reads, rewrites or removes the tab's draft. A sheet
|
||||
* payload the core refuses (`invalid_sheet`) shows the same notice. Once the
|
||||
* module loads, the retry restores the draft.
|
||||
*/
|
||||
import {
|
||||
afterEach,
|
||||
beforeAll,
|
||||
beforeEach,
|
||||
describe,
|
||||
expect,
|
||||
it,
|
||||
vi,
|
||||
} from 'vitest'
|
||||
import { cleanup, render, screen, waitFor } from '@testing-library/react'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { MemoryRouter, Route, Routes } from 'react-router-dom'
|
||||
import EditorRoute from '@/app/routes/EditorRoute'
|
||||
import { setCoreRuntime } from '@/core/runtime'
|
||||
import { bundledSheetProvider } from '@/sheets/provider'
|
||||
import { setSheetProvider } from '@/sheets/useSheet'
|
||||
import { useReportStore } from '@/state/reportStore'
|
||||
import { DRAFT_KEY } from '@/state/persistence'
|
||||
import { useLocaleStore } from '@/state/localeStore'
|
||||
import { fr } from '@/i18n/fr'
|
||||
import type { SheetIndex } from '@/services/sheetIndex'
|
||||
import { testCoreRuntime, unavailableCoreRuntime } from '../helpers/core'
|
||||
import { bundledSheet, loadTestSheet, minimalReport } from '../helpers/sheet'
|
||||
|
||||
let sheet: SheetIndex
|
||||
let draft: string
|
||||
|
||||
beforeAll(async () => {
|
||||
sheet = await loadTestSheet()
|
||||
draft = JSON.stringify(minimalReport(sheet, { conclusion: 'unsaved work' }))
|
||||
})
|
||||
beforeEach(() => {
|
||||
useLocaleStore.setState({ locale: 'fr' })
|
||||
sessionStorage.clear()
|
||||
sessionStorage.setItem('osteo:disclaimer-shown', '1')
|
||||
window.scrollTo = vi.fn() as unknown as typeof window.scrollTo
|
||||
vi.stubGlobal('alert', vi.fn())
|
||||
useReportStore.setState({
|
||||
report: null,
|
||||
archive: null,
|
||||
activeObservationIndex: 0,
|
||||
})
|
||||
// After the reset (an empty store mirrors no draft): the tab as a reload finds it.
|
||||
sessionStorage.setItem(DRAFT_KEY, draft)
|
||||
})
|
||||
afterEach(async () => {
|
||||
cleanup()
|
||||
vi.unstubAllGlobals()
|
||||
setCoreRuntime(await testCoreRuntime())
|
||||
setSheetProvider(bundledSheetProvider)
|
||||
})
|
||||
|
||||
function mount() {
|
||||
return render(
|
||||
<MemoryRouter initialEntries={['/editor']}>
|
||||
<Routes>
|
||||
<Route path="/" element={<p data-testid="home-route" />} />
|
||||
<Route path="/editor" element={<EditorRoute />} />
|
||||
</Routes>
|
||||
</MemoryRouter>,
|
||||
)
|
||||
}
|
||||
|
||||
async function expectDegraded() {
|
||||
await screen.findByText(fr['sheet.core_unavailable']!)
|
||||
expect(
|
||||
screen.getByRole('button', { name: fr['sheet.core_retry'] }),
|
||||
).toBeInTheDocument()
|
||||
expect(screen.queryByTestId('home-route')).toBeNull()
|
||||
expect(sessionStorage.getItem(DRAFT_KEY)).toBe(draft)
|
||||
expect(useReportStore.getState().report).toBeNull()
|
||||
}
|
||||
|
||||
describe('EditorRoute while the core cannot run', () => {
|
||||
it('shows the degraded notice, stays on the editor and leaves the draft byte-identical', async () => {
|
||||
setCoreRuntime(unavailableCoreRuntime())
|
||||
setSheetProvider(bundledSheetProvider)
|
||||
mount()
|
||||
await expectDegraded()
|
||||
expect(window.alert).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('restores the draft once a retry finds the module', async () => {
|
||||
const user = userEvent.setup()
|
||||
setCoreRuntime(unavailableCoreRuntime())
|
||||
setSheetProvider(bundledSheetProvider)
|
||||
mount()
|
||||
await expectDegraded()
|
||||
// The module is reachable again (network back, CSP fixed).
|
||||
setCoreRuntime(await testCoreRuntime())
|
||||
await user.click(
|
||||
screen.getByRole('button', { name: fr['sheet.core_retry'] }),
|
||||
)
|
||||
await waitFor(() =>
|
||||
expect(useReportStore.getState().report?.conclusion).toBe('unsaved work'),
|
||||
)
|
||||
expect(screen.queryByTestId('home-route')).toBeNull()
|
||||
})
|
||||
|
||||
it('shows the same notice for a sheet payload the core refuses (invalid_sheet)', async () => {
|
||||
const bundle = await bundledSheet()
|
||||
setSheetProvider({
|
||||
getReferenceSheet: async () => ({
|
||||
...bundle,
|
||||
document: { schema_version: 2, broken: true },
|
||||
}),
|
||||
})
|
||||
mount()
|
||||
await expectDegraded()
|
||||
})
|
||||
})
|
||||
Reference in new issue
Block a user