docs(docs): U2 preparatory closure, skipped tests, contrast anomaly, Prettier on two tests

This commit is contained in:
bchanot committed 2026-11-20 11:38:08 +01:00
1 parent 9386288ffd
commit 70d4addc56
4 files changed
+41 -9

No files matched your search

+1
View File
@@ -937,3 +937,4 @@ Apply when implementing B-phase:
- [x] F7 board 12 rows touched by F2, F4, F6; contact sheet, REVUE.md (labels: both reviews compared, nothing ratified), README line, contract §17.8, SHA256SUMS, new zip (9adbd3a, f9fc13c; zip `faunosteo-v1-2-4-maquettes-corrigees.zip` sha256 b5bd8abf…) - [x] F7 board 12 rows touched by F2, F4, F6; contact sheet, REVUE.md (labels: both reviews compared, nothing ratified), README line, contract §17.8, SHA256SUMS, new zip (9adbd3a, f9fc13c; zip `faunosteo-v1-2-4-maquettes-corrigees.zip` sha256 b5bd8abf…)
- [x] F8 fresh verifier on the new batch; open label arbitrations to the owner: ECARTS(1) = archive not yet built at check time, 15/16 met; archive built after, sums checked - [x] F8 fresh verifier on the new batch; open label arbitrations to the owner: ECARTS(1) = archive not yet built at check time, 15/16 met; archive built after, sums checked
- [x] owner arbitrations (brief « arbitrages propriétaire et préparation de validation finale », 2026-11-02, on c2a3147): A1 BDR-095, A2 board 05 whole horse at 768 px, A3 V1-2.7 lists on failure_outcome, A4 24 common labels + owner arbitrations, A5 affected boards + contact sheet + archive -3.zip; verifier ECARTS(2) → ECARTS(1) → CONFORME 21/21 (27e5727, 74aa8f6) - [x] owner arbitrations (brief « arbitrages propriétaire et préparation de validation finale », 2026-11-02, on c2a3147): A1 BDR-095, A2 board 05 whole horse at 768 px, A3 V1-2.7 lists on failure_outcome, A4 24 common labels + owner arbitrations, A5 affected boards + contact sheet + archive -3.zip; verifier ECARTS(2) → ECARTS(1) → CONFORME 21/21 (27e5727, 74aa8f6)
- [ ] Anomaly to diagnose (owner 2026-11-20, new, intermittent): axe colour-contrast failure on the animal archive dialog in the shell suite. Cause not concluded: do not assume it is only a measure taken during the animation. Diagnose with repeated runs, the computed colours and the animation state; no fix before the cause. Known failures outside U2 stay as documented.
@@ -446,3 +446,22 @@ U2 sera clôturé après ma validation de cet essai. »
### FILE SCOPE (addendum 2) ### FILE SCOPE (addendum 2)
apps/app/src/components/shell/AppLayout.tsx, apps/app/src/state/leaveGuardStore.ts, apps/app/src/components/ui/anchoredPlace.ts, crates/core/src/anatomy/layer.rs (owner D3); apps/app/src/styles/index.css and the editor's annotations layout components for criterion 32; HistoryButtons.tsx and a bubble component under apps/app/src/components/editor/ for criterion 33. apps/app/src/components/shell/AppLayout.tsx, apps/app/src/state/leaveGuardStore.ts, apps/app/src/components/ui/anchoredPlace.ts, crates/core/src/anatomy/layer.rs (owner D3); apps/app/src/styles/index.css and the editor's annotations layout components for criterion 32; HistoryButtons.tsx and a bubble component under apps/app/src/components/editor/ for criterion 33.
### Owner status 2026-11-20 (addendum 2)
- Criterion 32 stays OPEN: the partly hidden drawing cases are not accepted as final limits. The owner tests on a
tablet (`db:trial`) and reports on point and zone handling and on the drawing during scroll. If a structural fix is
needed, a targeted mock-up is validated before any large layout change. U2 is not validated.
- Skipped tests, established from the code and the last full shell run (3d6aacad, `shell-3d6aacad-w2`:
347 passed, 234 skipped, 13 failed; the failures are the known ones outside U2 plus the animal-archive contrast
anomaly in TODO). The 234 are NOT five tests; the figure five matches only the chromium-desktop project:
- chromium-desktop, 5 skipped. Hand-run measures, 2 (never asserted, timing figures; skip unless the variable is
set): `editor-measure-commit.spec.ts:48` (`MEASURE_COMMIT=1`) and `editor-measure-drag.spec.ts:46`
(`MEASURE_DRAG=1`); command: `MEASURE_COMMIT=1 pnpm db:sandbox e2e-shell editor-measure-commit` (same shape for
drag), run on chromium-desktop only (1 280 px commit, 1 180 px drag). Not applicable to the desktop project, 3:
the read-only twins at 375 px of `editor-deselect.spec.ts` (:725, :814, :860), skipped by `!isPhone` (« the twin
is the phone view »), run on chromium-375.
- chromium-375, 229 skipped, not applicable: editing needs 1 024 px (C16 floor-guard skips; the phone read-only
path is covered by `editor-access`), desktop-only measurements such as the scrollbar gutter at 1 280 px
(`editor-annotations.spec.ts:924`), and the two hand-run measures above. I did not split these 229 by reason
one by one.
- Counts come from the run log; a rerun can differ. chromium-320 is not part of the run above.
@@ -1,6 +1,12 @@
/** The held-reason bubble (D1): its closing rules and its place, apart from the editor. */ /** The held-reason bubble (D1): its closing rules and its place, apart from the editor. */
import { afterEach, describe, expect, it } from 'vitest' import { afterEach, describe, expect, it } from 'vitest'
import { act, cleanup, render, renderHook, screen } from '@testing-library/react' import {
act,
cleanup,
render,
renderHook,
screen,
} from '@testing-library/react'
import HeldReasonBubble from '@/components/editor/HeldReasonBubble' import HeldReasonBubble from '@/components/editor/HeldReasonBubble'
import { useHeldBubble } from '@/components/editor/useHeldBubble' import { useHeldBubble } from '@/components/editor/useHeldBubble'
@@ -13,10 +19,9 @@ function opened(tab = 'annotations') {
const button = document.createElement('button') const button = document.createElement('button')
document.body.append(button) document.body.append(button)
const ref = { current: button } const ref = { current: button }
const hook = renderHook( const hook = renderHook(({ held, tab }) => useHeldBubble(held, tab, ref), {
({ held, tab }) => useHeldBubble(held, tab, ref), initialProps: { held: true, tab },
{ initialProps: { held: true, tab } }, })
)
act(() => hook.result.current.show()) act(() => hook.result.current.show())
expect(hook.result.current.open).toBe(true) expect(hook.result.current.open).toBe(true)
return { hook, button } return { hook, button }
@@ -71,7 +76,7 @@ describe('closing', () => {
expect(key(button).defaultPrevented).toBe(false) expect(key(button).defaultPrevented).toBe(false)
}) })
it('Escape typed in a text field closes it and stays the field\'s', () => { it("Escape typed in a text field closes it and stays the field's", () => {
const { hook } = opened() const { hook } = opened()
const field = document.createElement('input') const field = document.createElement('input')
document.body.append(field) document.body.append(field)
@@ -83,7 +88,14 @@ describe('closing', () => {
describe('the place', () => { describe('the place', () => {
const rect = (left: number, right: number, top = 0, bottom = 40) => const rect = (left: number, right: number, top = 0, bottom = 40) =>
({ left, right, top, bottom, width: right - left, height: bottom - top }) as DOMRect ({
left,
right,
top,
bottom,
width: right - left,
height: bottom - top,
}) as DOMRect
function anchor() { function anchor() {
const button = document.createElement('button') const button = document.createElement('button')
document.body.append(button) document.body.append(button)
@@ -112,7 +124,7 @@ describe('the place', () => {
expect(bubble.style.maxWidth).toBe('min(18rem, 952px)') expect(bubble.style.maxWidth).toBe('min(18rem, 952px)')
}) })
it('ends left of the strip\'s commands when the strip is shown', () => { it("ends left of the strip's commands when the strip is shown", () => {
strip(760) strip(760)
render(<HeldReasonBubble anchor={anchor()} text="why" />) render(<HeldReasonBubble anchor={anchor()} text="why" />)
const bubble = screen.getByTestId('history-hold-bubble') const bubble = screen.getByTestId('history-hold-bubble')
@@ -794,7 +794,7 @@ describe('why a button is held (point 6)', () => {
return user return user
} }
it('is announced by the button\'s always-mounted status region, once per press', async () => { it("is announced by the button's always-mounted status region, once per press", async () => {
const user = await openAnnotations() const user = await openAnnotations()
stacks() stacks()
pend() pend()