chore(memory): R2 Rev 6 decision, plan and contract 32-36

This commit is contained in:
bchanot committed 2026-11-15 21:14:34 +01:00
1 parent 8681e66ec9
commit 6de88bbb7c
3 files changed
+132

No files matched your search

@@ -241,3 +241,25 @@ SCOPE AMENDMENT 2026-11-14 (controller): docs/development/V1-2-6_UX_PLAN.md and
EVIDENCE: MET FOLLOWUP_DOCS_OK (controller 2026-11-15, rc 0; verifier rerun)
CLARIFICATIONS 2026-11-15 (controller, owner brief 2026-11-15): the tests removed or reduced in b41c24b..HEAD (editor-shell-layout.spec.ts sheet edge geometry, editor-finding-dialog / editor-findings citation controls in the finding form, editor-initial-tab tier parameter, editor-reference-dialog reference over the side sheet, editor-references-panel sheet scrim and header) cover behaviour the owner asked to remove (side sheet, citing in the finding form, phone split); their replacements live in editor-citations-edit.test.tsx, editor-citations-guards.test.tsx and the updated e2e specs. These assertion drops are authorized.
## Owner pre-closure brief 2026-11-15 (« Avant la clôture définitive de R2 »): additional criteria
32. [gated 2026-11-15] In the references dialog's edit mode, the select only browses: arrow keys or a pick never change the draft; a « Citer » button adds the chosen reference (unit + e2e keyboard).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && grep -q "'editor.citations.cite'" src/i18n/fr.ts && grep -q "'editor.citations.cite'" src/i18n/en.ts && echo CITE_KEY_OK
EXPECT: CITE_KEY_OK
EVIDENCE: MET CITE_KEY_OK (controller 2026-11-15 rc 0; verifier rerun)
33. [gated 2026-11-15] A reference created from the references dialog's edit mode is written only by its « Enregistrer », together with the citations, as ONE undoable operation; abandoning the draft leaves the library unchanged; « Ajouter une référence » in the Références tab still creates an independent reference at once (unit + e2e).
34. [gated 2026-11-15] Labels follow the cited element's kind: « Références du constat » / « Ce constat ne cite aucune référence. » for a finding, « Références de la famille » / « Cette famille ne cite aucune référence. » for a family, same logic in EN and in the filtered Références tab (unit).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && grep -q "Références de la famille" src/i18n/fr.ts && grep -q "Cette famille ne cite aucune référence." src/i18n/fr.ts && grep -q "'editor.references.panel_empty_family'" src/i18n/en.ts && echo FAMILY_LABELS_OK
EXPECT: FAMILY_LABELS_OK
EVIDENCE: MET FAMILY_LABELS_OK (controller 2026-11-15 rc 0; verifier rerun)
35. [gated 2026-11-15] The shared Dialog ✕ has a touch area of at least 44 × 44 px (e2e bounding box at 375 and 1280, axe).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && grep -q "h-11 w-11" src/components/ui/Dialog.tsx && echo CLOSE_44_OK
EXPECT: CLOSE_44_OK
EVIDENCE: MET CLOSE_44_OK (controller 2026-11-15 rc 0; verifier rerun)
36. [gated 2026-11-15] Docs: limits lifted, labels table, short manual checks for db:trial; the full sweep reported with its failures (never as all green).
CLARIFICATIONS 2026-11-15 b (controller, owner pre-closure brief): the Rev 5 unit tests in apps/app/tests/unit/editor-citations-edit.test.tsx asserting that a reference created from the edit mode is in the library before « Enregistrer » (two undo steps) and stays uncited after an abandon are inverted by Task 15 (owner item 2 asks the opposite behaviour); the inversion is authorized, the new assertions are stricter (library unchanged, one undo step).
SCOPE AMENDMENT 2026-11-15 (controller): apps/app/e2e/harness/dialog.tsx joins FILE SCOPE (the ui Dialog harness gains the long-title case for criterion 35; dev-server only, never built).
CLARIFICATIONS 2026-11-15 c (controller, owner pre-closure brief: « Le balayage complet présente toujours des échecs et ne doit pas être annoncé comme entièrement vert »): for criterion 10, full-sweep failures that are browser crashes (« Target crashed ») or navigation timeouts under the accumulated sandbox load, and that pass when their spec runs alone, are reported to the owner with their counts and names, as the BLK-015 family; they are not counted as fixed and the sweep is never announced green.