From 6d2ba0dbf23536841a1bc74995ea99ec5f0793ab Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 16 Nov 2026 20:31:36 +0100 Subject: [PATCH] test(app): phone filters panel on the sandbox sheet list spec --- apps/app/e2e/shell/admin-sheets-list.spec.ts | 85 ++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/apps/app/e2e/shell/admin-sheets-list.spec.ts b/apps/app/e2e/shell/admin-sheets-list.spec.ts index 9e89a16d..6087a258 100644 --- a/apps/app/e2e/shell/admin-sheets-list.spec.ts +++ b/apps/app/e2e/shell/admin-sheets-list.spec.ts @@ -283,6 +283,78 @@ async function checkLongSearch( ) } +const PHONE_MAX_WIDTH = 639 + +/** The four filters' selects, by their label, and the panel that holds them. */ +const filterSelect = (page: Page, dict: Dict, key: string) => + page.getByLabel(dict[`admin.sheets.filter.${key}` as keyof Dict]) +const filtersToggle = (page: Page, dict: Dict) => + page.getByRole('button', { + name: new RegExp(`^${escaped(dict['admin.sheets.filters'])}`), + }) + +/** Desktop (`sm` and up): the filters are always there and no button asks for them. */ +async function checkDesktopFilters(page: Page, dict: Dict) { + await expect(filtersToggle(page, dict)).toBeHidden() + for (const key of [ + 'species', + 'sheet_status', + 'version_status', + 'round_status', + ]) + await expect(filterSelect(page, dict, key)).toBeVisible() +} + +/** Phone: collapsed by default, search and sort in view, closed means untabbable. */ +async function checkClosedFilters(page: Page, dict: Dict) { + const toggle = filtersToggle(page, dict) + await expect(toggle).toHaveText(dict['admin.sheets.filters']) + await expect(toggle).toHaveAttribute('aria-expanded', 'false') + await expect(searchField(page, dict)).toBeVisible() + await expect(page.getByLabel(dict['admin.sheets.sort_by'])).toBeVisible() + await expect(filterSelect(page, dict, 'species')).toBeHidden() + await toggle.focus() + await page.keyboard.press('Tab') + const inPanel = await page.evaluate(() => + Boolean(document.activeElement?.closest('#admin-sheets-filters')), + ) + expect(inPanel, 'Tab never enters the closed panel').toBe(false) +} + +/** Phone: open, filter, count on the button, close keeps them, reset. */ +async function checkPhoneFilters(page: Page, dict: Dict) { + const toggle = filtersToggle(page, dict) + await checkClosedFilters(page, dict) + await toggle.click() + await expect(toggle).toHaveAttribute('aria-expanded', 'true') + for (const key of [ + 'species', + 'sheet_status', + 'version_status', + 'round_status', + ]) + await expect(filterSelect(page, dict, key)).toBeVisible() + await filterSelect(page, dict, 'version_status').selectOption('draft') + await filterSelect(page, dict, 'sheet_status').selectOption('active') + const label = (n: number) => + dict['admin.sheets.filters_active'].replace('{count}', String(n)) + await expect(toggle).toHaveText(label(2)) + await expectAccessible(page, 'the open filters') + await expectNoHorizontalOverflow(page, 'the open filters') + await toggle.click() + await expect(filterSelect(page, dict, 'version_status')).toBeHidden() + await expect(toggle).toHaveText(label(2)) + await toggle.click() + await expect(filterSelect(page, dict, 'version_status')).toHaveValue('draft') + await expect(filterSelect(page, dict, 'sheet_status')).toHaveValue('active') + await page + .getByRole('button', { name: dict['admin.sheets.filters_reset'] }) + .click() + await expect(toggle).toHaveText(dict['admin.sheets.filters']) + await expect(toggle).toBeFocused() + await expect(filterSelect(page, dict, 'version_status')).toHaveValue('') +} + test.describe.configure({ mode: 'serial' }) test.describe('official sheet list: search, sort and dates (R3)', () => { @@ -351,6 +423,19 @@ test.describe('official sheet list: search, sort and dates (R3)', () => { // 3. A search past the field's limit, its sentence, then « Effacer la recherche ». await checkLongSearch(page, dict, locale, token, total) }) + + test('the filters are collapsible on a phone, always shown on a desktop', async ({ + page, + }) => { + test.setTimeout(240_000) + const { actor } = fixtures! + await openAdmin(page, dict, locale, actor) + await page.goto('/app/admin/sheets') + await expect(heading(page, dict['admin.sheets.title'])).toBeVisible() + const width = page.viewportSize()?.width ?? 0 + if (width > PHONE_MAX_WIDTH) return checkDesktopFilters(page, dict) + await checkPhoneFilters(page, dict) + }) }) } })