chore(memory): TR_PW rotation, init log fix, LRN-127

This commit is contained in:
bchanot committed 2026-11-11 19:54:42 +01:00
1 parent 5f63d2229c
commit 6ceced5c06
4 files changed
+72 -2

No files matched your search

+1
View File
@@ -548,3 +548,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
## 2026-11-11
- db:trial closure: code review + 2 fresh re-reviews fixed (d3bdbbe f2cbf68 953ae41). Strict absent match broke on real docker: inspect -f prints '\n' on stdout before stderr error; fresh re-review caught it, stub now splits streams. GATE 0 MET, harness 372/0, plan read-only: create would proceed. Stopped before create, owner go pending.
- db:trial first create 2026-11-11 at 255dd67 (owner go): 6 containers, net, 2 volumes as planned, loopback ports only, DEV and sandbox unchanged, 17 migrations, equine draft equal. Interrupted at check 3: TR_PW in db container log, image migrate.sh ALTER USER logged during init. LRN-123..126 written. Owner decision pending.
- db:trial TR_PW leak 2026-11-11: owner-ordered one-off rotation (5 roles, auth/storage/rest recreated, old pw refused, services ok, DEV/sandbox unchanged); fix 5f63d22 -c log_statement=none on server cmdline (harness 373/0, control 372/1, verifier CONFORME, security PASS); LRN-127. Real proof pending: create on fresh volume.
+8
View File
@@ -878,3 +878,11 @@ Trap: substring tests like `*"no such"*` (meant for "No such container" / "no su
Apply: never classify Docker errors by substring; exact whole-sentence match per kind on stderr, everything else refuses (see the inspect -f learning).
Limit: wording of this client version only.
## LRN-127 — Postgres image init logs role password: log_statement must be off on server command line (2026-11-11)
**Context**: db:trial first real create 2026-11-11 (255dd67). TR_PW found in `docker logs faunosteo_trial_db` line 379: `postgres@postgres LOG: statement: ALTER USER supabase_admin WITH PASSWORD '…'`.
**Cause** (demonstrated): image `supabase/postgres:17.11.0.004` init script `/docker-entrypoint-initdb.d/migrate.sh` sends role password as SQL text (lines 36/46/54/59) on init temp server; image `/etc/postgresql/postgresql.conf:545` has `log_statement = 'ddl'` → statement + password to stderr = container log. Our `/etc/postgresql.schema.sql` session `set log_statement='none'` runs after → too late. Per-role `log_statement=none` (image migration 20250205060043) also after.
**Fix** (5f63d22): `-c log_statement=none` appended to `exec docker-entrypoint.sh postgres ...` in DB_INIT. Entrypoint `_main` → `docker_temp_server_start "$@"` → `pg_ctl -o "$(printf '%q ' "$@")"` passes every arg after `postgres` to temp server and final server; command line (PGC_S_ARGV) beats postgresql.conf + auto.conf; no init script sets log_statement other than none (grep). Harness check db-trial-check.sh:726, positive control red 372/1 → green 373/0. Static proof only: real proof = create on fresh volume + container log scan (counts only, SUPABASE.md §5.2). Trade-off: DDL no longer logged on trial server.
**Not closed** (named, owner scope): failing init statement still logged (`log_min_error_statement = error`); migrate.sh puts password on psql argv during init; db-sandbox.sh same DB_INIT without flag; DEV CLI stack likely same log line.
**Remediation of exposed value**: one-off TR_PW rotation 2026-11-11 (owner): 5 roles one tx (local logging off), secrets.env, auth/storage/rest recreated by `pnpm db:trial start`; old pw refused on scram path (container network IP; 127.0.0.1 is trust, proves nothing), new ok ×5; db container frozen env keeps dead old value.
**Future application**: any self-hosted Postgres image with init scripts → set logging GUCs on server command line, never in init SQL; mandatory pre-production check in DEPLOY.md security prerequisites. Password probe must use non-trust pg_hba path + control with wrong password.