docs(docs): close R2 after the owner trial, record U2 orientation
This commit is contained in:
1 parent
791fc03a0d
commit
685a96741b
8 files changed
+246
-49
No files matched your search
@@ -171,6 +171,8 @@ The criteria below are the contract as written.
|
||||
|
||||
### R2 — The Références tab (D1 to D4)
|
||||
|
||||
Status (2026-11-14): R2 validated by the owner's trial, closed pending the final manual checks (« Owner trial and
|
||||
closure 2026-11-14 » below, `V1-2-6_OWNER_TRIAL.md` §4.12).
|
||||
Status (2026-11-13): corrected, still awaiting the owner's validation (corrections below).
|
||||
Status (2026-11-12): built on `feature/v1-2-anatomical-sheets`, awaiting the owner's validation (nothing merged,
|
||||
nothing deployed). Commits: `65a8fd3` (plan, rev 4 after the owner's GO), `fc3fec7` R2.0 (the panel's place renamed
|
||||
@@ -182,7 +184,10 @@ Labels: `V1-2-6_R2_LABELS.md`. Decision record: BDR-114. What the build settled
|
||||
- The panel opens from a finding only (owner, 2026-11-12). The family's former trigger is removed; a family keeps
|
||||
its inline list and « Retirer ».
|
||||
- « Retirer de ce constat » removes that one citation (the reference stays in the document) and marks the finding
|
||||
« À confirmer » (core rule, `edit.rs`); one « Défaire » restores the citation and the status together.
|
||||
« À confirmer » (core rule, `edit.rs`); one « Défaire » restores the citation and the status together. Superseded
|
||||
2026-11-14: the sheet no longer removes a citation (read-only, « Modifier » and « Aller à » only, key
|
||||
`editor.references.remove_citation` deleted); a citation is removed from the finding's edit form (see « Owner trial
|
||||
and closure 2026-11-14 »).
|
||||
- Zero state: when the last citation is gone the panel stays open with « Ce constat ne cite plus aucune
|
||||
référence. » and closes on a tab change.
|
||||
- Selecting a tab closes the panel. Every close (✕, Escape outside a field, scrim, tab, « Aller à », « Tout
|
||||
@@ -279,6 +284,7 @@ Commits:
|
||||
- Task 3, reference dialog, read-only tiles, filter by finding, owner journey: `8031e00`, `7a64daf`, `8b42816`,
|
||||
`3bb3603`, `8a60128`.
|
||||
- Task 4, « Plus » overlay and sticky sidebar: `ca5804a`, `dfc8965`.
|
||||
- Owner trial adjustments of 2026-11-14 (Tasks 6 to 8): see « Owner trial and closure 2026-11-14 » below.
|
||||
|
||||
Behaviour:
|
||||
- Dialogs. A finding opens in a modal dialog (view mode, then « Modifier »); a reference opens in its own dialog (edit
|
||||
@@ -286,12 +292,12 @@ Behaviour:
|
||||
any close with a change asks « Abandonner les modifications ? » first. A save is one « Défaire ». Reference tiles
|
||||
are read-only (disclosure, « Modifier », « Supprimer » or the cited hint). Focus returns to the opener.
|
||||
- Side sheet. The citations panel is a modal sheet at the right edge (34 rem at most) stacked over the finding dialog,
|
||||
usable by keyboard and touch. Content as before: read tiles, « Modifier », « Retirer de ce constat », « Aller à »,
|
||||
« Tout afficher ».
|
||||
usable by keyboard and touch. Content: read tiles, « Modifier », « Aller à », « Tout afficher » (« Retirer de ce
|
||||
constat » was removed from it on 2026-11-14).
|
||||
- History. Tab, Annotations section, finding dialog, finding creation, sheet, reference dialog, filter are browser
|
||||
history entries (`apps/app/src/editor/history`). Back and Forward restore the view and the scroll; a reload keeps
|
||||
tab and filter, never a form. Entries carry the sheet and account ids and hold navigation only; they are reset on a
|
||||
sheet or account change. A Back that would drop a dirty form re-pushes the view and shows the confirmation.
|
||||
tab and filter, never a form. Entries carry the sheet id and a random session tag (2026-11-14: no longer the account id) and hold
|
||||
navigation only; they are reset on a sheet or account change. A Back that would drop a dirty form re-pushes the view and shows the confirmation.
|
||||
- Filter. « Tout afficher dans l'onglet Références » shows only the references the finding cites, with the chip
|
||||
« Références du constat : <nom> » and its « × », plus « Revenir au constat ». Search and sort stay usable. The
|
||||
owner's eight steps (finding A, « 2 références », sheet, « Tout afficher », filtered tab, Back, back on A with the
|
||||
@@ -307,23 +313,27 @@ account change; the Android Back request closes « Plus » first; no new mockups
|
||||
provided no user change is lost silently.
|
||||
|
||||
Stated limits:
|
||||
1. Deleting a finding replaces its dialog entry, so the next Back press does nothing visible once (R2F-3).
|
||||
1. Deleting a finding replaces its dialog entry, so the next Back press does nothing visible once (R2F-3). Lifted
|
||||
2026-11-14: the deletion pops the dialog entry, the first Back moves.
|
||||
2. Lifted by the final review: « Aller à » a finding or a zone opens its dialog in the same move, one history entry;
|
||||
Back returns to the place left, sheet included.
|
||||
3. A move made in the same instant as a pending Back can be swallowed (not reachable at human speed).
|
||||
4. « Aller à » a finding opens its dialog in view mode.
|
||||
4. « Aller à » a finding opens its dialog in view mode (accepted again by the owner, 2026-11-14).
|
||||
5. The search of the References tab is not in the history: a plain tab change keeps it, « Tout afficher » clears it;
|
||||
Back still restores the filtered view.
|
||||
6. Android Back closing « Plus » relies on `CloseWatcher` (Chrome Android). Proved by a stub test only, not on a
|
||||
device. Without `CloseWatcher`, Back navigates as before; Escape and an outside press still close.
|
||||
7. A tap outside the open « Plus » menu only closes it (the page does not receive that tap).
|
||||
8. After choosing a « Plus » entry by keyboard, focus goes to the page body (pre-existing).
|
||||
8. After choosing a « Plus » entry by keyboard, focus goes to the page body (pre-existing). Lifted 2026-11-14: the
|
||||
focus goes to the new tab's panel.
|
||||
9. BLK-015: `admin.spec.ts` still fails on the accumulated sandbox (grant accumulation; pagination is RR-13).
|
||||
Unchanged by the finish.
|
||||
Also stated in the plan: leaving the editor by Back past its first entry cannot be refused (BDR-078, recovery copy).
|
||||
A dirty dialog lost that way (a Back of several entries from the history menu) is no longer silent: one flag in this
|
||||
tab's sessionStorage (layer and element key, never the text) makes the next mount of that sheet for that account say
|
||||
once « Une saisie non enregistrée a été abandonnée en quittant l'éditeur »; the text itself is not kept.
|
||||
tab's sessionStorage (layer and element key, never the text) makes the next mount of that sheet for that session tag say
|
||||
once « Une saisie non enregistrée a été abandonnée en quittant l'éditeur »; the text itself is not kept. Since
|
||||
2026-11-14 the browser is asked first where it can cancel the jump (see the closure subsection); the flag and the
|
||||
notice remain the fallback.
|
||||
Chromium's skippable-entry intervention and Android's close-watcher grouping of two restored dialogs are untested
|
||||
(Playwright's `goBack` bypasses them) and are checked in the owner's phone trial.
|
||||
|
||||
@@ -333,7 +343,62 @@ as one (`draft_dropped` for references and the inline drafts are removed); a pen
|
||||
mounted edit view (no inline draft remains, « Défaire » and « Refaire » are unreachable while a dialog is open). Still
|
||||
true: a button under a field whose blur-commit is refused can lose its first click (other inline editor forms).
|
||||
|
||||
Status: awaiting the owner's trial (§4.11). Not run on a device: Android Back with a real `CloseWatcher`.
|
||||
Status: validated by the owner's trial on 2026-11-14 (next subsection). Not run on a device: Android Back with a real
|
||||
`CloseWatcher`.
|
||||
|
||||
#### Owner trial and closure 2026-11-14
|
||||
|
||||
Validation: the owner's trial of 2026-11-14 validated the R2 main journeys (`V1-2-6_OWNER_TRIAL.md` §4.11). The
|
||||
trial asked for last adjustments, built on `feature/v1-2-anatomical-sheets` on top of `afc1051` (plan « Rev 4 »,
|
||||
`.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md`, contract criteria 19 to 25). Nothing merged, nothing deployed.
|
||||
|
||||
Adjustments:
|
||||
- References are cited only in the edit mode of a finding (`f0e49fd`, `270444e`). The view mode of the dialog only shows
|
||||
the « n références » button that opens the sheet (a family shows its list read-only). The edit form keeps a draft list of the citations with « Retirer » on each and « Citer
|
||||
une référence »; the one « Enregistrer » writes the citations with the other fields as one undoable operation. The
|
||||
citations sheet is read-only for the finding (no « Retirer de ce constat »); while the form is open it lists the
|
||||
draft's references. The key `editor.references.remove_citation` is deleted (`V1-2-6_R2_LABELS.md` §9).
|
||||
- Deletion and Back (`085c568`, `4018344`): the deletion closes its dialog by popping the entry, so the first Back
|
||||
moves; the first « Défaire » after a deletion restores the finding at once (Constats opens, the row is selected and
|
||||
focused). Choosing « Plus » entry puts the focus on the new tab's panel (the panels take `tabIndex=-1` and show a
|
||||
ring only on keyboard focus, with a transparent outline for forced colours).
|
||||
- Session tag (`07bebbc`, `579d8af`): history entries carry a random 128-bit tag kept in `sessionStorage`, never the
|
||||
account id. The tag is bound to the account by a non-secret fingerprint (FNV-1a 64, synchronous, so it works on the
|
||||
http LAN origin where `crypto.subtle` is missing), rotates on another account and at sign-out, and the old
|
||||
left-draft flags are cleared. A record of the earlier shape, or an empty tag, reads as foreign (fail closed).
|
||||
`AuthProvider.tsx` starts the sign-out subscription (3 lines, outside the first file scope, amended by the
|
||||
controller).
|
||||
- Leave confirmation (`07bebbc`, `579d8af`, `791fc03`): where the browser exposes the Navigation API and the event is
|
||||
cancelable, a jump of several entries out of the editor with a dirty finding or reference dialog is cancelled and
|
||||
the top dirty dialog asks « Abandonner les modifications ? ». « Abandonner » runs the jump again with
|
||||
`traverseTo`, leaving no flag and no notice. With two dirty dialogs the question cascades from the top; the
|
||||
reference's « Abandonner » also closes the citations sheet so the finding's question is not hidden under it.
|
||||
Without the API or when the event is not cancelable, the earlier flag and notice stay.
|
||||
- Notice after the loss elsewhere: unchanged text, now keyed by the session tag.
|
||||
|
||||
Support of the confirmation (what `task-8-report.md` of the run proves): verified on Chromium desktop (the pinned
|
||||
Playwright Chromium, a history jump through the DevTools protocol, one dirty dialog and two stacked); the fallback
|
||||
logic is covered by unit tests (no API, non-cancelable event). Not verified: Firefox, Safari, Android Chrome on a
|
||||
real phone, a click in the real toolbar history menu. The http-origin restore is proved by a unit test only.
|
||||
|
||||
Accepted limits (owner, 2026-11-14):
|
||||
1. A move made in the same instant as a pending Back can be swallowed (not reachable at human speed).
|
||||
2. « Aller à » a finding opens its dialog in view mode.
|
||||
3. The search of the References tab is kept across tabs (not in the history; « Tout afficher » clears it).
|
||||
4. The first tap outside the open « Plus » menu only closes it.
|
||||
5. A sign-out made while a dialog holds unsaved text (from another tab, for instance) leaves no notice later: the tag
|
||||
rotates and its flags are cleared for account separation.
|
||||
6. In the leave cascade, « Continuer la saisie » on a lower dialog keeps that draft; a draft already abandoned above
|
||||
stays dropped (the user's choice), and one Back then reopens the citations sheet.
|
||||
7. Android Back closing « Plus » relies on `CloseWatcher` and is proved by a stub test only (limit 6 above).
|
||||
8. BLK-015 and `admin.spec.ts`: tracked apart (RR-13), unchanged.
|
||||
|
||||
Lifted by this round: the dead Back after a deletion (finish limit 1) and the focus lost to the page body after a
|
||||
« Plus » choice (finish limit 8). Changed: the account id left the history entries for the session tag; a multi-entry
|
||||
leave is confirmed where the browser can cancel it.
|
||||
|
||||
Status: R2 validated, closed pending the final manual checks (`V1-2-6_OWNER_TRIAL.md` §4.12). The owner still has to
|
||||
check Android Back on a real phone.
|
||||
|
||||
Original plan text:
|
||||
|
||||
@@ -430,7 +495,7 @@ The owner-facing table with consequences, in French: `docs/design/v1-2-6-r0/ARBI
|
||||
|---|---|---|---|
|
||||
| A1 | Reorder commands with a search active in document order | Hidden, as checkpoint choice 10 already rules (moving among a hidden subset is ambiguous); one hint line. | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A2 | Tiles open at once; how long open state, search and sort last | Several open at once; kept while the editor stays open (kept-mounted tab), reset when it reopens. | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A3 | Actions in the contextual panel | « Modifier », « Retirer de ce constat », « Aller à »; no add, no reorder, no « Supprimer » (always refused by the core there). « Tout afficher » opens the tab with search and sort reset, focus on its heading. | RATIFIED: « Retirer de ce constat » removes only the finding's citation of the reference, never the reference; undoable through the editor history |
|
||||
| A3 | Actions in the contextual panel | « Modifier », « Retirer de ce constat », « Aller à »; no add, no reorder, no « Supprimer » (always refused by the core there). « Tout afficher » opens the tab with search and sort reset, focus on its heading. | RATIFIED: « Retirer de ce constat » removes only the finding's citation of the reference, never the reference; undoable through the editor history. Since 2026-11-14 the removal is made from the finding's edit form (« Retirer » on the draft list), not from the sheet |
|
||||
| A4 | Closed tile content | Citation on two lines at most, type, « Citée N fois » or « Non citée » (the count includes families). | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A5 | Escape priority | Dialog, then open menu, then contextual panel, then tracing in progress, then selection. | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A5b | « Toutes les annotations » already clears the selection | Keep both (D6). | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
|
||||
Reference in new issue
Block a user