feat(editor): kept-mounted tabs, sections and references panel
Each visited tab, Annotations section and the references panel stay
mounted in a KeptPlace (hidden, nested visibility). Composed canvases
detach while hidden. One JSON.parse per document text. Focus requests
reach only their owning place.
Rewritten assertions (R-24):
- editor-route.test.tsx:127: annotations testid toBeNull -> not.toBeVisible
- editor-sections.test.tsx: place('annotations.drawing') toBeNull -> not.toBeVisible
- editor-journey.spec.ts:311: page-wide getByLabel('Nom (FR)') -> scoped to place 'general'
- editor-tabs-lists.test.tsx: ReferencesPanel `open` prop dropped (the wrapper hides it)
- editor-annotations-tab, editor-focus-request, editor-sections tests: props gain `visited`
No assertion removed.
This commit is contained in:
1 parent
ca184da4d9
commit
6689827a8d
18 files changed
+847
-81
No files matched your search
@@ -0,0 +1,141 @@
|
||||
import { fr } from '@/i18n/fr'
|
||||
import type { Page, TestInfo } from '@playwright/test'
|
||||
import { expect, test } from '../support/browser'
|
||||
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
||||
import {
|
||||
backToDrawing,
|
||||
closeReferences,
|
||||
editorActor,
|
||||
openEditor,
|
||||
openReferences,
|
||||
openSection,
|
||||
place,
|
||||
pointOf,
|
||||
seedDraft,
|
||||
selectTab,
|
||||
shapeWith,
|
||||
showDrawing,
|
||||
} from '../support/editor'
|
||||
|
||||
// V1-2.6 U1 B2a: tabs, Annotations sections and the references panel stay mounted. What
|
||||
// was typed, the canvas zoom and the focus survive a change of place; focus lands on a
|
||||
// named element, never on `body`. happy-dom does not refuse focus on hidden elements, so
|
||||
// the focus rules are checked here with `document.activeElement`.
|
||||
|
||||
const dict = fr
|
||||
|
||||
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
|
||||
|
||||
async function open(page: Page) {
|
||||
const actor = await editorActor('fr')
|
||||
const free = {
|
||||
...pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
|
||||
finding_zone_id: null,
|
||||
}
|
||||
const seed = await seedDraft(actor, { shape: shapeWith(free) })
|
||||
await openEditor(page, dict, actor, seed.sheetId)
|
||||
return seed
|
||||
}
|
||||
|
||||
const active = (page: Page) => page.locator(':focus')
|
||||
const layerTransform = (page: Page) =>
|
||||
page
|
||||
.getByTestId('annotation-canvas')
|
||||
.evaluate((box) => (box.firstElementChild as HTMLElement).style.transform)
|
||||
|
||||
test.describe('editor shell, kept places (B2a)', () => {
|
||||
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
||||
test.beforeEach(async ({ context }, info) => {
|
||||
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
||||
await routeToSandbox(context)
|
||||
})
|
||||
test.afterEach(async ({ context }) => {
|
||||
await dropLateReplays(context)
|
||||
})
|
||||
|
||||
test('the category form text and the zoom survive tab and section changes', async ({
|
||||
page,
|
||||
}) => {
|
||||
await open(page)
|
||||
await openSection(page, dict, 'categories')
|
||||
await page.locator('#category-new-fr').fill('Brouillon')
|
||||
await selectTab(page, dict, 'general')
|
||||
await expect(place(page, 'annotations.categories')).toHaveCount(0)
|
||||
await selectTab(page, dict, 'annotations')
|
||||
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
|
||||
|
||||
await backToDrawing(page, dict)
|
||||
await page
|
||||
.getByRole('button', { name: dict['catalogue.zoom.in'], exact: true })
|
||||
.click()
|
||||
const zoomed = await layerTransform(page)
|
||||
expect(zoomed).not.toContain('scale(1)')
|
||||
await selectTab(page, dict, 'findings')
|
||||
await showDrawing(page, dict)
|
||||
expect(await layerTransform(page)).toBe(zoomed)
|
||||
})
|
||||
|
||||
test('the references panel keeps its form text and no id repeats', async ({
|
||||
page,
|
||||
}) => {
|
||||
await open(page)
|
||||
await openReferences(page, dict)
|
||||
await page.locator('#reference-new-citation').fill('Smith 1999')
|
||||
await closeReferences(page, dict)
|
||||
await openReferences(page, dict)
|
||||
await expect(page.locator('#reference-new-citation')).toHaveValue(
|
||||
'Smith 1999',
|
||||
)
|
||||
for (const tab of ['general', 'findings', 'verification']) {
|
||||
await selectTab(page, dict, tab)
|
||||
}
|
||||
for (const section of ['views', 'categories', 'regions'] as const) {
|
||||
await openSection(page, dict, section)
|
||||
}
|
||||
const repeated = await page.evaluate(() => {
|
||||
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
|
||||
return ids.filter((id, i) => ids.indexOf(id) !== i)
|
||||
})
|
||||
expect(repeated).toEqual([])
|
||||
})
|
||||
|
||||
test('focus lands on a named element after a tab click, « Retour au dessin » and « Aller à »', async ({
|
||||
page,
|
||||
}) => {
|
||||
await open(page)
|
||||
await selectTab(page, dict, 'findings')
|
||||
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
|
||||
|
||||
await openSection(page, dict, 'categories')
|
||||
await backToDrawing(page, dict)
|
||||
await expect(active(page)).toHaveAttribute(
|
||||
'data-section-entry',
|
||||
'categories',
|
||||
)
|
||||
|
||||
await selectTab(page, dict, 'verification')
|
||||
await page
|
||||
.getByRole('button', { name: 'Aller à Point libre' })
|
||||
.first()
|
||||
.click()
|
||||
await expect(place(page, 'annotations.drawing')).toBeVisible()
|
||||
await expect(active(page)).toHaveAttribute(
|
||||
'data-properties-heading',
|
||||
'true',
|
||||
)
|
||||
})
|
||||
|
||||
test('arrowing back onto a tab keeps the focus on the tab', async ({
|
||||
page,
|
||||
}) => {
|
||||
await open(page)
|
||||
await selectTab(page, dict, 'annotations')
|
||||
await page
|
||||
.getByRole('tab', { name: dict['editor.tab.annotations'] })
|
||||
.focus()
|
||||
await page.keyboard.press('ArrowRight')
|
||||
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
|
||||
await page.keyboard.press('ArrowLeft')
|
||||
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
||||
})
|
||||
})
|
||||
Reference in new issue
Block a user