chore(memory): R2 plan rev 4 after owner GO (panel from a finding only)
This commit is contained in:
1 parent
49867bad19
commit
65a8fd37b8
3 files changed
+75
-16
No files matched your search
@@ -129,24 +129,45 @@ Fournir :
|
||||
S'arrêter après R2 et attendre la validation utilisateur.
|
||||
|
||||
## CLARIFICATIONS
|
||||
Q: family detail « n références » button? / A: same panel with family words (« Retirer de cette famille », badge « cette famille », « N références citées par cette famille »); new FR/EN labels in the checkpoint table. [gated 2026-11-12]
|
||||
Q: family detail « n références » button? / A: same panel with family words (« Retirer de cette famille », badge « cette famille », « N références citées par cette famille »); new FR/EN labels in the checkpoint table. [gated 2026-11-12] SUPERSEDED by the owner GO below.
|
||||
Q: 640-1 023 px tab row? / A: all five tabs shown; the row may wrap (fixed per width, never moves on interaction, no horizontal scroll). [gated 2026-11-12]
|
||||
Q: « Retirer » marks the finding / family « À confirmer » (core rule, edit.rs)? / A: accepted; documented in docs and db:trial protocol; one « Défaire » restores both. [gated 2026-11-12]
|
||||
Q: shell gate with editor-equine? / A: excluded from every run (owner §3, §4 « ne pas déclencher une suite dangereuse »); its helper calls are updated for typecheck only, never run; per-id snapshot of pre-existing anatomical_sheets before/after each shell run.
|
||||
Q: where does the FR/EN table live? / A: `docs/development/V1-2-6_R2_LABELS.md` (decided in plan, shown at the gate).
|
||||
Q: panel from a family? / A: NO. Owner GO 2026-11-12 (brief « GO R2 — Plan révision 3 », « Correction obligatoire de R2.1 »): the contextual panel opens only from a finding, per the earlier decision; never from a family without a new arbitration; the library stays reachable from the Références tab. The trigger a family's detail shows today (shared FindingContent) is removed; the family keeps its inline citation list with « Retirer ». [gated 2026-11-12]
|
||||
Q: arbitrations of the gate? / A: owner GO 2026-11-12: (1) permanent Places min-height on the available screen height, mobile browsers and viewport changes handled, no drawing move, no horizontal overflow; (2) motion/react instead of Tailwind motion-reduce:, prefers-reduced-motion and focus return mandatory with or without animation; (3) « Ce constat ne cite plus aucune référence », « Référence introuvable », « Saisie non appliquée : … » accepted provisionally, EN not ratified one by one, full FR/EN table at R2.6; (4) Type sort in business order, deterministic and stable for equal types; (5) « Tout afficher » resets search and sort, keeps open tiles and any edit in progress, never loses a valid entry nor closes unexpectedly. Data controls must prove no unauthorised change, metadata included. [gated 2026-11-12]
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
Seed (from the request); design criteria appended at STEP 3 with [gated].
|
||||
1. Five editor tabs in the order Général, Annotations, Constats, Références, Vérification; below 640 px « Plus » holds Général, Constats, Références; no header « Références » button.
|
||||
2. A cited reference never shows « Supprimer » (hint instead); an uncited one keeps « Supprimer » + existing dialog; the core refusal stays the authority.
|
||||
3. « Retirer de ce constat / cette famille » removes only that association, one « Défaire » restores it; the reference stays in the document.
|
||||
3. « Retirer de ce constat » (panel, finding only) removes only that association, one « Défaire » restores it; the reference stays in the document. [corrected 2026-11-12, owner GO: no family wording]
|
||||
4. Read-only and no-right modes show no edit control in the tab or the panel.
|
||||
5. Search and the four sorts are TypeScript display functions over ids; the document text, stored order, ids and history are identical before and after any search or sort (tested).
|
||||
6. The panel opens only from a finding or family, width ≤ 34 rem and ≤ available width, slide 180 / 140 ms, none under reduced motion, page inert and panel unreachable while closed or exiting, focus back to the trigger if it still exists; no layout shift of the tab content on open / close.
|
||||
6. The panel opens only from a finding (never from a family; corrected 2026-11-12, owner GO), width ≤ 34 rem and ≤ available width, slide 180 / 140 ms, none under reduced motion, page inert and panel unreachable while closed or exiting, focus back to the trigger if it still exists; no layout shift of the tab content on open / close.
|
||||
7. A1 to A4 hold; « Aller à » from Vérification opens the right tile, open and focused; references reachable when a search returns nothing (clear button).
|
||||
8. Exhaustive FR/EN table of new and changed labels with ambiguities: `docs/development/V1-2-6_R2_LABELS.md`; Rust exception rows in `RUST_ARCHITECTURE_REVIEW.md` Part II.
|
||||
9. Gates per sub-lot: typecheck, lint, test:run, build; e2e:ui; e2e:shell on db:sandbox without editor-equine; pre-existing rows unchanged per id; one commit + push per sub-lot.
|
||||
10. No change under supabase/, crates/, scripts/db-trial*, docker/; no db:trial / DEV access; untracked review file kept; no merge.
|
||||
11. [gated 2026-11-12] A family's detail shows no « {n} références » trigger and keeps its inline citation list with « Retirer »; `open_citations` with a family key is a no-op; the panel carries no family wording.
|
||||
12. [gated 2026-11-12] The header « Références » button and its id are gone.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && ! grep -rq "REFERENCES_BUTTON_ID" apps/app/src && ! grep -rq "editor-references-panel" apps/app/src && echo NO_HEADER_BUTTON
|
||||
EXPECT: NO_HEADER_BUTTON
|
||||
EVIDENCE: pending
|
||||
13. [gated 2026-11-12] New files exist: pure sort and safe-link modules, the two new shell specs, the labels table.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && test -f apps/app/src/editor/references/sort.ts && test -f apps/app/src/editor/references/safeLink.ts && test -f apps/app/e2e/shell/editor-references.spec.ts && test -f apps/app/e2e/shell/editor-citations.spec.ts && test -f docs/development/V1-2-6_R2_LABELS.md && echo R2_FILES_OK
|
||||
EXPECT: R2_FILES_OK
|
||||
EVIDENCE: pending
|
||||
14. [gated 2026-11-12] Sorts: sheet order, citation (Intl.Collator base + numeric), citation count descending, Type in REFERENCE_TYPES order; equal keys keep the stored order (deterministic, stable); inputs never mutated; unit-tested with permutations.
|
||||
15. [gated 2026-11-12] Closing: every close (✕, Escape outside text fields, scrim, « Tout afficher », « Aller à », tab switch, element gone, read-only flip) records one pending move applied after the exit; focus lands on the trigger if present, else the active tab button (« Plus » below 640 px); checked by `document.activeElement` in normal and reduced motion; page inert and panel unreachable during exit; a user close with a refused draft is cancelled (field focused), a forced close drops it with the « Saisie non appliquée : … » announcement.
|
||||
16. [gated 2026-11-12] « Tout afficher » resets search and sort, keeps open tiles and any tile in edit; a valid panel draft is committed before the close.
|
||||
17. [gated 2026-11-12] Layout: Places min-height = dynamic viewport height minus the top bar, permanent; panel wrapper `overflow-x: clip`; document scrollWidth / scrollHeight and the drawing box unchanged before, during and after open / close at 375, 1 024, 1 180, 1 279, 1 280 px and across a viewport height change and a rotation at phone width.
|
||||
18. [gated 2026-11-12] Safe links: DOI and URL rendered as links only when http(s) / a valid `10.x/…` DOI; `javascript:` never a link; dangling citation ids shown as « Référence introuvable » with « Retirer »; duplicate ids stay distinct.
|
||||
19. [gated 2026-11-12] Data controls: every shell run goes through the preflight (editor-equine never listed) and the full-row guard (every column of every row of public, audit, storage tables and auth.users); no pre-existing row changed or deleted, metadata included; new rows counted per table and reported.
|
||||
20. [gated 2026-11-12] No change outside scope since 49867ba.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && [ -z "$(git diff --name-only 49867ba..HEAD -- supabase crates docker packages/supabase/src scripts)" ] && echo SCOPE_OK
|
||||
EXPECT: SCOPE_OK
|
||||
EVIDENCE: pending
|
||||
|
||||
## FILE SCOPE
|
||||
apps/app/src/editor/{tabs,navigation,focusRequest,useEditorNavigation,verification,editingContext}.ts, apps/app/src/editor/annotations/deselect.ts, apps/app/src/editor/references/** (new sort.ts), apps/app/src/components/editor/{EditorWorkspace,EditorTabBody,EditorTabs,DraftHeader,HeaderActions,KeptPlace}.tsx, apps/app/src/components/editor/references/**, apps/app/src/components/editor/findings/{FindingsTab,FindingContent,FindingDetail}.tsx, apps/app/src/components/editor/tabs/** (new ReferencesTab), apps/app/src/i18n/{fr,en}.ts, apps/app/tests/unit/**, apps/app/e2e/{support,shell,ui}/**, docs/development/{V1-2-6_U1_CORRECTIONS,BROWSER_TESTS,V1-2-6_OWNER_TRIAL,RUST_ARCHITECTURE_REVIEW,V1-2-6_R2_LABELS}.md, docs/design/README.md, CLAUDE.md (tree), this contract, the plan, .claude/tasks/TODO.md, memory.
|
||||
Reference in new issue
Block a user