diff --git a/.claude/tasks/plans/2026-11-22-detail-views-graphic-crop.md b/.claude/tasks/plans/2026-11-22-detail-views-graphic-crop.md index 566a58b1..5f813c72 100644 --- a/.claude/tasks/plans/2026-11-22-detail-views-graphic-crop.md +++ b/.claude/tasks/plans/2026-11-22-detail-views-graphic-crop.md @@ -1,9 +1,10 @@ -# U2/U4 Detail Views Drawn on the Drawing: Implementation Plan (V1-2.6), rev 2 +# U2/U4 Detail Views Drawn on the Drawing: Implementation Plan (V1-2.6), rev 3 > **For agentic workers:** REQUIRED SUB-SKILL: Use subagent-driven-development to implement this plan task-by-task. > Steps use checkbox (`- [ ]`) syntax for tracking. -**Status:** rev 2 = rev 1 plus the three challenges of 2026-11-22 (correctness FATAL 5, robustness CONCERNS 7, +**Status:** rev 3 = rev 2 plus the fixes of its confirmation pass (correctness CONCERNS 4); rev 2 = rev 1 plus the +three challenges of 2026-11-22 (correctness FATAL 5, robustness CONCERNS 7, simplicity CONCERNS 1; what became of each finding is in « Challenge round », at the end). DRAFT for the owner's technical validation (owner, 2026-11-22: « Cette validation concerne le design. Elle n'autorise pas encore l'implémentation. Je validerai le plan technique avant le début du code. »). No product code @@ -318,7 +319,7 @@ named. | `crates/core/tests/oracles/proportions/*.json` | NEW, frozen after the owner's checkpoint. Draw logs of the new reference cases | 28 | | `apps/app/src/editor/accessCategory.ts` | NEW. `ACCESS_CATEGORY_ID`, `isAccessCategory`, `ordinaryCategories` | 13 | | `apps/app/src/editor/annotations/frameBox.ts` | NEW. Frame geometry: corners, default, resize by part, move, clamp, ratio label, handle visibility | 6 | -| `apps/app/src/editor/annotations/accessShape.ts` | NEW. Rectangle polygon, circle from a drag, defaults, grown access box | 10, 14 | +| `apps/app/src/editor/annotations/accessShape.ts` | NEW. Rectangle polygon, grown access box, circle from a drag, defaults | 14 | | `apps/app/src/editor/annotations/frameWork.ts` | NEW. Frame work mutations (create, recrop) on the work store | 7 | | `apps/app/src/editor/annotations/viewCreation.ts`, `recrop.ts` | NEW. Commands and accept of « Créer la vue » and of « Appliquer » | 10, 11 | | `apps/app/src/anatomy/annotationPick.ts` | NEW. D11 pick among the elements under the pointer | 17 | @@ -1019,8 +1020,10 @@ pub fn min_access_spans<'a>( - Then `pnpm --filter @faunosteo/core-wasm exec vitest run`. Fix any TS fixture that builds a `PreviewState` by adding `min_access_span: {}`. - [ ] **Step 5: Wasm measure**, recorded. Over 600 000 B → STOP (Global Constraints). -- [ ] **Step 6: Commit.** - - Files: `frame.rs`, `preview.rs`, the two tests, `packages/core-wasm/types/PreviewState.ts`, TS fixtures if touched. +- [ ] **Step 6: Document and commit.** + - `RUST.md` §12: `min_access_span` and its wasm figure. + - Files: `frame.rs`, `preview.rs`, the test, `packages/core-wasm/types/PreviewState.ts`, TS fixtures if touched, + `RUST.md`. - Message: `feat(anatomy): smallest access side per view in preview state`, wasm figure in the body. ## Part 2 · Document compatibility and the N-1 reader @@ -1065,8 +1068,9 @@ pub fn min_access_spans<'a>( - apply to the bundled reference document, through the core's `sheet.edit`, the insert of a detail view (`view_box` 625, 969, 220 × 660 on the main view) and of its access in `cat-access`; - build the archive snapshot and the PDF attachment of a report touching that sheet, the way the neighbouring case - does. The edited document has a new fingerprint: load it as a new bundle whose `sheet-ref` carries the - fingerprint the core computes (`document_fingerprint`), without the historical alias. Loading it under the + does. The edited document has a new fingerprint. Load it as a preview first (`PreviewSheet`) and read + `PreviewState.fingerprint` (`preview.rs:368`), the route TypeScript has to `document_fingerprint`. Then load it + as a new bundle whose `sheet-ref` carries that fingerprint, without the historical alias. Loading it under the bundled `sheet-ref` would be refused (`loaded.rs:191-210`); - assert the frozen N-1 scanner and `readArchiveDocument` and `assertSnapshot` accept it; - record in the test whether the lean snapshot carries `cat-access` (assert the observed fact, either way, with a @@ -1116,7 +1120,7 @@ pub fn min_access_spans<'a>( stays in the role list. - `V1-2-6_UX_COMPATIBILITY.md` §7: add « U2 with `cat-access`: revertible, documents stay plain v2 ». - `ANATOMICAL_SHEET_MODEL.md`: the reserved id and the refusal kind. - - `RUST.md` §12: `EditError::ReservedCategory`, `min_access_span`, and the wasm figures of Tasks 2 and 3. + - `RUST.md` §12: `EditError::ReservedCategory` and the wasm figure of Task 2. - [ ] **Step 4: Commit.** Message: `docs(docs): cat-access compatibility record and N-1 replay`. Put the replay output in the body. @@ -1551,7 +1555,9 @@ Behaviour: | `editor.annotations.frame.part.nw` … `part.w` | Coin haut gauche · Côté haut · Coin haut droit · Côté droit · Coin bas droit · Côté bas · Coin bas gauche · Côté gauche | Top-left corner · Top side · Top-right corner · Right side · Bottom-right corner · Bottom side · Bottom-left corner · Left side | - [ ] **Step 1: Failing tests:** - - idle commands on the main view and on a crop detail view; none on an own-drawing view's « Recadrer »; + - idle commands on the main view and on a detail view, with the handlers this task wires (« Nouvelle vue de détail »); + Task 11 tests « Recadrer la vue », and Task 21 tests « Vue parente »; + - « Nouvelle vue de détail » stays available on a sheet whose only category is `cat-access`; - the commands key changes between phases; - « Retracer » clears the box; - the « Format » chip follows the box; @@ -1566,8 +1572,6 @@ Board panels 04, 05, 11. Decisions D7, D13, D14, D18, D19. Arbitration A1. Owner **Files:** - Create: `apps/app/src/editor/annotations/viewCreation.ts` -- Create: `apps/app/src/editor/annotations/accessShape.ts` (only `rectanglePolygon` and `accessBox` here; Task 14 adds - the rest) - Create: `apps/app/src/components/editor/annotations/ViewCreationDialog.tsx` - Create: `apps/app/src/components/editor/annotations/CropPreviews.tsx` (« Fenêtre du bilan » and « Page du PDF ») - Modify: `apps/app/src/components/editor/tabs/AnnotationsTab.tsx` (mount the dialog beside `CreationDialog`) @@ -1580,7 +1584,8 @@ Board panels 04, 05, 11. Decisions D7, D13, D14, D18, D19. Arbitration A1. Owner - `ACCESS_CATEGORY_ID` (Task 13); - `toViewBox` and `clampInto` (Task 6); - `bandInsets` and `bandClip` (Task 22), for « Fenêtre du bilan »; - - `uiState.accessTarget` (Task 14), the preset for « Je le tracerai ensuite »; + - `uiState.accessTarget`, `rectanglePolygon` and `accessBox` (Task 14), the preset for « Je le tracerai ensuite » + and the generated access; - `PreviewState.min_access_span` (Task 3), or the A1 alternative below; - `commitBatch` (`editorEdit.ts:46-62`), `geometryAccept` (`issues.ts:169`), `newElementId`. - Produces: @@ -1591,7 +1596,7 @@ Board panels 04, 05, 11. Decisions D7, D13, D14, D18, D19. Arbitration A1. Owner export function newViewCommands(form: NewViewForm, place: NewViewPlace, ids: { view: string; access: string }): EditCommand[] export function frameKnown(viewId: string): (state: PreviewState) => boolean ``` - `accessShape.ts` gains `rectanglePolygon(box)` and `accessBox(frame, minSpan, bounds): { box: Frame; grown: boolean }`. + It consumes `rectanglePolygon` and `accessBox` from `accessShape.ts` (Task 14). - [ ] **Step 1: Failing pure tests** (`annotations.viewCreation.test.ts`): - `newViewCommands` with `access: 'frame'` gives exactly two commands: @@ -1605,42 +1610,9 @@ Board panels 04, 05, 11. Decisions D7, D13, D14, D18, D19. Arbitration A1. Owner } ``` - With `'later'` and `'none'`, only the view insert. - - `accessBox` grows a 10 × 10 frame to a 29 × 29 square around the same centre when `minSpan` is 29, keeps it inside - the bounds near an edge, reports `grown`, and leaves a large frame unchanged (`grown: false`). - - `rectanglePolygon` returns four vertices clockwise from the top-left, rounded inward to 0.01. - `frameKnown` refuses a state whose report holds `view.frame.unknown` at the new view's path, and accepts otherwise. -- [ ] **Step 2: Implement `viewCreation.ts` and the two `accessShape.ts` functions.** +- [ ] **Step 2: Implement `viewCreation.ts`.** -```ts -// accessShape.ts (this task's part) -import type { Polygon } from '@faunosteo/core-wasm/types' - -import type { Frame } from './frame' -import { ceil2, floor2, round2 } from './frame' -import { clampInto } from './frameBox' - -/** D5, D9: a rectangle access, stored as a polygon of four vertices clockwise from the - * top-left, so it reshapes by its vertices like a zone; rounded inward to 0.01, so an access - * held against the parent's edge stays inside it. */ -export function rectanglePolygon(box: Frame): Polygon { - const l = ceil2(box.x) - const t = ceil2(box.y) - const r = floor2(box.x + box.w) - const b = floor2(box.y + box.h) - return { type: 'polygon', points: [[l, t], [r, t], [r, b], [l, b]] } -} - -/** A1: the generated access, the frame's rectangle grown around its centre to `minSpan` on - * each side when needed (the core's smallest readable access on the parent), kept in `bounds`. */ -export function accessBox(frame: Frame, minSpan: number | null, bounds: Frame): { box: Frame; grown: boolean } { - const span = minSpan ?? 0 - const w = Math.max(frame.w, span) - const h = Math.max(frame.h, span) - const grown = w > frame.w || h > frame.h - const box = clampInto({ x: frame.x + (frame.w - w) / 2, y: frame.y + (frame.h - h) / 2, w, h }, bounds) - return { box, grown } -} -``` ```ts // viewCreation.ts @@ -1803,14 +1775,18 @@ Board panel 10. Decision D16. - Produces: ```ts export function startRecrop(viewId: string): boolean // only for a crop view (svg_asset_id null, view_box set) - export function accessFollows(doc: AnatomicalSheetDocument, viewId: string): DetailTriggerAnnotation | null - export function recropCommands(view: DetailView, box: Frame, follower: DetailTriggerAnnotation | null): EditCommand[] + /** Where the parent's accesses live: the core's smallest access side there (null under A1's alternative) and the + * parent's frame (the drawing's `viewBox` for the main view, whose `view_box` is null). */ + export interface AccessPlace { minSpan: number | null; parentBounds: Frame } + export function accessFollows(doc: AnatomicalSheetDocument, viewId: string, place: AccessPlace): DetailTriggerAnnotation | null + export function recropCommands(view: DetailView, box: Frame, follower: DetailTriggerAnnotation | null, place: AccessPlace): EditCommand[] ``` `accessFollows` returns the one access on the parent opening the view whose polygon equals `rectanglePolygon(accessBox(oldBox, minSpan, parentBounds).box)`, within 0.01 per coordinate: the shape the view's creation gave it, grown or not (A1). Otherwise it returns null. `recropCommands` writes the follower as `rectanglePolygon(accessBox(newBox, minSpan, parentBounds).box)`, so a smaller recrop keeps a readable access. - `minSpan` is `previewState.min_access_span[parentId] ?? null`; it is null under A1's alternative. + The page builds `place` from `previewState.min_access_span[parentId] ?? null` and the parent's frame (`parseFrame` of + the parent canvas's root `viewBox`). The pure tests pass it explicitly. Behaviour: @@ -1840,6 +1816,7 @@ Behaviour: | `editor.views.recropped` | Vue « {name} » recadrée | View “{name}” recropped | - [ ] **Step 1: Failing tests.** + - The strip: « Recadrer la vue » shows on an idle crop detail view, not on an own-drawing view. - Pure: - `recropCommands` gives one view update, plus one access update to the grown rectangle of the new box when a follower is given; @@ -1963,7 +1940,8 @@ export function ordinaryCategories(categories: readonl - **N-1 point.** The point's properties dialog shows « Accès aux vues détaillées » as its current category and lets the person move it to « Articulations ». The update is accepted by the core. - **Category no longer required.** A sheet whose only category is `cat-access` blocks Point and Zone with the - no-category reason, and leaves Access and « Nouvelle vue de détail » available. + no-category reason, and leaves the access tool available. Task 9 checks « Nouvelle vue de détail » on the same + sheet. - **Head access.** Its properties dialog keeps the category select with the ordinary categories (D22). - [ ] **Step 2: Implement until they pass.** Run `editor-overview.test.tsx`, `editor-creation-dialog.test.tsx` and `annotations.missingFields.test.ts`, then `pnpm typecheck`. @@ -1979,7 +1957,8 @@ export function ordinaryCategories(categories: readonl Board panel 07. Decisions D5, D23. **Files:** -- Modify: `apps/app/src/editor/annotations/accessShape.ts` (add `circleFromDrag`, `defaultCircle`, `circleInside`) +- Create: `apps/app/src/editor/annotations/accessShape.ts`: `rectanglePolygon`, `accessBox` (used by Tasks 10 and 11), + `circleFromDrag`, `defaultCircle`, `circleInside` - Modify: - `apps/app/src/editor/annotations/uiState.ts`: `accessShape: 'rectangle' | 'polygon' | 'circle'`, default `'rectangle'`, kept when the `'view'` action resets the rest (the last choice lasts the session); also @@ -1998,10 +1977,38 @@ Board panel 07. Decisions D5, D23. `editor-creation-dialog.test.tsx` ```ts -// accessShape.ts, added by this task -import type { Circle } from '@faunosteo/core-wasm/types' -import type { XY } from './frame' +// accessShape.ts +import type { Circle, Polygon } from '@faunosteo/core-wasm/types' +import type { Frame, XY } from './frame' +import { ceil2, floor2, round2 } from './frame' +import { clampInto } from './frameBox' + +/** D5, D9: a rectangle access, stored as a polygon of four vertices clockwise from the + * top-left, so it reshapes by its vertices like a zone; rounded inward to 0.01, so an access + * held against the parent's edge stays inside it. */ +export function rectanglePolygon(box: Frame): Polygon { + const l = ceil2(box.x) + const t = ceil2(box.y) + const r = floor2(box.x + box.w) + const b = floor2(box.y + box.h) + return { type: 'polygon', points: [[l, t], [r, t], [r, b], [l, b]] } +} + +/** A1: the generated access, the frame's rectangle grown around its centre to `minSpan` on + * each side when needed (the core's smallest readable access on the parent), kept in `bounds`. */ +export function accessBox(frame: Frame, minSpan: number | null, bounds: Frame): { box: Frame; grown: boolean } { + const span = minSpan ?? 0 + const w = Math.max(frame.w, span) + const h = Math.max(frame.h, span) + const grown = w > frame.w || h > frame.h + const box = clampInto({ x: frame.x + (frame.w - w) / 2, y: frame.y + (frame.h - h) / 2, w, h }, bounds) + return { box, grown } +} +``` + +```ts +// accessShape.ts, continued /** D5: a circle dragged from its centre to its edge, kept inside `bounds`; a radius under * `minR` counts as a click: `fallback()`. */ export function circleFromDrag(centre: XY, edge: XY, minR: number, bounds: Frame, fallback: () => Circle): Circle { @@ -2052,6 +2059,9 @@ Behaviour: | `editor.annotations.no_child_view` | Créez d'abord une vue de détail. | Create a detail view first. | - [ ] **Step 1: Failing tests:** + - `accessBox` grows a 10 × 10 frame to a 29 × 29 square around the same centre when `minSpan` is 29, keeps it inside + the bounds near an edge, reports `grown`, and leaves a large frame unchanged (`grown: false`); + - `rectanglePolygon` returns four vertices clockwise from the top-left, rounded inward to 0.01; - pure tests of the three circle functions (minimum radius, clamping at an edge, rounding); - the shape choice keeps across a view change and defaults to Rectangle; - a rectangle drag opens the access dialog with a four-vertex polygon pending; @@ -2112,15 +2122,16 @@ Board panels 05, 06. Decisions D14, D16. Arbitration A2. Behaviour: -1. **Commands** of a selected access (A2, recommended): - - « Ouvrir la vue » (primary), wired by Task 21; +1. **Commands** of a selected access (A2, recommended). `AccessCommands` takes its handlers as props, and a button + without its handler is not rendered: + - « Ouvrir la vue » (primary), its handler passed by Task 21; - « Recadrer la vue » (Task 11, shown only when the opened view is a crop view); - « Déplacer l'accès » (the existing move mode, A11: arrows, « Valider la position », « Annuler »); - « Propriétés ». - « Supprimer » stays in the properties dialog. If the owner picks panel 05 exactly, « Déplacer l'accès » is replaced by « Supprimer » (the `DeleteDialog` path). -2. **Clicks.** A second click on the selected access, or a double click, opens the view (D14). On a point or a zone, it - still opens the properties dialog. +2. **Clicks.** Task 21 makes a second click on the selected access, or a double click, open the view (D14). Until + then, and always on a point or a zone, it opens the properties dialog. 3. **Vertices.** A chosen vertex of a polygon access shows the vertex commands, as for a zone (« Déplacer le sommet », « + », « − » on the drawing). @@ -2129,8 +2140,8 @@ Behaviour: | `editor.annotations.view.open` | Ouvrir la vue | Open the view | | `editor.annotations.move.access` | Déplacer l'accès | Move the access | -- [ ] **Step 1: Failing tests** for points 1 to 3. The selected head access, a polygon in Articulations, gets the same - commands. +- [ ] **Step 1: Failing tests** for points 1 and 3, without « Ouvrir la vue » (Task 21 tests it). The selected head + access, a polygon in Articulations, gets the same commands. - [ ] **Step 2: Implement.** Run the new test, `editor-zone-edit.test.tsx` and `editor-annotation-dialog.test.tsx`, then `pnpm typecheck`. - [ ] **Step 3: Commit.** Message: `feat(editor): selected access commands and opening on a second click`. @@ -2720,6 +2731,8 @@ Behaviour: - [ ] **Step 1: Failing tests:** - « Vue parente » goes to the parent, and on a nested view to its own parent; - « Ouvrir la vue » goes to the view the access opens; + - a second click, or a double click, on a selected access opens its view; on a point or a zone it still opens the + properties dialog; - both ask « Abandonner … ? » while work is started; - Back does not change the view. - [ ] **Step 2: Implement.** Run the two files, `editor-view-row.test.tsx` and `annotations.viewRow.test.ts`, then @@ -2795,10 +2808,11 @@ Behaviour: - `bandInsets({w:400,h:300},{w:7,h:1})` gives top and bottom (300 − 400/7)/2 and left and right 0; - `bandInsets({w:400,h:300},{w:1,h:3})` gives left and right (400 − 100)/2; - empty sizes give zeros; - - `AnatomyCanvas` on the head view sets a clip and the band background, and on the main view sets neither; + - `AnatomyCanvas` on the head view shows the band background, and the clip if the probe required it (the test + follows the branch the probe chose); on the main view it sets neither; - switching the shown view between two detail views of different ratios, then back to the main view, gives each - view its own clip and none on the main view. This is tested on the bilan's window (push and pop) and on a catalogue - tab switch. + view its own clip and none on the main view. This is tested on a catalogue tab switch and an editor chip switch. + Task 23 adds the same check on the bilan's window, push and pop. - [ ] **Step 2: Implement** after the probe. Run the unit files, then `pnpm typecheck`. - [ ] **Step 3: Commit.** Message: `feat(anatomy): detail views shown whole between neutral bands`. @@ -2831,7 +2845,8 @@ Behaviour: - [ ] **Step 1: Failing tests:** - open from the page, then a nested trigger: the title changes and « ← Tête (vue latérale gauche) » shows; - back returns to « Tête » and hides the button; - - Escape closes everything, and a new opening starts at one view. + - Escape closes everything, and a new opening starts at one view; + - each view pushed or popped in the window gets its own band clip (Task 22), none left over from the previous one. - [ ] **Step 2: Implement.** Run the files, then `pnpm typecheck`. - [ ] **Step 3: Commit.** Message: `feat(app): back to the parent view in the bilan detail window`. @@ -2935,8 +2950,9 @@ pub fn census(page: &PageLog) -> Vec { with the same `export_input` and `stub_rasters`, through `layout`. - It asserts `census(page)` is empty for every page. - It prints, per run, the lowest text baseline under `BODY_TOP` on observation pages. - - In `pdf_serialize.rs`, the same census on the two runs with real browser rasters, `real_run` and `store_path_run` - (`:122-170`), which the R4 digests pin. + - In `pdf_serialize.rs`, the same census on the two runs the R4 digests pin: `real_run`, with real browser rasters, + and `store_path_run`, with stub rasters (`:122-170`). They return bytes only, so extract their input and raster + builders into helpers shared by those runs and the new test, without changing what the runs produce. - [ ] **Step 3: Run:** `cargo test -p faunosteo-core --features pdf-write --test pdf_layout --test pdf_serialize r2_ -- --nocapture`. - Expected: pass, and every printed baseline is at least 76 (Task 26's text floor). The correctness challenge read the twelve logs: the lowest is at least 195. @@ -3099,9 +3115,10 @@ thing: an image taller than the budget is reduced as a whole instead of squashed width 261.64, height 261.64, top at 687.89 − 14. Two images draw at x 36 and 305.64, width 253.64. - **A capped image keeps its proportions, alone** (R2). A 1200 × 943 image beside an 800 × 2400 one (1:3), with a text need that leaves a 300 pt budget: - - the first keeps 253.64 × 199.33 at x 36; + - the first keeps 253.64 × (253.64 × 943 / 1200), about 199.32, at x 36; - the second is 100 × 300, width / height = 1 / 3 within 1e-9, centred in its cell (x = 305.64 + (253.64 − 100) / - 2), and its label moves with it. + 2), and its label stays at the cell's left edge (x 305.64), as today, so a long view name never runs past the + margin. - **Full width from 3:1, decided on the view's frame.** A view whose `view_box` is 300 × 100 takes a full-width row (width 523.28, height 174.43); one of 299 × 100 does not. A view without `view_box` decides on its raster's pixels. - **A4 order.** @@ -3218,8 +3235,9 @@ fn fitted(cell_w: f64, aspect: f64, budget: f64) -> (f64, f64) { } } -/// One row: the labels, then each image fitted in its cell and centred in it; returns the row -/// height. An image under the budget is drawn as before 2026-11-22, to the last bit. +/// One row: the labels at their cells' left edge, as before, then each image fitted in its cell +/// and centred in it; returns the row height. An image under the budget is drawn as before +/// 2026-11-22, to the last bit. fn draw_row(log: &mut DrawLog, page: usize, row: &Row<'_>, budget: f64, top_y: f64) -> f64 { let sizes: Vec<(f64, f64)> = row .items @@ -3227,10 +3245,10 @@ fn draw_row(log: &mut DrawLog, page: usize, row: &Row<'_>, budget: f64, top_y: f .map(|it| fitted(row.cell_w, it.aspect, budget)) .collect(); let x_of = |c: usize, width: f64| row.cell_x(c) + (row.cell_w - width) / 2.0; - for (c, (it, (width, _))) in row.items.iter().zip(&sizes).enumerate() { + for (c, it) in row.items.iter().enumerate() { log.text(page, TextOp { text: safe_text(&it.label), - x: x_of(c, *width), + x: row.cell_x(c), y: top_y, size: 8.0, font: BODY_BOLD, @@ -3312,7 +3330,8 @@ fn draw_images( - [ ] **Step 1: The case builder**, shared with Task 28. `proportions_input(case: &Case) -> (CheckedInput, Rasters)` in `pdf_proportions.rs`: - - **Sheet.** Read the equine draft as `draft_sheet()` does (`pdf_budget.rs:28-50`), then edit its document JSON: + - **Sheet.** Read the equine draft as `draft_sheet()` does (`pdf_budget.rs:28-50`), then add to its document, + through `apply_edit` inserts, so the core appends `cat-access` itself (Task 2): - add the case's crop views of the main view, each with: - its access in `cat-access` on the main view (the frame's rectangle; its laterality is that of the case's points); @@ -3340,9 +3359,10 @@ fn draw_images( repeated. 2. **The same comment with main and head.** The images keep the page's whole budget, the text continues on the next page, and the census passes. - 3. **A zones section of 120 points in one view.** The segmented line crosses a page; its items and separators are in - order, and no separator lands under the floor. - 4. **Short note, main beside a 1:6, a 1:10, then a 1:100 view.** The main view keeps 253.64 × 199.33. The tall view + 3. **A zones section of 120 points in one view.** The segmented line crosses a page, its items and separators are in + order, and the census is clean on every page (a bullet sits 1.2 pt under its line's baseline, inside the census + clearance). + 4. **Short note, main beside a 1:6, a 1:10, then a 1:100 view.** The main view keeps 253.64 × (253.64 × 943 / 1200), about 199.32. The tall view is capped at the budget with its own proportions, and centred in its cell. 5. **Mixed views with 5 000 characters:** - four views (main, head, 1:3, 7:1); @@ -3353,6 +3373,8 @@ fn draw_images( what the page leaves (the documented exception to the floor), every image keeps its ratio, and the census passes. 7. **Footers.** The footer numbering counts the continuation pages (`page / total` texts), and the conclusion page comes last. + 8. **A long view name** (« VUE DÉTAIL — TÊTE (VUE LATÉRALE GAUCHE) ») on a capped view in the right column. Its label + starts at the cell's left edge and stays inside the page (census). - [ ] **Step 3: Implement.** ```rust @@ -3537,8 +3559,8 @@ Owner R4: « Les nouvelles références PDF devront m'être présentées visuell - Modify: `docs/PDF-FORMAT.md` (`:16`, `:34-37`), `docs/development/RUST.md` §10 (`:1500-1503`, `:1626`, `:1724`) The five cases come from Task 27's `proportions_input`: the equine draft with the board's frames as crop views, each -with its access in `cat-access` on the main view and points inside it, under a fingerprint the core computed. The -renders therefore show the accesses on the main view, as the bilan's PDF does. +with its access in `cat-access` on the main view and points inside it, under a fingerprint the core computed. Accesses +never appear in a PDF raster: `compose_highlight` keeps only the observation's zones. | Case | Views | Comment | |---|---|---| @@ -3551,7 +3573,9 @@ renders therefore show the accesses on the main view, as the bilan's PDF does. - [ ] **Step 1: The reference test.** - For each case: layout, `census` on every page, then the draw log against `oracles/proportions/draw..json` at full precision (the `op_json` form of `pdf_layout.rs:103-120`). - - While the files are absent, the test fails with « reference not yet approved: ». + - Until the owner's go, the comparison test is `#[ignore = "reference not yet approved by the owner"]`, so + `pnpm rust:check` stays green and Task 3's type export runs. The census part of each case is a separate test that + is never ignored. - With `MAKE_PROPORTION_ORACLES=1`, it writes them instead (pattern `MAKE_R4_ORACLES`). That variable is set once, after the owner's go, and never again. - [ ] **Step 2: Renders for the owner, with real drawings.** @@ -3573,7 +3597,7 @@ renders therefore show the accesses on the main view, as the bilan's PDF does. Ask for the go to freeze. Tasks 10 to 23 continue meanwhile; this step does not block them. On a requested change, fix the layout, rerun Tasks 26 and 27's tests, and present again. - [ ] **Step 4: After the go.** - - Run once with `MAKE_PROPORTION_ORACLES=1`, then without: pass. + - Remove the `#[ignore]`. Run once with `MAKE_PROPORTION_ORACLES=1`, then without: pass. - Copy the approved PNGs into `docs/design/v1-2-6-u2-detail-views/pdf/`. - Update `PDF-FORMAT.md`: - « One page per observation; a text that does not fit continues on the next page, which repeats the header and @@ -3810,3 +3834,22 @@ Correctness FATAL(5), robustness CONCERNS(7), simplicity CONCERNS(1). Each findi No finding was dropped. The plan changed materially, so one confirmation challenger reads rev 2 before the owner's gate. +### Confirmation pass on rev 2 (correctness, CONCERNS 4) + +The owner allowed the usual plan reviews and the correction of what they find, with autonomy on technical details +(2026-11-22). These mechanical findings were fixed in rev 3 without a further challenge round: + +| # | Finding | Rev 3 | +|---|---|---| +| 1 MAJOR | Tasks 14 and 10 depend on each other | `accessShape.ts` (`rectanglePolygon`, `accessBox`, circles) is created by Task 14; Task 10 consumes it | +| 2 MAJOR | `accessFollows` and `recropCommands` lack `minSpan` and the parent's frame | An `AccessPlace` argument, fed from `previewState` and the parent canvas's `viewBox` | +| 3 MAJOR | Task 28's pending reference test turns `rust:check` red before Task 3 | The comparison is `#[ignore]` until the owner's go; the census part always runs | +| 4 MAJOR | Tests written before the code they exercise | The window push and pop move to Task 23, the second click to Task 21, « Nouvelle vue de détail » to Task 9, « Recadrer la vue » to Task 11, Task 3's RUST.md row to Task 3; Task 22's bilan clip test follows its probe | +| 5 | 199.33 instead of 199.32 | Exact expression `253.64 × 943 / 1200` | +| 6 | The case builder never adds `cat-access` | Views, points and accesses added through `apply_edit` | +| 7 | « The renders show the accesses » is false | Removed; `compose_highlight` keeps only the zones | +| 8 | « No separator under the floor » cannot hold | The assertion is the clean census | +| 9 | No TypeScript call returns `document_fingerprint` | `PreviewState.fingerprint` through a preview load | +| 10 | `real_run` and `store_path_run` return bytes only | Their input and raster builders are extracted and shared | +| 11 | A label centred on a capped image can run past the margin | Labels stay at the cell's left edge, as today; a long-name case | +