fix(editor): honest stopped state when the draft is unsaved; no dead retry
0279953 chose the stopped message from CoreRuntime.stopped alone: it
promised the report was kept even when the tab's storage refused the
draft (export, the banner's advice, needs the core), four surfaces still
offered a retry that could not work, and a failed recovery below the cap
was a dead end since nothing called retry().
The runtime restarts a failed recovery on the next call (compiled module
reused, cap still counts traps) and notifies status listeners. One
CoreStoppedNotice on the editor, Home, New report and the full-page
notice: reload when saved, else core.stopped_unsaved with a core-free
copy download (also on the storage-full banner) and a beforeunload
guard. Export, import and new report say the stopped message; a core
failure reading an unread draft is FAILED, not held. ESLint census of
the failure keys; core.stopped says "plusieurs erreurs".
This commit is contained in:
1 parent
0279953e9e
commit
6371523f8c
24 files changed
+839
-83
No files matched your search
@@ -1,16 +1,17 @@
|
||||
import { beforeAll, describe, expect, it, vi, afterEach } from 'vitest'
|
||||
import { cleanup, render, screen, waitFor } from '@testing-library/react'
|
||||
import { act, cleanup, render, screen, waitFor } from '@testing-library/react'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import AnatomyCanvas from '@/components/canvas/AnatomyCanvas'
|
||||
import type { CoreRuntime } from '@faunosteo/core-wasm'
|
||||
import { coreRuntime, setCoreRuntime } from '@/core/runtime'
|
||||
import { coreRuntime } from '@/core/runtime'
|
||||
import { coreFailureMessage } from '@/core/failure'
|
||||
import { useReportStore } from '@/state/reportStore'
|
||||
import { buildViewSvg } from '@/anatomy/drawing'
|
||||
import type { SheetIndex } from '@/services/sheetIndex'
|
||||
import { useLocaleStore } from '@/state/localeStore'
|
||||
import { fr } from '@/i18n/fr'
|
||||
import { en } from '@/i18n/en'
|
||||
import { bundledSheet, loadTestSheet, sheetFromBundle } from '../helpers/sheet'
|
||||
import { controlStopped } from '../helpers/core'
|
||||
import { bundledSheet, loadTestSheet, minimalReport, sheetFromBundle } from '../helpers/sheet'
|
||||
|
||||
let sheet: SheetIndex
|
||||
beforeAll(async () => {
|
||||
@@ -141,15 +142,18 @@ describe('AnatomyCanvas', () => {
|
||||
await screen.findByText(fr['sheet.core_unavailable']!)
|
||||
expect(screen.queryByText(fr['canvas.view_unavailable']!)).toBeNull()
|
||||
engineDown = false
|
||||
const retry = vi.spyOn(coreRuntime(), 'retry')
|
||||
await user.click(screen.getByRole('button', { name: fr['sheet.core_retry'] }))
|
||||
// The engine is restarted first, then the view is built again.
|
||||
expect(retry).toHaveBeenCalledTimes(1)
|
||||
await waitFor(() => expect(container.querySelector('[data-anno-id="hip"]')).not.toBeNull())
|
||||
expect(screen.queryByText(fr['sheet.core_unavailable']!)).toBeNull()
|
||||
retry.mockRestore()
|
||||
})
|
||||
|
||||
it('after the recoveries are spent, shows the final state with no retry; alerts say the same', async () => {
|
||||
useLocaleStore.setState({ locale: 'fr' })
|
||||
const live = coreRuntime()
|
||||
setCoreRuntime({ stopped: true } as unknown as CoreRuntime)
|
||||
const setStopped = controlStopped(coreRuntime(), true)
|
||||
try {
|
||||
const down = Object.create(sheet) as SheetIndex
|
||||
down.canvasSvg = () => ({ ok: false, kind: 'internal' })
|
||||
@@ -158,9 +162,42 @@ describe('AnatomyCanvas', () => {
|
||||
expect(screen.queryByRole('button', { name: fr['sheet.core_retry'] })).toBeNull()
|
||||
expect(coreFailureMessage((k: string) => fr[k]!)).toBe(fr['core.stopped'])
|
||||
} finally {
|
||||
setCoreRuntime(live)
|
||||
setStopped(false)
|
||||
}
|
||||
expect(coreFailureMessage((k: string) => fr[k]!)).toBe(fr['core.action_failed'])
|
||||
expect(coreFailureMessage((k: string) => fr[k]!, 'editor.export_failed')).toBe(
|
||||
fr['editor.export_failed'],
|
||||
)
|
||||
})
|
||||
|
||||
it('switches a shown engine failure to the stopped text when the engine stops, per save state', async () => {
|
||||
useLocaleStore.setState({ locale: 'fr' })
|
||||
const setStopped = controlStopped(coreRuntime(), false)
|
||||
try {
|
||||
const down = Object.create(sheet) as SheetIndex
|
||||
down.canvasSvg = () => ({ ok: false, kind: 'core_unavailable' })
|
||||
render(<AnatomyCanvas index={down} viewId="main" states={new Map()} onZoneClick={() => undefined} />)
|
||||
await screen.findByText(fr['sheet.core_unavailable']!)
|
||||
expect(screen.getByRole('button', { name: fr['sheet.core_retry'] })).toBeInTheDocument()
|
||||
act(() => setStopped(true))
|
||||
await screen.findByText(fr['core.stopped']!)
|
||||
expect(screen.queryByRole('button', { name: fr['sheet.core_retry'] })).toBeNull()
|
||||
// The draft mirror hits a full storage: the report only lives in memory.
|
||||
vi.spyOn(sessionStorage, 'setItem').mockImplementation(() => {
|
||||
throw new DOMException('full', 'QuotaExceededError')
|
||||
})
|
||||
act(() => useReportStore.setState({ report: minimalReport(sheet) }))
|
||||
expect(useReportStore.getState().saveFailed).toBe(true)
|
||||
await screen.findByText(fr['core.stopped_unsaved']!)
|
||||
expect(screen.queryByRole('button', { name: fr['sheet.core_retry'] })).toBeNull()
|
||||
expect(
|
||||
coreFailureMessage((k: string) => fr[k]!, 'editor.export_failed'),
|
||||
).toBe(fr['core.stopped_unsaved'])
|
||||
} finally {
|
||||
setStopped(false)
|
||||
vi.restoreAllMocks()
|
||||
useReportStore.setState({ report: null, saveFailed: false })
|
||||
}
|
||||
})
|
||||
|
||||
it('words both failures in English too', async () => {
|
||||
|
||||
Reference in new issue
Block a user