fix(app): crossing focus for any element in a hidden part

Focus held by any element that a crossing hides or unmounts (button, tool,
canvas, link) goes to the shown tab, decided by the element leaving the page,
not by tag; a field still commits first; visible focus stays.
History pair: remembered field must be connected, and a pointer-down off a
field keeps it. TextField.commit compares with the latest committed value.
Open-panel axe settles and checks dialogs like the other places.

R-24: no assertion rewritten or deleted; one Chromium case and three unit
tests added.
This commit is contained in:
bchanot committed 2026-11-08 20:43:27 +01:00
1 parent a474ddaa40
commit 606f7ba268
8 files changed
+81 -18

No files matched your search

+22 -4
View File
@@ -125,15 +125,33 @@ function activeTabButton(): HTMLElement | null {
)
}
/** Gives the focus to the shown tab's button: a field that lost the focus must not leave `body`. */
/** Gives the focus to the shown tab's button: a lost focus must not leave on `body`. */
export function focusActiveTab(): void {
activeTabButton()?.focus()
}
/** The element holding the focus, when it is something other than `body`. */
export function heldElement(): HTMLElement | null {
const active = document.activeElement
return active instanceof HTMLElement && active !== document.body
? active
: null
}
/**
* The editor turned read-only: commits the text being typed; the field that held the focus
* sits in a part that is now hidden, so the focus goes to the shown tab, never to `body`.
* After the render that hides parts: `held` (taken before) that left the page or sits in a
* hidden part hands its focus to the shown tab. An element still visible keeps its place.
*/
export function refocusIfHidden(held: HTMLElement | null): void {
if (held && (!held.isConnected || held.closest('[hidden]'))) focusActiveTab()
}
/**
* The editor turned read-only: commits the text being typed, then whatever held the focus
* in a now hidden part gives it to the shown tab, never to `body`.
*/
export function releaseEditFocus(): void {
if (commitFocusedField()) focusActiveTab()
const held = heldElement()
commitFocusedField()
refocusIfHidden(held)
}