chore(memory): V1-2.2 closure, mutations rerun on final code, BDR-092, LRN-108, V1-2.3 contract

This commit is contained in:
bchanot committed 2026-11-01 16:38:53 +01:00
1 parent 0edef2f66d
commit 5eca08688a
7 files changed
+123 -10

No files matched your search

+16 -2
View File
@@ -614,13 +614,27 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
- [x] N4 scale bypass: projected visible size rule (owner 2026-11-01: 4 px at 320 × 568, measured equine min 4.97 px), verdict + preview, closed code; numeric guard (finite, non-degenerate, value/transform bounds, f32 precision vs magnitude and frame), Rust vs browser edge cases
- [x] N5 gates: cargo all features, clippy, mutations, wasm size, check:all on final HEAD, e2e:ui, e2e:shell if sandbox, C8 Docker + mutations
- [ ] N6 fresh verifier + security on final HEAD (old MEDIUMs, f32/f64 residue); memory BDR + 2 LRN (dedup); checkpoint
- [ ] O last MEDIUM, zone without interior (brief « V1-2.2 : fermeture du dernier MEDIUM », 2026-11-01, on de2dfb3; contract `.claude/tasks/contracts/2026-11-01-v1-2-2-interior.md`)
- [x] O last MEDIUM, zone without interior (brief « V1-2.2 : fermeture du dernier MEDIUM », 2026-11-01, on de2dfb3; contract `.claude/tasks/contracts/2026-11-01-v1-2-2-interior.md`)
- [x] O1 measure: flattened outline (polygon, path curves/arcs with a chord deviation bound), fill rule (layer = nonzero), widest inscribed disc search (deterministic, capped), projected at 320 × 568
- [x] O2 rule in `frame::annotation_placement` after the bounds rule; closed codes; verdict + preview; docs (ANNOTATION-RENDERING, RUST.md, V1-2 §6.7)
- [x] O3 tests: back-and-forth, near-flat, self-intersection both rules, curves/arcs near zero, small legit, transforms/scales, threshold edges, equine; browser concordance fixture + spec on 3 engines
- [x] O4 gates: wasm ≤ 600 000, mutations, check:all, e2e:shell sandbox, ignored tests documented, PDF unchanged; fresh verifier + security
- [x] O5 memory: 3 LRN (WebKit snapping, Firefox client rects, WebKit tiny spans); LOW overlap recorded; checkpoint
- [ ] V1-2.3 drawings and worker verification (M6) · V1-2.4 wireframes (editor, review, admin entry) · V1-2.5 catalogue, admin space, rights, species, MFA · V1-2.6 editor level 1 · V1-2.7 preview, review, publication UI · V1-2.8 equine working copy and review preparation · V1-2.9 FR/EN acceptance and closure (owner checkpoints V1-2.3, V1-2.4, V1-2.6, V1-2.7, V1-2.8, V1-2.9 + each DEV operation of contract §16.11)
- [x] V1-2.2 CLOSED: VERIFIED by the owner 2026-11-01 (brief « Validation définitive V1-2.2 », code `c73415a`, BDR-092, contract §17.7); codes `interior_too_small` / `marker_interior_too_small` approved; LRN-108 (Chromium touch, observation only). Final verifier on the closed state: ECARTS(1) (three mutation anchors stale since 03be75b/86dce16) → re-anchored, script rerun on the final code (evidence « Closure »)
- [ ] V1-2.2 accepted LOWs, TRACKED, not fixed (owner 2026-11-01; never mark fixed without a fix and proof):
- [ ] fully overlapping marker discs: no rule; human review must find them before any publication (V1-2.7 review screen, V1-2.8 equine preparation)
- [ ] arc rotation sub-pixel error (bounded, tests kept)
- [ ] arc exactly tangent to a frame edge refused (conservative bounds)
- [ ] `f32` arc margin a bounded estimate (≤ 0.13 unit measured on a model)
- [ ] verification cost of an all-arc sheet (~1.8 s native): watch complex-sheet durations at the editor validations on real devices (V1-2.6) and the worker at-caps timing (V1-2.3)
- [ ] relative path commands accumulated in `f32` (contrived worst 6 % of the span)
- [ ] V1-2.3 worker verification (M6), owner go 2026-11-01 (brief « Validation définitive V1-2.2 »); contract `.claude/tasks/contracts/2026-11-01-v1-2-3-worker-verification.md`; sandbox only, DEV untouched, no merge, STOP at owner checkpoint (server workflow V1-2.1 to V1-2.3)
- [ ] P1 M6 SQL: claim / input / complete (structure check, failed verdict without groups) / fail, closed worker codes, attempt limit, audit; pgTAP allowed + denied; types; sandbox test-db
- [ ] P2 child `verify`: framed stdin input, core verdict, output cap, sandbox (rlimits, seccomp re-derived); spawner limits per command
- [ ] P3 `run --jobs sheet-verify`: backend RPCs + Storage downloads, failure classification §6.5, fake-backend tests per row; compose service under `worker` profile
- [ ] P4 sandbox e2e: pass, each failure, stale/malformed, avatars and purges unaffected, publication gate, working copy in place, at-caps timing; upgrade rehearsal; e2e:avatar unchanged
- [ ] P5 docs, gates (rust:check, worker:test, worker:image, check:all, e2e:shell), fresh verifier + security, memory, checkpoint
- [ ] V1-2.4 wireframes (editor, review, admin entry) · V1-2.5 catalogue, admin space, rights, species, MFA · V1-2.6 editor level 1 · V1-2.7 preview, review, publication UI · V1-2.8 equine working copy and review preparation · V1-2.9 FR/EN acceptance and closure (owner checkpoints V1-2.3, V1-2.4, V1-2.6, V1-2.7, V1-2.8, V1-2.9 + each DEV operation of contract §16.11)
## Release readiness track (owner 2026-10-25, distinct from the functional roadmap; nothing here authorises a release or exposure)
Inventory: `.claude/audits/2026-10-25-functional-inventory.md`. Each item: treat or qualify before any release or public exposure; not fixed now unless an active critical flaw is shown.
@@ -15,7 +15,7 @@ Owner brief « V1-2.2 : fermeture du dernier MEDIUM », 2026-11-01, on `de2dfb3`
radius away from every edge (implicit closing edges included); deterministic search, capped; over
the caps the annotation is refused (fail closed), never accepted.
- I3 Closed codes, the approved ones unchanged: issue `annotation.geometry.interior_too_small`,
verdict `verification.validation.marker_interior_too_small` (implementer's proposal, to confirm).
verdict `verification.validation.marker_interior_too_small` (implementer's proposal; approved by the owner 2026-11-01, brief « Validation définitive V1-2.2 »).
Verdict and preview agree. The document and the drawings never rewritten.
- I4 Tests: back-and-forth path, near-flat polygon, self-intersection under both rules, curves and
arcs of near-zero area, small legitimate filled shapes, drawing transforms and extreme scales,
@@ -0,0 +1,62 @@
# Contract: V1-2.3 worker verification (M6)
Owner brief « Validation définitive V1-2.2 », 2026-11-01 (V1-2.2 VERIFIED at `c73415a`, BDR-092):
start V1-2.3 along the validated plan, V1-2 contract §16.4 (objective, prerequisites, tests,
acceptance), §6.4 (server verdict), §6.5 (failures), §12.3 (M6). Branch
`feature/v1-2-anatomical-sheets`. Sandbox stack only; DEV and production untouched; no merge;
no V1-2.4; STOP at the owner checkpoint (server workflow V1-2.1 to V1-2.3).
## Criteria
- W1 M6 `sheet_verification_jobs`, forward-only, service role only (revoked from `public`,
`anon`, `authenticated`), `security definer`, `search_path = ''`:
`claim_sheet_verifications(limit)` (clamped, `for update skip locked`, rounds `verifying` with no
live lease, token + `locked_at` set, `attempts` incremented, an expired lease counted, the attempt
limit closing the round `verification_failed` / `unavailable`);
`get_sheet_verification_input(review_id, lease_token)` (the frozen document and the base as text,
the referenced drawing rows registered for the sheet: asset id, sha256, byte size, bucket, object
key; nothing for a stale token or status);
`complete_sheet_verification(review_id, lease_token, verdict)` (accepted only while `verifying`
with the live token; binding = the round's sheet, version, revision, review; a passed verdict's
group keys = `general`, the document's view and zone ids and the base's removed ones, its drawings
= the document's asset ids with the rows' sha256; a failed verdict accepted without groups or
drawings, its code from the closed list; else `stale` or `malformed`, nothing written; moves to
`open` or `verification_failed` / `failed`; audited);
`fail_sheet_verification(review_id, lease_token, code)` (closed worker codes; claimable again
below the limit, `verification_failed` / `unavailable` at it; audited).
pgTAP allowed and denied cases; `database.types.ts` regenerated; publication still refused
without an approved round whose passed verdict is current.
- W2 Child `verify`: the same binary, empty environment, rlimits and seccomp installed before
reading stdin; reads one framed input (binding, rows, document, base, drawing bytes) under the
per-command input cap; runs `faunosteo_core` `compute_verdict`; writes the verdict JSON under the
output cap. The parent never parses the document or the drawings. Seccomp allowlist derived again
for this path (Docker `test` stage).
- W3 Spawner per command: input cap, output cap, deadline and memory per command (`decode`
unchanged); `verify` sized on the at-caps fixture (about 13 MiB input).
- W4 Mode `run --jobs sheet-verify`: claim, input, Storage downloads (missing object = drawing
missing for the core, never a worker failure), child, completion; transient, timeout, resource and
crash outcomes reported by `fail_sheet_verification` with a closed code; a broken sandbox stops
the worker. Avatar and purge processing unchanged in the default mode; the verification mode runs
no sweep. RPC body cap of this mode raised to the verdict size.
- W5 Compose service of its own under the `worker` profile (read-only, `cap_drop: ALL`, same
hardening as `worker`); sandbox start of the verification worker; never started on DEV.
- W6 Tests: `pnpm worker:test` (sandbox, seccomp derivation), unit and fake-backend job tests for
each §6.5 row, hostile corpus through the child, e2e on the sandbox stack (clean sheet passes,
each failure and its exit, stale or malformed completion writes nothing, avatars and purges
unaffected, publication refused without a current passed verdict, the sandbox working copy
verified in place with its shared drawing, verification time at the caps within budget), upgrade
rehearsal from the DEV state (Git fixture of the DEV drawing, §12.3), `pnpm e2e:avatar` unchanged.
- W7 Docs describe only what is implemented: V1-2 contract §6.4, §6.5, §12.3, §16.4; STORAGE.md
worker section; RUST.md; SUPABASE.md; DEPLOY.md / compose notes; CLAUDE.md.
- W8 Gates: `pnpm rust:check`, `pnpm worker:test`, `pnpm worker:image`, sandbox `test-db` and
`types --check`, `pnpm check:all` on the final HEAD, `pnpm e2e:shell` on the sandbox; fresh
verifier and security reviews on the final HEAD.
## Proposals for the owner (checkpoint)
Closed worker failure codes, attempt limit (five), lease duration, the service name: chosen by the
implementer, listed at the checkpoint for confirmation.
## Out of scope
DEV and production (every §16.11 operation), screens, V1-2.4 onwards, merge, deploy.