From 5e0aa625a82c66826babf0eb198ade8561f33472 Mon Sep 17 00:00:00 2001 From: bchanot Date: Wed, 4 Nov 2026 20:50:16 +0100 Subject: [PATCH] fix(editor): submission note sent as typed, copies purged again after sign-out --- .../editor/verification/useSubmission.ts | 2 +- apps/app/src/components/shell/SignOutButton.tsx | 3 +++ .../tests/unit/components.SignOutButton.test.tsx | 16 ++++++++++++++++ apps/app/tests/unit/editor-verification.test.tsx | 4 ++-- 4 files changed, 22 insertions(+), 3 deletions(-) diff --git a/apps/app/src/components/editor/verification/useSubmission.ts b/apps/app/src/components/editor/verification/useSubmission.ts index cfc5f81a..2101b739 100644 --- a/apps/app/src/components/editor/verification/useSubmission.ts +++ b/apps/app/src/components/editor/verification/useSubmission.ts @@ -36,7 +36,7 @@ export function useSubmission(reloadSheet: () => void) { const submit = async () => { setMessage(null) - const outcome = await useEditorStore.getState().submit(note.trim()) + const outcome = await useEditorStore.getState().submit(note) // The round froze the draft: the route refreshes even if this tab is gone. if (outcome.ok) reloadSheet() if (!mounted.current) return diff --git a/apps/app/src/components/shell/SignOutButton.tsx b/apps/app/src/components/shell/SignOutButton.tsx index 8eb68cd5..ce757a56 100644 --- a/apps/app/src/components/shell/SignOutButton.tsx +++ b/apps/app/src/components/shell/SignOutButton.tsx @@ -36,12 +36,15 @@ export default function SignOutButton({ async function leave() { setBusy(true) + const leavingUser = userId try { await signOut() } catch { // The local session is cleared either way; the server may not have revoked the others. window.alert(t('shell.sign_out_failed')) } finally { + // An upload still in flight may have rewritten a copy before SIGNED_OUT landed. + if (leavingUser) removeUserCopies(leavingUser) // The guard would redirect anyway; going home keeps the local tool one step away. navigate('/', { replace: true }) } diff --git a/apps/app/tests/unit/components.SignOutButton.test.tsx b/apps/app/tests/unit/components.SignOutButton.test.tsx index c17728a2..948bdd7d 100644 --- a/apps/app/tests/unit/components.SignOutButton.test.tsx +++ b/apps/app/tests/unit/components.SignOutButton.test.tsx @@ -78,6 +78,22 @@ describe('SignOutButton', () => { expect(sessionStorage.getItem(copyKey(OTHER, 'v1'))).toBe('{}') }) + it('purges again when a copy is written while the sign-out is in flight', async () => { + sessionStorage.setItem(copyKey(user.id, 'v1'), '{}') + signOut.mockImplementationOnce(async () => { + sessionStorage.setItem(copyKey(user.id, 'v2'), '{}') + }) + mount() + await click() + await userEvent.click( + screen.getByRole('button', { name: fr['shell.sign_out_loss_confirm'] }), + ) + await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1)) + await waitFor(() => + expect(sessionStorage.getItem(copyKey(user.id, 'v2'))).toBeNull(), + ) + }) + it('ignores the copies of another account', async () => { sessionStorage.setItem(copyKey(OTHER, 'v1'), '{}') mount() diff --git a/apps/app/tests/unit/editor-verification.test.tsx b/apps/app/tests/unit/editor-verification.test.tsx index 7c2a2683..aca3e74c 100644 --- a/apps/app/tests/unit/editor-verification.test.tsx +++ b/apps/app/tests/unit/editor-verification.test.tsx @@ -145,7 +145,7 @@ describe('Submission', () => { ).toBeTruthy() }) - it('submits the trimmed note on the saved revision and reloads the sheet', async () => { + it('submits the note as typed on the saved revision and reloads the sheet', async () => { await openReady() sb.submitSheetReview.mockResolvedValue('review-1' as never) const user = userEvent.setup() @@ -159,7 +159,7 @@ describe('Submission', () => { expect(sb.submitSheetReview).toHaveBeenCalledWith(expect.anything(), { version_id: 'ver-1', expected_revision: 3, - note: 'PrĂȘte', + note: ' PrĂȘte ', }) })