diff --git a/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md b/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md index d66721ec..5a4f7b29 100644 --- a/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md +++ b/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md @@ -135,6 +135,17 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the animation frame up to 133 (equine) and 331 (synthetic). Budget 500 ms met. Expect timeout raised to 10 s (8 workers on one stack); `e2e/support/warm-up.ts` global setup absorbs Vite's first dependency reload. +- Final review (opus, 2571978..0764eb1): no Critical; I1 (undo shortcuts active in narrow read-only), I2 + (`downloadAndHold` store write without the session check), m1 (post-submit edit window), m2 (restore keeps raw + copy text, R15), m5 (staleBase with nothing unsaved is a dead end) taken in Lot M fix round 3. Kept for before + the V1-2 merge: m4 per-commit copy bookkeeping cost (each other copy parsed twice), m6 conflict dialog after a + `rights.*` refusal of « Garder ma version », m7 `issues.ts` `drawingAssetOf` mirrors the core's + `asset_id_of_view` (BDR-043: needs a core op, crates out of scope in V1-2.6), m8 React component locals + (DraftEditor 13, AdminSheetDraftRoute 10, DraftHeader ~11, `pendingForClick` 7), m10 M8 header comment + « Null when the draft has no draft » (migrations frozen in this step). Every ledger deferred minor triaged + « keep » except L trial.config / path / 4.3.1 (done). Second verifier pass: C19 marker wordings, C25 two header + copy strings, C22 final-HEAD check:all + security, floor waivers on the 375 px skips: fix round 3. + ## Questions for the owner at the checkpoint (not decided) - The 10 format-only uncommitted changes under `apps/app/src/editor/state/` (R12): revert (`git checkout -- apps/app/src/editor/state`) or keep. @@ -142,4 +153,8 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the - Trim leading/trailing spaces of typed values before sending (Lot F review: visible choice). - R6 mode precedence, R7 « Utiliser l'illustration de la vue parente », default tab Annotations (boards 04/05). +- m3: attaching a drawing to an unmeasured view that already holds annotations is refused as « newly invalid » + when they fall outside the new frame, and geometry on an unmeasured view is locked (C32): the only way out is + deleting those annotations. Keep the rule, or allow repair after attach? +- Findings: adding a category with a node selected lands at zone level without a hint (visible behaviour). - Every new label stays a proposal (`.claude/audits/2026-11-03-v1-2-6-label-proposals.md`).