From 5774d5214443c51c2ebca2936b1d8b8e563d8cc8 Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 16 Nov 2026 20:55:10 +0100 Subject: [PATCH] docs(docs): R3 phone filters review rounds and check:all recorded --- .claude/tasks/TODO.md | 1 + docs/development/V1-2-6_U1_CORRECTIONS.md | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 217bb1f6..1aee7796 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -724,6 +724,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - shortcut: `apps/app/src/admin/sheetList.ts` search and sort run in the browser on the whole loaded list. Limit: the whole list loaded in one unbounded read, then filtered and sorted in the browser at each keystroke. Upgrade path: they move to the server with the admin list paging, RR-13 (widened per D4) - shortcut: the search field in `AdminSheetsRoute.tsx` repeats `ReferenceToolbar`'s search markup (R2, closed). Limit: two copies of one field. Upgrade path: fold both onto one shared search component when the editor is next opened - [x] Owner trial 2026-11-16 db:trial: R3 behaviour validated; phone filters collapsible (`9efc7b7`, spec `6d2ba0d`, no new board), double announcement fixed (filters-only empty line no longer a status), contract criterion 4 oracle replaced by the layout-insensitive check (DATE_SOURCE_OK). Units at `6d2ba0d`: core-wasm 66, supabase 182, app 1749 in 137 files; spec admin-sheets-list alone 8 passed (4 tests x 2 projects). BLK-015 and admin.spec.ts failures unchanged, separate. + - [x] Phone filters review: 1 review + 2 fix rounds (`7a129dc`, `ca70178`, `a50796b`; closed panel height 0 asserted). `pnpm check:all` at `a50796b` exit 0: core-wasm 66, supabase 182, app 1750, e2e:ui 253; spec admin-sheets-list 8 passed. Sandbox R3 sheets: 60, all soft-deleted. - shortcut: the phone filters panel in `AdminSheetsRoute.tsx` is local to the sheet list. Limit: one page; the other admin lists have no filters panel. Upgrade path: lift it to a shared disclosure component when a second list needs one - [ ] Follow-up, NOT R3 (owner D5 2026-11-16): keep the admin sheet list's search, sort and filters when coming back from a sheet; joins the app-wide « search not kept on back » follow-up (BDR-079); BDR-116 rejected address parameters for view state; later navigation improvement, own go - [x] Anomaly B FIXED `2cdee42` (owner 2026-11-12 « Décision sur l'anomalie E2E », option 1): dialog checks moved to e2e:ui on the real WorkingCopyAction (`e2e/harness/working-copy.*`, `e2e/ui/working-copy.spec.ts`), shell keeps the historical page + state-consistent button check, sandbox suite archives only its own copies (`returning id` checked). Before 4 failed; after 4 passed ×2; full admin.spec 16 passed / 8 skipped; e2e:ui 251 ×2; sandbox sheets-admin 5/5; pre-existing anatomical_sheets rows identical per id (637 → 643, 6 added by A1). Verifier CONFORME, security PASS (1 LOW: optional uuid check before interpolation). Open: cleanup creation branch not run on a fresh stack; free branch of the shell check not run on this sandbox; `editor-equine.spec.ts` set-aside still archives and restores pre-existing copies (8c315a12 included, updated_at 2026-11-12 13:40 from the R1 follow-up run): owner decision. R2.0 waits for the owner's green light on this result diff --git a/docs/development/V1-2-6_U1_CORRECTIONS.md b/docs/development/V1-2-6_U1_CORRECTIONS.md index dca93dce..94dd7a43 100644 --- a/docs/development/V1-2-6_U1_CORRECTIONS.md +++ b/docs/development/V1-2-6_U1_CORRECTIONS.md @@ -756,6 +756,11 @@ day (`9efc7b7`, spec `6d2ba0d`), no new board: sentence for « no official sheet at all » stays a status: no count line shows then. - Verifier gap (criterion 4 of the contract): the one-line literal oracle was defective after `374e300` split the line; the contract now holds the layout-insensitive check, run: DATE_SOURCE_OK. Criterion 4 met. +- Review: one review and two scoped fix rounds (`7a129dc`, `ca70178`, `a50796b`): toggle label left and chevron + right, closed panel of height 0 (asserted at 375 px), one `activeFilterCount`, owner message verbatim in the + contract. `pnpm check:all` at `a50796b`: exit 0, units core-wasm 66, supabase 182, app 1750, e2e:ui 253 passed; + e2e:shell not run by check:all. Spec admin-sheets-list alone: 8 passed. BLK-015 and the `admin.spec.ts` + failures stay in their own tracking, untouched. Owner decisions left open (R3):