fix(app): safeNextPath refuses a next value that normalises into //host (/..//, /%2e%2e//); dot-segment, scheme, encoding and consumer tests

This commit is contained in:
bchanot committed 2026-10-21 18:15:08 +02:00
1 parent ff122d1924
commit 51a5a80192
3 files changed
+90 -8

No files matched your search

@@ -67,6 +67,65 @@ describe('safeNextPath', () => {
expect(safeNextPath('/ /evil.test')).toBe('/%20/evil.test')
expect(safeNextPath('/app/account?tab=x#s')).toBe('/app/account?tab=x#s')
})
// R4.12 (D3): the URL parser's own normalisation turns these into `//evil.test`.
it('refuses dot segments that normalise into a protocol-relative path', () => {
for (const raw of [
'/..//evil.test',
'/.//evil.test',
'/a/..//evil.test',
'/a/b/../..//evil.test',
'/..\\\\evil.test',
'/x/..\\/evil.test',
'/%2e%2e//evil.test',
'/%2E%2E//evil.test',
'/.%2e//evil.test',
'/a/%2e%2e//evil.test',
'/.\t.//evil.test',
'/..//evil.test/app?next=/app#x',
]) {
expect(safeNextPath(raw), raw).toBe('/app')
}
})
it('refuses external schemes and escapes in every spelling', () => {
for (const raw of [
'///evil.test',
'/\\/evil.test',
'\\\\evil.test',
'javascript:alert(1)',
'/javascript:alert(1)//',
'https:/evil.test',
'data:text/html,x',
'',
]) {
const result = safeNextPath(raw)
expect(result.startsWith('//'), raw).toBe(false)
expect(new URL(result, 'http://site.invalid').origin, raw).toBe('http://site.invalid')
}
expect(safeNextPath('///evil.test')).toBe('/app')
expect(safeNextPath('javascript:alert(1)')).toBe('/app')
})
it('keeps encoded slashes literal and legitimate internal paths unchanged', () => {
expect(safeNextPath('/%2F%2Fevil.test')).toBe('/%2F%2Fevil.test')
expect(safeNextPath('/%5C%5Cevil.test')).toBe('/%5C%5Cevil.test')
expect(safeNextPath('/app')).toBe('/app')
expect(safeNextPath('/editor')).toBe('/editor')
expect(safeNextPath('/app//account')).toBe('/app//account')
expect(safeNextPath('/app/../app/account')).toBe('/app/account')
expect(safeNextPath('/app/account?next=//evil.test')).toBe('/app/account?next=//evil.test')
expect(safeNextPath('/../app')).toBe('/app')
expect(safeNextPath('/..')).toBe('/')
expect(safeNextPath('/..//evil.test', '/fallback')).toBe('/fallback')
})
it('returns a value that is itself accepted unchanged (idempotent)', () => {
for (const raw of ['/app/account?tab=x#s', '/a/../b', '/%2e%2e/app', '/app//x']) {
const once = safeNextPath(raw)
expect(safeNextPath(once), raw).toBe(once)
}
})
})
describe('account validation', () => {