fix(anatomy): V1-2.2 marker layer and halo outside the drawing's group

Owner-approved lot B (brief 2026-11-01). The composition root is the
engine's (namespaces and frame); the drawing's root becomes a group and
the marker layer and halo are its siblings, so no root property reaches
a marker. Point hitboxes declare stroke none and visibleFill. Census over
the reader's whole allowlist; R3 references compared under the declared
transform; click proofs in three engines.
This commit is contained in:
bchanot committed 2026-11-01 00:39:57 +01:00
1 parent f1bb19b30b
commit 4f52f5e1c4
23 files changed
+933 -112

No files matched your search

+13 -3
View File
@@ -21,7 +21,9 @@ import {
import {
checkR3Golden,
treeOf,
withDeclaredHitboxes,
withIdsScopedPerView,
withIsolatedLayer,
withTriggerNamesPerLanguage,
type TreeNode,
} from '../helpers/svgTree'
@@ -82,9 +84,10 @@ describe.each(VIEWS)('the %s canvas', (viewId) => {
it('builds the frozen tree with no state', () => {
const build = buildViewSvg(sheet, viewId)
if (!build.ok) throw new Error(`canvas ${viewId}: ${build.failure}`)
// and the owner's decision 2026-10-29: the drawing's ids scoped to the view
// and the owner's decision 2026-10-29: the drawing's ids scoped to the view; the brief
// 2026-10-30: the composition root is the engine's, the hitboxes declared
checkR3Golden(`canvas.${viewId}.json`, treeOf(build.svg), (frozen) =>
withIdsScopedPerView(declared(frozen), viewId),
withIsolatedLayer(withIdsScopedPerView(declared(frozen), viewId)),
)
})
@@ -94,6 +97,13 @@ describe.each(VIEWS)('the %s canvas', (viewId) => {
layers[name] = await mountedLayer(viewId, states)
}
expect(Object.keys(layers).length).toBeGreaterThan(8)
checkR3Golden(`canvas.${viewId}.layers.json`, layers, declared)
checkR3Golden(`canvas.${viewId}.layers.json`, layers, (frozen) =>
Object.fromEntries(
Object.entries(declared(frozen) as Record<string, unknown>).map(([name, layer]) => [
name,
withDeclaredHitboxes(layer),
]),
),
)
})
})