From 3f239d18d5076433d889f9a4ca22804f5d2832a7 Mon Sep 17 00:00:00 2001 From: Bastien Chanot Date: Sat, 13 Jun 2026 23:55:05 +0200 Subject: [PATCH] docs(memory): capitalize BDR-022 (keep pathology-editor standalone) Co-Authored-By: Claude Opus 4.8 (1M context) --- .claude/memory/decisions.md | 12 ++++++++++++ .claude/memory/journal.md | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index 7c799418..deb4b42e 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -185,3 +185,15 @@ Tab: clicking zone ALWAYS opens its region — `initialRegion` now beats `initia Confined to spine: picker only opens for `special==='vertebral-precision'`; sync/collect/find all gate on it; non-spine zones pass through. Tests cover. Alt rejected: keep additive (BDR-018) + only change seeding — deselection in non-clicked tab silently fails. Status: closed. + +--- + +## BDR-022 | 2026-06-13 | Keep pathology-editor standalone — asymmetry vs svg-editor intentional + +After 404 fix (moved pathology-editor.html root→public/, LRN-029), considered unifying it with svg-editor pattern (React route, vanilla wrapped in useEffect, BDR-017). Rejected. Two editors differ by COUPLING, not accident: +- svg-editor REUSES app internals (getAllSpecies registry, useLocaleStore+getDict, AppHeader) → React route earns its keep (BDR-017). +- pathology-editor = zero src/ imports by design (BDR-020/021): own inline i18n (76 keys), own zoneMatch copy. Isolated on purpose. +**Why keep standalone:** editor PRODUCES the prod `pathologies.json` the live app reads (fetches `/species/equine/{pathologies.json,Horse.svg,Horse_head.svg}` — same bytes as app). Tool touching prod data = minimal-change zone. Wrapping ~1700 lines of imperative DOM in a useEffect to chase cosmetic parity risks the JSON export path for no functional gain. The svg-editor wrap (1832-line useEffect) is the WORSE of the two patterns, not the target to copy. +Alt rejected: pathology→React route (BDR-017 style) — propagates the dubious pattern over 1700 lines, regression risk on drag/tree-edit/SVG-sanitize/fuzzy-match. +Alt rejected: both→standalone public/ (de-wrap svg) — cleaner unification but svg now coupled to species registry + locale store; de-wrapping costs + loses language sync. +Status: closed. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index 63609e90..fe871db1 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -157,4 +157,5 @@ feat(ui+pdf): footer partnership credit "Paws iin Harmony" text -> Paws_in_harmo ## 2026-06-13 -fix(editor) 2803cf7 — pathology-editor.html 404 in prod (faunosteo.com/pathology-editor.html). Root cause: file at repo root, Vite bundles only index.html -> never in dist/ -> nginx SPA-fallback -> React "Page introuvable". Worked in `pnpm dev` (serves root files), hid prod gap. Fix: git mv -> public/ (copied verbatim to dist/), href unchanged (public/=web root). Verified via vite preview: /pathology-editor.html=200 text/html. CLAUDE.md + README folder maps synced. LRN-029 captured. +fix(editor) 2803cf7 — pathology-editor.html 404 in prod (faunosteo.com/pathology-editor.html). Root cause: file at repo root, Vite bundles only index.html -> never in dist/ -> nginx SPA-fallback -> React "Page introuvable". Worked in `pnpm dev` (serves root files), hid prod gap. Fix: git mv -> public/ (copied verbatim to dist/), href unchanged (public/=web root). Verified via vite preview: /pathology-editor.html=200 text/html. CLAUDE.md + README folder maps synced. LRN-029 captured. Pushed 97f8a92. +- Decided NOT to unify pathology-editor with svg-editor React-route pattern. BDR-022: asymmetry intentional (svg reuses app internals, pathology isolated zero-imports + produces prod JSON -> minimal-change zone). Verified editor fetches same prod assets as app (/species/equine/{pathologies.json,Horse.svg,Horse_head.svg}, all in dist/). No code change.