docs(docs): rev 5 owner decisions, trial steps and test notes

This commit is contained in:
bchanot committed 2026-11-19 21:15:41 +01:00
1 parent b5dcb766b1
commit 3d6aacad99
3 files changed
+58 -22

No files matched your search

+3 -1
View File
@@ -50,7 +50,7 @@ Implemented (contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`)
## U2 · Points and polygons
Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head, 2026-11-19 (code at da8642dd, this page's figures added after): `pnpm check:all` exit 0 (app 2 140, core-wasm 67, supabase 182 tests, e2e:ui 253); the shell suite without `editor-equine.spec.ts` 330 passed, 17 failed, 5 not run, all in four files outside the editor: admin (6) and catalogue-integrity (6) failing with the same timeouts before U2 (sandbox data; the 56c75b1 baseline log has 4 catalogue-integrity failures), catalogue (3) and admin-sheets-list (2) failing only under the parallel run with « Target crashed » and passing 16/16 with one worker (`--workers=1`, 2026-11-19); `pnpm db:sandbox test` 105 passed, 10 skipped, and `test-db` Files=21 Tests=1958 FAIL on `014_animals_relations` (2) and `021_sheet_verification_jobs` (23), identical to before U2, which changes no SQL (run at 0aa0f6bc); `up fresh` is the owner's call; both opt-in measures rerun (figures in the Performance row). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`).
Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4 then rev 5 (owner decisions D1 to D5, 2026-11-19); boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head, 2026-11-19 (code at da8642dd, this page's figures added after): `pnpm check:all` exit 0 (app 2 140, core-wasm 67, supabase 182 tests, e2e:ui 253); the shell suite without `editor-equine.spec.ts` 330 passed, 17 failed, 5 not run, all in four files outside the editor (figures of the rev 4 code; figures on the final code to be added by the controller). These environment failures are named with their evidence and are not resolved; none is presented as formally independent of U2. Owner decision D5 (2026-11-19): they do not block the manual trial. `admin` (6): timeouts that the 56c75b1 baseline log also shows (sandbox data); no further attribution. `catalogue-integrity` (6): not attributed to U2. The pre-U2 commit 56c75b1 fails the same 6 of 6 tests, on the same assertion, with the same timings, on the same data (2026-11-19, one worker, read-only counts, nothing deleted); the published versions rose from 426 to about 690 in a day of runs, and the failing set grew from 4 to 6 in both trees, so volume is the inferred cause (the card list loads every card before the search narrows it past the 10 s wait). Volume causation is inferred from that trend and the identical baseline, not isolated: a low-volume run needs a reset, which D4 forbids. `catalogue` (3) and `admin-sheets-list` (2): « Target crashed » under the parallel run; both pass 16/16 with one worker (`--workers=1`, 2026-11-19); the logs show nothing more. `pnpm db:sandbox test` 105 passed, 10 skipped, and `test-db` Files=21 Tests=1958 FAIL on `014_animals_relations` (2) and `021_sheet_verification_jobs` (23), identical to before U2, which changes no SQL (run at 0aa0f6bc). The sandbox is never reset or rebuilt on this work (D4). Both opt-in measures rerun (figures in the Performance row). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`).
| Kind | Tests |
|---|---|
@@ -60,6 +60,8 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `
| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` keeps and restores the old shape, undo and redo of each (`editor-zones.spec.ts`); a point: handle drag, size by a click on the track, the move mode (`editor-annotations.spec.ts`); the properties dialog opens over the right column and never over the drawing, a click on the veil does nothing, a double click on the selected zone opens it and inserts no vertex, a typed form then Back asks, a width crossing below 1 024 px keeps the draft (`editor-properties.spec.ts`); « Défaire » in the message line undoes the same entry as the header button, which carries the accessible name « Défaire la dernière modification » (T15; EN « Undo the last change »); during a held arrow series a mouse press on « Défaire » cancels it and « Refaire » restores the earlier move (`editor-annotations.spec.ts`); a Tab and Shift+Tab walk over the drawing place's native controls, and a keyboard Delete whose next vertex starts under the strip, land below the strip at 1 024, 1 180 and 1 280 px (`editor-geometry.spec.ts`) |
| E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px; CDP `Input.dispatchTouchEvent`) | one finger drags a vertex and the point under the loupe; every handle hit circle is at least 44 px; one finger off the handles moves nothing and shows the hint once, with no hint over a page scroll; two fingers zoom and pan; finger 1 on a vertex handle then finger 2: the drag is cancelled, the shape restored, nothing committed, the pinch zooms (Review Focus 1); the move mode by a finger; a tap on the selected shape opens the dialog and it stays open (Review Focus 5), with a chosen vertex it unchooses; the trace closes from a finger within 22 px; page scroll over the canvas with a selection and outside it (`editor-touch.spec.ts`, `editor-properties.spec.ts`, `editor-deselect.spec.ts`) |
| Layout (A14) | `expectNoShift` (`e2e/support/layout.ts`) at 1 024, 1 180 and 1 280 px: no box of the canvas, the strip, the aside or the header moves, `scrollHeight` and the scrollbar gutter are unchanged, and the layout-shift sum is zero around selection, strip content, a message showing and expiring, the hint, a dialog opening and closing, mode entry and exit, and the first commit's save line; `scrollbar-gutter: stable` on the editor page only (`editor-annotations.spec.ts`) |
| Held reason bubble (D1, criterion 33) | unit (`editor-held-bubble.test.tsx`, `editor-history-buttons.test.tsx`): a press by click, Enter, Space, mouse and touch shows the reason in a portalled `position: fixed` bubble, with and without the strip's commands to clear; one announcement per press through an always-mounted `role="status"` region, `aria-describedby` kept; closing on the hold ending, a tab change, blur, a press elsewhere, a scroll, a wheel, a touchmove, a dialog opening and Escape; the first Escape closes the bubble alone, the second reaches the creation question or drops the pending preview, in a text field Escape also reaches the field; e2e (`editor-annotations.spec.ts`) at 1 024, 1 180 and 1 280 px: the bubble inside the window, under the bar, within 8 px under its button, at most 288 px wide, over neither « Défaire » nor the strip's commands, `expectNoShift`, `scrollWidth` unchanged, axe open, repeated scrolled and from the keyboard, the scroll awaited by a helper that waits for three still animation frames |
| Pinned drawing column (Task 17, criterion 32) | `editor-geometry.spec.ts` at 1 024, 1 180 and 1 280 px: at each scroll step the column's top is below the strip, its bottom in the window once stuck, the canvas painted at its top centre, its size constant, no sideways scroll; a focus never scrolls the page (« Défaire », a chip, a handle, the canvas box) and the add button, below the fold, is revealed below the strip; Delete and Insert on a pinned vertex keep the page still; a row selection moves neither the page nor the drawing; at 1 180 × 700 the canvas is capped and the column fits the window; at 1 024 × 600 (below 644 px) nothing is pinned and the Task 14 focus tests run there; `editor-deselect` and `editor-journey` presses no longer scroll to the page top |
| Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; « + » inserts and Backspace removes on a focused vertex, Backspace after an undo acts on the same focused handle; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series |
| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) |
| Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Retirer le sommet {n} de {nom} », the handle group « Sommets de {nom} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) |