fix(supabase): a null lease token is stale in the three M6 round RPCs

Security review MEDIUM: is distinct from let a null token match an unleased
verifying round (service role only). pgTAP 021: 72.
This commit is contained in:
bchanot committed 2026-11-01 21:19:54 +01:00
1 parent 5adad3709f
commit 3bfd6c87aa
2 files changed
+12 -4

No files matched your search

@@ -248,7 +248,8 @@ declare
begin
perform private.require_service_role();
select r.* into v_review from public.anatomical_sheet_reviews r where r.id = review_id;
if v_review.id is null or v_review.status <> 'verifying' or v_review.lease_token is distinct from lease_token then
if v_review.id is null or v_review.status <> 'verifying'
or lease_token is null or v_review.lease_token is distinct from lease_token then
return null;
end if;
select v.* into v_version from public.anatomical_sheet_versions v where v.id = v_review.version_id;
@@ -298,7 +299,8 @@ declare
begin
perform private.require_service_role();
select r.* into v_review from public.anatomical_sheet_reviews r where r.id = review_id for update;
if v_review.id is null or v_review.status <> 'verifying' or v_review.lease_token is distinct from lease_token then
if v_review.id is null or v_review.status <> 'verifying'
or lease_token is null or v_review.lease_token is distinct from lease_token then
return 'stale';
end if;
select v.* into v_version from public.anatomical_sheet_versions v where v.id = v_review.version_id;
@@ -386,7 +388,8 @@ begin
raise exception 'invalid_input' using errcode = 'P0001';
end if;
select r.* into v_review from public.anatomical_sheet_reviews r where r.id = review_id for update;
if v_review.id is null or v_review.status <> 'verifying' or v_review.lease_token is distinct from lease_token then
if v_review.id is null or v_review.status <> 'verifying'
or lease_token is null or v_review.lease_token is distinct from lease_token then
return 'stale';
end if;
v_final := v_review.attempts >= private.sheet_verification_attempt_limit();