fix(domain): sheet.check reads its document without an intermediate copy; RUST.md states the copy behaviour exactly

Second security pass on e49009e: PASS with two LOW items, both applied.
Module 1,044,559 B raw / 340,154 B gzip; core 135, core-wasm 25, app 313.
This commit is contained in:
bchanot committed 2026-10-14 01:07:17 +02:00
1 parent 651f1fef13
commit 36316cf67f
3 files changed
+12 -8

No files matched your search

+9 -6
View File
@@ -573,7 +573,7 @@ Closed failure kinds: `invalid_json`, `invalid_shape`, `unknown_op`,
| Measure | Value |
|---|---|
| shipped module | 1,046,498 B raw (native), **340,929 B gzip -9** (budget 600 KB); before the by-reference deserialisation of the security follow-up: 1,180,153 B raw / 372,275 B served by the image |
| shipped module | 1,044,559 B raw (native), **340,154 B gzip -9** (budget 600 KB); before the by-reference deserialisation of the security follow-up: 1,180,153 B raw / 372,275 B served by the image |
| glue | 10,171 B |
| load (compile + instantiate) | 6 to 8 ms |
| sheet handle + index data (bundle 0.5 MB) | 22 to 27 ms (TypeScript parse + index on the same input: 12 to 15 ms) |
@@ -585,10 +585,13 @@ Closed failure kinds: `invalid_json`, `invalid_shape`, `unknown_op`,
| app image | 104 MB (wasm stage: the Rust toolchain stays in the builder) |
Pages without the core load nothing more than before R2; the sheet pages
fetch about 351 KB more (glue + gzip module) once per session. Every JSON
input is deserialised by reference (`T::deserialize(&Value)`), never through
a copy of the value: a large attachment is not duplicated in linear memory,
and one deserialiser instead of two keeps the module smaller.
fetch about 351 KB more (glue + gzip module) once per session. JSON inputs
are deserialised by reference (`T::deserialize(&Value)`): the imported
attachment is never copied as a whole value (its strings are copied once
into the typed contract), and one deserialiser instead of two keeps the
module smaller. Operation inputs (`parse_input`) keep the parsed value alive
while their strings are copied out: a transient, linear peak on inputs the
application itself builds.
### 8.7 Behaviour differences (declared)
@@ -626,7 +629,7 @@ and one deserialiser instead of two keeps the module smaller.
- The CSP proof runs Chromium only (no Firefox or WebKit build on this
machine): the owner's manual run of the image on other browsers and the
phone covers Safari and Firefox.
- The module grows with each phase (341 KB of the 600 KB budget at R2; the
- The module grows with each phase (340 KB of the 600 KB budget at R2; the
`url` crate's IDNA tables are part of it): R3/R4 must keep measuring.
- The quarantine slots (`osteo:quarantine:*`) keep verbatim copies of drafts
(practitioner, owner and animal data) until the tab closes, the same