chore(memory+docs): /ship-feature B3 capitalize — BDR-014/015 + LRN-017..019 + EVAL-002 + journal + TODO

Memory registry capitalization after B3 i18n FR/EN ship.

- decisions.md  +BDR-014 (PDF locale = render preference, store-driven, not Report schema field — dual label snapshot already carried).
- decisions.md  +BDR-015 (typed ImportError discriminant kind + foundVersion; UI resolves message via dict; review caught hardcoded FR in domain layer).
- learnings.md  +LRN-017 (i18n dict parity test: Object.keys().sort() equality + non-empty value assertion — cheapest drift guard).
- learnings.md  +LRN-018 (useT hook pattern: selector subscribe + dict closure-per-render, no prop drilling, missing-key dev-warn + key-literal fallback).
- learnings.md  +LRN-019 (exhaustive-deps trap when closures over store values appear inside useMemo deps — inline or useCallback).
- evals.md      +EVAL-002 (B3 review caught critical FR leak in pdf/import.ts + attachment.ts that grep+analyzer both missed — i18n migrations must enumerate ALL string-emitting files including error paths).
- journal.md    session 3 entry under 2026-05-20.
- TODO.md       B3 subsection rewritten as DONE with checked checkboxes + cross-refs.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Bastien ChanotandClaude Opus 4.7 committed 2026-05-20 07:43:11 +02:00
1 parent 9916c42484
commit 31bd82de58
7 files changed
+111 -21

No files matched your search

+16
View File
@@ -50,6 +50,22 @@ Bundled B0+B1+B2 shipped on feat/findings-tree-v2. 3 atomic commits.
---
## 2026-05-20 (session 3 — B3 shipped)
B3 (i18n FR/EN site + PDF) shipped on `feat/findings-tree-v2` via /ship-feature. 5 new commits:
- 0a05c47 docs(plan): B3 i18n FR/EN implementation plan
- a570475 feat(i18n): localeStore + persist
- 359104c feat(i18n): fr/en dicts + useT hook (~90 keys each, parity-tested)
- d602726 feat(i18n): migrate site + PDF to locale-aware (25 files, +390/-207)
- fa3eb51 test(pdf): roundtrip per locale (3 cases)
- (post-review fix) typed ImportError discriminant for localized PDF import errors
- 154/154 tests pass, lint clean, typecheck clean, build OK.
- description_fr + scope_disclaimer stay FR-only this iteration (vet-expert authoring needed).
- BDR-014 (PDF locale = render preference), BDR-015 (typed ImportError discriminant), LRN-017 (dict parity test), LRN-018 (useT selector+closure), LRN-019 (exhaustive-deps closure trap), EVAL-002 (review caught FR leak in PDF import) captured.
- NEXT: B4 (PDF observationPage vet-referral polish), C (full horse.json + QA + Scaleway deploy). description_fr/_en EN copy when vet expert provides.
---
## 2026-05-20 (session 2)
Iterated on the findings-tree branch — 11 more commits on top of B0+B1+B2.