From 2f1f0764bfd404051634d6fa5ca448f6dc53e673 Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 30 Oct 2026 15:21:05 +0100 Subject: [PATCH] docs(docs): V1-2.2 finalisation review drift, canvas size cap, TODO --- .claude/memory/journal.md | 1 + .claude/tasks/TODO.md | 12 ++++++------ docs/ANNOTATION-RENDERING.md | 6 ++++-- docs/development/RUST.md | 4 ++-- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index f0a507c2..8952d093 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -488,3 +488,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp ## 2026-10-30 - V1-2.2 owner decisions on 05de816: BDR-087 canonical stored SVG, LRN-099→LRN-100 strict reference grammar. Final review (Opus, Fable out of credits): verifier ECARTS(3) = A6 open, B9 LOW f1ef6a4 glued url( reader/composer mismatch fail-closed, FLOOR prose FP; security PASS (MEDIUM per-document prefix, 5 LOW). 05de816 = f1ef6a4 code. A6 not met. No fix, STOP at checkpoint. +- V1-2.2 finalisation 2026-10-30: Figma default Clean, ids Cleanable (g@id), pixel-identical after maskUnits/maskContentUnits/clipPathUnits allowed (BDR-088). Glued url( removed in every attribute (urls_unglued), LRN-101. check:all green 7d9ab8c. Verifier ECARTS(2): A6 Illustrator, doc drift fixed. Security PASS, pre-existing MEDIUM PDF halo id osteo-halo for owner. Not VERIFIED. STOP. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 929a02ed..323fcab6 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -581,12 +581,12 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] I6 wasm size: contributors measured, optimisation options for later steps; cap and test kept; owner go 2026-10-29: `--remove-name-section` in scripts/wasm-build.sh (debug `name` section, 279 KB raw, −30 691 B gzip measured) - [x] I7 gates: check:all green on 5281337 and a678faa (final rerun on the last commit); mutations 16 killed + 1 equivalent; fresh reviews (Sonnet: Fable out of credits, Opus alias 404): security BLOCK(1) HIGH url(#%61) → fixed a678faa → PASS; verifier ECARTS → LOWs fixed, A6 open; evidence §7; commit + push. Open: A6 owner exports, MEDIUM per-document prefix before any two-document page - [ ] J finalisation and A6 Figma (brief « V1-2.2 : finalisation et intégration A6 Figma », 2026-10-30, on 98060d7) - - [ ] J1 Figma fixtures (`owner/figma-web-20261030-{default,ids}.svg`, owner files, never edited): both Cleanable; `mask@maskUnits` removal cuts 208 px (×8) in Chromium 156 → owner go 2026-10-30: allowlist `maskUnits`, `maskContentUnits`, `clipPathUnits`, values `userSpaceOnUse` | `objectBoundingBox` only; fixed expectations in `svg_clean`; pixel proof; constructs documented in exports README - - [ ] J2 glued `url(` (final review LOW, f1ef6a4): the reader removes any attribute holding a `url(` that `url_openings` does not read (same helper, no second parser); composer comment fixed; tests (glued in class/result/values, valid, absent, encoded/escaped, no reference, composer vs PDF on one drawing, fail-closed branch reached) - - [ ] J3 Affinity optional in A6 (owner 2026-10-30), Figma required, Illustrator expected (real Adobe Illustrator, VectorCraft not equivalent): contract, V1-2 contract §17.4, RUST.md §12, READMEs - - [ ] J4 FLOOR false positive: reword `.claude/audits/2026-10-29-v1-2-2-arbitrations-security.md:225`, guard kept - - [ ] J5 memory: BDR-087 checked, LRN-100 superseded after J2; per-document prefix requirement kept - - [ ] J6 gates: full cargo, svg suites, mutations, wasm + ts-rs, size < 600 000, check:all (DEV-isolated steps only), fresh independent review; commit + push; STOP (A6 open: Illustrator) + - [x] J1 Figma fixtures (`owner/figma-web-20261030-{default,ids}.svg`, owner files, never edited): both Cleanable at first; `mask@maskUnits` removal cuts 208 px (×8) in Chromium 156 → owner go 2026-10-30: allowlist `maskUnits`, `maskContentUnits`, `clipPathUnits`, values `userSpaceOnUse` | `objectBoundingBox` only; fixed expectations in `svg_clean`; pixel proof; constructs documented in exports README + - [x] J2 glued `url(` (final review LOW, f1ef6a4): the reader removes any attribute holding a `url(` that `url_openings` does not read (same helper, no second parser); composer comment fixed; tests (glued in class/result/values, valid, absent, encoded/escaped, no reference, composer vs PDF on one drawing, fail-closed branch reached) + - [x] J3 Affinity optional in A6 (owner 2026-10-30), Figma required, Illustrator expected (real Adobe Illustrator, VectorCraft not equivalent): contract, V1-2 contract §17.4, RUST.md §12, READMEs + - [x] J4 FLOOR false positive: reword `.claude/audits/2026-10-29-v1-2-2-arbitrations-security.md:225`, guard kept + - [x] J5 memory: BDR-087 checked, LRN-100 superseded after J2; per-document prefix requirement kept + - [ ] J6 gates: full cargo, svg suites, mutations, wasm + ts-rs, size < 600 000, check:all (DEV-isolated steps only), fresh independent review; commit + push; STOP (A6 open: Illustrator). Done 7d9ab8c/f976f33: check:all green, verifier ECARTS(2) (A6 Illustrator; §12.4 drift fixed after), security PASS (new pre-existing MEDIUM: PDF halo id `osteo-halo` reusable by a drawing, owner decision); left open until Illustrator - [ ] V1-2.3 drawings and worker verification (M6) · V1-2.4 wireframes (editor, review, admin entry) · V1-2.5 catalogue, admin space, rights, species, MFA · V1-2.6 editor level 1 · V1-2.7 preview, review, publication UI · V1-2.8 equine working copy and review preparation · V1-2.9 FR/EN acceptance and closure (owner checkpoints V1-2.3, V1-2.4, V1-2.6, V1-2.7, V1-2.8, V1-2.9 + each DEV operation of contract §16.11) ## Release readiness track (owner 2026-10-25, distinct from the functional roadmap; nothing here authorises a release or exposure) diff --git a/docs/ANNOTATION-RENDERING.md b/docs/ANNOTATION-RENDERING.md index 8ae2f587..28fadf52 100644 --- a/docs/ANNOTATION-RENDERING.md +++ b/docs/ANNOTATION-RENDERING.md @@ -84,8 +84,10 @@ does not define is refused by the reader (`dangling_reference`); a `url(` spelt any other way than `url(#id)` with optional quotes and spaces is removed by the reader, so the cleaning refuses the file as active content and the verdict as a removal. A `url(` glued to a longer name (`xurl(#a)`) is no reference: the reader -removes the attribute holding it, whatever the attribute (2026-10-30), so every -drawing the reader keeps composes into the canvas and the PDF view alike. The annotation +removes the attribute holding it, whatever the attribute (2026-10-30), so the +canvas and the PDF view accept the same references as the reader; the canvas +still refuses a composed view over 4 MiB (`too_large`), its scope prefix +lengthening every id and reference. The annotation layer carries no `id`. The PDF view keeps the drawing's ids: it is rasterised as a document of its own. The R3 canvas goldens stay frozen; the tests apply this declared change to them (`withIdsScopedPerView`, diff --git a/docs/development/RUST.md b/docs/development/RUST.md index 19e8e0af..9b38a5ef 100644 --- a/docs/development/RUST.md +++ b/docs/development/RUST.md @@ -3931,11 +3931,11 @@ trapping test stub (`apps/app/tests/helpers/core.ts`) lists the two new glue mem takes only its key and descendants, the rule of insert, update, move, set_status and `mark_reviewed`; nothing turned `inherited`). The keys of views, references, regions and annotation categories and the redraw rule are held by the case tests, not by the property test. -- `svg_clean` (14 since §12.7): the 42 hostile files, each on the §9.2 line it belongs to; the security audit's 13 probes +- `svg_clean` (14 since §12.7, 17 since §12.8): the 42 hostile files, each on the §9.2 line it belongs to; the security audit's 13 probes (stylesheet PIs, active content under a long title, HTML fetchers, XHTML elements) refused; a stored PI refused by the verdict; active names; a plain `