test(tests): working-copy dialog checks independent of the shared slot
admin.spec opened the working-copy dialog on the historical sheet, whose single slot was taken by a copy the sandbox suite leaked. The dialog checks move to an e2e:ui page on the real component; the suite archives its own copies.
This commit is contained in:
1 parent
da298cfab1
commit
2cdee42fe1
9 files changed
+304
-25
No files matched your search
@@ -43,7 +43,7 @@ Companion: `TRIAL_STACK.md` (the dedicated manual trial stack, request §5).
|
||||
|
||||
Every lot: one commit or more per coherent change, pushed; gates in this order: `pnpm typecheck`, `pnpm lint`,
|
||||
`pnpm test:run`, `pnpm build`, `pnpm e2e:ui`, then the shell suite on the sandbox as it stands, with its exact result
|
||||
(the suite is not green today: four `admin.spec.ts:717` failures from the taken working-copy slot, anomaly B). Every
|
||||
(the four `admin.spec.ts:717` failures of the taken working-copy slot, anomaly B, are fixed: row B of section 5). Every
|
||||
removed or rewritten assertion is mapped to its replacement in the commit message (R-24). Design gates: the boards of
|
||||
R0 as validated, `impeccable detect` on the changed components, a fresh design review before the lot closes.
|
||||
|
||||
@@ -243,15 +243,15 @@ The criteria below are the contract as written.
|
||||
|
||||
R0 first (validation). R1 is independent of R2 and can ship first. R2 depends on the validated boards 23 to 27. R3
|
||||
ships search and name sort first; its date part waits for the SQL checkpoint (A7 ratified).
|
||||
R4 is independent and may run any time after its board (30) is validated. Anomaly B (section 5) should land before
|
||||
the gates of R2 and R3 are read, since its taken slot fails four admin specs on every run.
|
||||
R4 is independent and may run any time after its board (30) is validated. Anomaly B (section 5) is fixed: the admin specs no longer
|
||||
depend on the working-copy slot.
|
||||
|
||||
## 5. Test anomalies tracked apart (D9)
|
||||
|
||||
| Item | Cause | Constraint |
|
||||
|---|---|---|
|
||||
| A. Fictitious fingerprints | Worker stand-ins publish with `'a'.repeat(64)`: `packages/supabase/tests/sandbox/sheet-fixtures.ts:115` (`openRound`), `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`. Seven published or deprecated versions on the sandbox fail `check_published`; the owner opened three of them on 2026-11-09. | Compute the real fingerprint through the core as the catalogue e2e does (`fingerprintOf`), never weaken the publish gate or the reader's check. |
|
||||
| B. Working copy never archived | `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts:181-195` creates the historical sheet's working copy (`8c315a12-…`, 2026-11-08 21:00:30) and never archives it; the single slot then disables « Créer une copie de travail » (`WorkingCopyAction.tsx:88`) and fails `admin.spec.ts:717` four times. | Make the suite independent (its own cleanup, or a precondition it creates and removes); the existing copy is not touched before the owner authorises it. |
|
||||
| B. Working copy never archived | (a) `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts` created the historical sheet's working copy (`8c315a12-…`, 2026-11-08 21:00:30) and never archived it; the single slot then disables « Créer une copie de travail » (`WorkingCopyAction.tsx:88`). (b) Even on a fresh stack `editor-equine.spec.ts` flips the slot while `admin.spec.ts:717` runs in parallel. Only the historical sheet offers the action, so the test depended on shared state. | FIXED (owner, 2026-11-12, option 1): the dialog's axe, layout and keyboard checks run on the real component in `e2e/ui/working-copy.spec.ts`; `admin.spec.ts` keeps the historical page and checks the button state against its reason; the sandbox suite archives only the copies it created (`returning id` checked) and each cleanup step runs independently. Limit: the dialog is no longer checked in its real server context by this accessibility test. Open: the creation branch of the cleanup is not yet run on a fresh stack. `editor-equine.spec.ts` still archives and restores pre-existing copies on every run. |
|
||||
| C. Silent card failure | Section 3, R4. | Show the failure, never hide or route around it. |
|
||||
|
||||
## 6. Arbitrations
|
||||
|
||||
Reference in new issue
Block a user