fix(pdf): bundle the branding assets into the app (no fetch at export), export returns its warnings and the editor reports missing elements
This commit is contained in:
1 parent
80e95ca61d
commit
293a6e0b36
22 files changed
+199
-185
No files matched your search
@@ -1,8 +1,9 @@
|
||||
/**
|
||||
* Step 6 Phase 0 freeze (STEP6_PDF_ARCHIVE_ANALYSIS.md §17) replayed on the
|
||||
* application export path: `exportReportToPdf` now runs the engine with the
|
||||
* bundled sheet snapshotted, the branding fetched from `public/` and the
|
||||
* browser rasterizer (mocked to fixed PNGs, as the Phase 0 stub was). Text,
|
||||
* bundled sheet snapshotted, the bundled branding (mocked to every slot empty
|
||||
* for the `nologos` mode, the real module for `logos`) and the browser
|
||||
* rasterizer (mocked to fixed PNGs, as the Phase 0 stub was). Text,
|
||||
* images and links goldens are asserted as frozen; `MAKE_GOLDEN=1` rewrites
|
||||
* them, never without a user decision. Never regenerate `report-v3.bare.pdf`:
|
||||
* it is the Step 5 bare export, an import fixture only.
|
||||
@@ -30,7 +31,6 @@ import {
|
||||
import {
|
||||
checkGolden,
|
||||
FIXTURES_DIR,
|
||||
installLogoFetch,
|
||||
ONE_PX_PNG,
|
||||
readGolden,
|
||||
readLinks,
|
||||
@@ -48,6 +48,11 @@ const raster = vi.hoisted(() => ({ png: new Uint8Array() }))
|
||||
vi.mock('@/pdf/browserRasterizer', () => ({
|
||||
browserRasterizer: vi.fn(async () => raster.png),
|
||||
}))
|
||||
const logoMode = vi.hoisted(() => ({ current: 'nologos' as LogoMode }))
|
||||
vi.mock('@/pdf/branding', async () => {
|
||||
const { brandingOf } = await import('../helpers/goldens')
|
||||
return { loadBranding: vi.fn(() => brandingOf(logoMode.current)) }
|
||||
})
|
||||
|
||||
const REPORTS = ['v2full', 'demo', 'v2unresolved'] as const
|
||||
type ReportName = (typeof REPORTS)[number]
|
||||
@@ -103,15 +108,14 @@ async function exportWith(
|
||||
locale: Locale,
|
||||
): Promise<Exported> {
|
||||
raster.png = mode === 'logos' ? TWO_BY_ONE_PNG : ONE_PX_PNG
|
||||
const restoreFetch = installLogoFetch(mode)
|
||||
logoMode.current = mode
|
||||
const recording = recordDrawing()
|
||||
try {
|
||||
const bytes = await exportReportToPdf(report, sheet, { locale })
|
||||
const { pdf: bytes } = await exportReportToPdf(report, sheet, { locale })
|
||||
const { texts, images } = recording
|
||||
return { bytes, texts, images, links: await readLinks(bytes) }
|
||||
} finally {
|
||||
recording.stop()
|
||||
restoreFetch()
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user