From 27bf59cd4b52ad743c96fd42ada01ffcd644b0f0 Mon Sep 17 00:00:00 2001 From: bchanot Date: Sun, 25 Oct 2026 13:37:22 +0100 Subject: [PATCH] docs(docs): R5.7 owner decision C6 (tsx optional peer), pre-merge note --- .../contracts/2026-10-25-rust-r5-7-cleanup.md | 22 ++++++++++++++++++- docs/development/RUST.md | 15 +++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/.claude/tasks/contracts/2026-10-25-rust-r5-7-cleanup.md b/.claude/tasks/contracts/2026-10-25-rust-r5-7-cleanup.md index 07e3bcf2..94bc4f10 100644 --- a/.claude/tasks/contracts/2026-10-25-rust-r5-7-cleanup.md +++ b/.claude/tasks/contracts/2026-10-25-rust-r5-7-cleanup.md @@ -29,7 +29,8 @@ C5. **Historical reproducibility.** The documentation names the reference commit sha256 of the artifacts; the procedure is rehearsed once; the old engine is not reintroduced in the current tree. C6. **Dependencies and scripts.** The two packages' own dependencies leave the lockfile through `pnpm install`; `@xmldom/xmldom` -and `tsx` are gone; root `prettier` stays (used by `pnpm format` and `db:types`); `pnpm import:equine` stays the Rust pipeline; +is gone; no workspace manifest declares `tsx`, no script runs it, and the lockfile may keep it only as a transitive optional peer +the package manager resolves itself (Clarification C6 below); root `prettier` stays (used by `pnpm format` and `db:types`); `pnpm import:equine` stays the Rust pipeline; `import:equine:legacy` and `assets:upload:legacy` are removed; no other dependency changes major version; the lockfile installs with `--frozen-lockfile`. @@ -48,3 +49,22 @@ seed integrity suites, and the absence of any import of the deleted packages, al C10. **Limits.** Branch only; no merge, no release, no deploy, no Supabase DEV data change, no migration, no new feature; no seed byte changed. + +## Clarification C6 (owner, 2026-10-25, brief « Validation R5.7 et dernière vérification pré-fusion » §1) + +The first wording read « `@xmldom/xmldom` and `tsx` are gone ». The owner accepts explicitly that `tsx` stays named in +`pnpm-lock.yaml` when it is only an optional peer dependency of Vite. The objective C6 checks is: no old TypeScript pipeline +active; no functional import from `packages/anatomy` or `packages/domain`; no script kept that requires them; no direct `tsx` +dependency left without use; legitimate transitive or optional references of the package manager may stay. The lockfile is +not edited by hand and no override or exclusion is added to drop the name. + +Measured path (`pnpm why tsx -r`, 2026-10-25): `tsx` 4.23.15 is reached only as the `peer` of `vite` 7.3.6 (vite declares +`tsx: ^4.8.1` under `peerDependencies` with `peerDependenciesMeta.tsx.optional: true`), through `vite`, `vitest`, +`@vitest/mocker`, `vite-node`, `@tailwindcss/vite` and `@vitejs/plugin-react-swc` in the devDependencies of `apps/app`, +`packages/core-wasm` and `packages/supabase`; its snapshot block carries `optional: true`; no importer lists it; no +`node_modules/.bin/tsx` is linked. + +The exception does not hide a consumer: `r5.census.test.ts` still fails if a manifest declares `tsx` (any dependency field), +if a manifest script names `tsx`, `@faunosteo/{anatomy,domain}` or `packages/{anatomy,domain}` or ends in `:legacy`, if an importer block lists `tsx`, if the +`tsx` snapshot loses `optional: true`, or if any app, Vite, glue or Supabase-package source imports a deleted package; the +verifier checks these probes, not the lockfile name. diff --git a/docs/development/RUST.md b/docs/development/RUST.md index 18be1549..c1ba3227 100644 --- a/docs/development/RUST.md +++ b/docs/development/RUST.md @@ -3744,8 +3744,8 @@ upload script absent; no manifest declares them, xmldom or tsx, no `:legacy` scr the Rust binaries; the lockfile importers equal the manifests on disk (non-vacuity) and resolve none of them; no app, Vite, glue or Supabase-package source imports them (non-vacuity: `@faunosteo/core-wasm` is found); the Dockerfile copies only existing manifests; the ESLint ban names `@faunosteo/domain`, `@faunosteo/anatomy`, `@xmldom/xmldom`; every `FILES.tsv` row -absent with its counterpart present; every `LEDGER.tsv` row absent, 407 = 144 + 263, valid status, each cargo target a `fn` -of its test file, each oracle file present; the moved fixtures' sha256; the oracles, pre-switch copies and N-1 readers present. +absent with its counterpart present; every `LEDGER.tsv` row absent, 407 = 144 + 263, valid status, each cargo target a +`#[test]` function of its test file and never an `#[ignore]` one, each oracle file present; the moved fixtures' sha256; the oracles, pre-switch copies and N-1 readers present. **Test counts.** Before (756b7ef, vitest JSON): TypeScript 943 (app 436, core-wasm 60, supabase 40, anatomy 144, domain 263); Rust core 364 (features `cli,upload`) + worker 33. After: TypeScript 546 (app 446 = 436 + the 10 R5 census cases, core-wasm 60, @@ -3814,6 +3814,17 @@ the declared R3 trigger-name rule). the N-1 suites (`n-1.reader`, `r5-6.n-1`, `n-1.scanner`), seed and sheet integrity (`curation_*`, `sheet_rules`, `sheet_conformance`), the census suites. +**Owner validation and pre-merge checks (2026-10-25, brief « Validation R5.7 et dernière vérification pré-fusion »).** +R5.7 is validated. Decision C6: `tsx` may stay named in the lockfile as long as it is only the optional peer of vite +(`pnpm why tsx -r`: `tsx` 4.23.15 reached only as `vite` 7.3.6's peer, `peerDependenciesMeta.tsx.optional: true`, through the +devDependencies of the app, `core-wasm` and `supabase`; no importer lists it, no `node_modules/.bin/tsx`); no lockfile hand edit, +no override; the contract records the clarification and the census still fails on a declared `tsx`, a manifest script naming it or an +importer listing it. The 149 `replaced` rows were checked active: every cargo target runs in `cargo test` (none `#[ignore]`d, +now asserted by the census), the two vitest targets name existing cases, and every cited oracle is read by a test (the 26 +conformance cases through `read_dir`, the R3 canvas goldens through their view name). The checks were rerun on the state meant +for the merge after the two changes that followed the first `check:all` (the C8 digest typo, the census `#[test]` rule); their +results, the fresh verifier and the security audit are recorded in `.claude/audits/2026-10-25-rust-r5-7-premerge.md`. + **Follow-ups kept (brief §10, unchanged by R5.7).** The rollback limit of reports written after R5.6 (a build that can roll back must recognise both conventions before any public exposure; tested by `r5_6_switch`); DEV Supabase hardening (ENVIRONMENTS.md §3.6); the migration-map cascade debt (§11.12); the direct export API trust boundary (§11.22); the SQL