refactor(anatomy): category becomes free-form string, no enum / no auto-trigger

User asked that the app interact with anything carrying data-anno-*
attributes without hardcoding any specific category, id, or name. Future
SVGs may introduce new categories, and the existing SVGs may be updated.

Changes:
- `BoneCategory` is now `type BoneCategory = string`. The closed union
  is gone; the parser accepts any non-empty value. New categories don't
  require code changes.
- `VALID_CATEGORIES` and `isValidCategory()` removed from
  svgConvention.ts. `validateBoneElement()` now only enforces presence
  of `data-anno-id` and `data-anno-category`.
- EditorRoute no longer auto-triggers the vertebra picker when the
  clicked annotation is `zone-colonne`. Any zone is added the same way
  to the active observation regardless of category.
- ObservationCard shows a "Vertèbres…" link on every zone badge (was
  conditional on `category === 'zone-colonne'`). The praticien picks
  vertebrae only when relevant — the UI no longer knows or cares which
  zones are spinal.
- Tests rewritten: removed the `isValidCategory` enum assertions and
  the "rejects unknown category" branch. New test demonstrates that
  parseSvgBones accepts a completely novel category string.

90/90 tests pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bastien ChanotandClaude Opus 4.7 committed 2026-05-19 04:10:54 +02:00
1 parent cad94a49db
commit 21b678c3d5
5 files changed
+41 -76

No files matched your search

+7 -10
View File
@@ -1,16 +1,12 @@
/**
* Valid data-anno-category values per the SVG convention.
* `data-anno-category` is a free-form string supplied by the SVG.
*
* Categories are scoped to the kind of anatomical structure each
* annotation represents. Adding a new value here is the only place to
* touch when the source SVGs introduce one.
* The application never branches on category values — it treats every
* annotation the same way. Categories are kept around because they're
* useful for grouping and future filtering, but no code path here may
* rely on a closed set.
*/
export type BoneCategory =
| 'articulations'
| 'charni-res-vert-brales'
| 'zone-colonne'
| 'cadrans-du-cr-ne'
| 'os'
export type BoneCategory = string
/**
* Logical annotation as parsed from an SVG. All DOM elements sharing the
@@ -24,6 +20,7 @@ export interface Bone {
fr: string
/** English label from data-anno-name-en — may be empty */
en: string
/** Raw value from data-anno-category — opaque to the application */
category: BoneCategory
/** Detail popup id from data-anno-opens-detail, if present */
opensDetail?: string