From 1f8873dbceda2c5d1e6377807df11689b4489e8d Mon Sep 17 00:00:00 2001 From: bchanot Date: Sat, 24 Oct 2026 03:59:04 +0200 Subject: [PATCH] docs(docs): R5.5 closing gates round 2, contract clarification, TODO --- .claude/tasks/TODO.md | 2 +- .../tasks/contracts/2026-10-24-rust-r5-5-closing.md | 10 ++++++++++ docs/development/RUST.md | 11 ++++++++--- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 424a481b..e343f0e0 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -338,7 +338,7 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo - [x] serde: `check_v3_shape` at `read_report_document` v3 + `parse_envelope` (sheet, practitioner, severity), test turned around - [x] `confirm_sheet_asset_upload` characterised (no SQL change), DEV keys + 54321 documented (ENVIRONMENTS.md §3.6) - [x] R5.6 plan `.claude/tasks/plans/2026-10-24-rust-r5-6-fingerprint-switch.md` (4 decisions open) - - [ ] gates: check:all, security, fresh verifier → checkpoint, STOP (no R5.6 without signal) + - [x] gates: round 1 check:all 03:39:24, security PASS (2 MEDIUM, 6 LOW), verifier ECARTS(2) → positional-parent bypass fixed (1ec9e1b); round 2 check:all 03:51:55, verifier K3/K4 behaviour MET, 2 formal gaps → contract Clarification (owner to confirm) → checkpoint, STOP (no R5.6 without signal) - [ ] R5.6 D-R5 switch (convention, aliases, membership test in gated readers with per-file go, seed regenerated once by the Rust tool, `.prettierignore`, CHANGELOG) - [ ] R5.7 consumer census, domain fixtures moved, packages deleted, xmldom + prettier out of the lockfile, docs, ledger; `pnpm check:all`; merge only on the owner's signal - [ ] separate chore (D-R7): form constraints module + PGlite `pg_constraint`/config.toml parity test diff --git a/.claude/tasks/contracts/2026-10-24-rust-r5-5-closing.md b/.claude/tasks/contracts/2026-10-24-rust-r5-5-closing.md index 912550f5..7f0a538f 100644 --- a/.claude/tasks/contracts/2026-10-24-rust-r5-5-closing.md +++ b/.claude/tasks/contracts/2026-10-24-rust-r5-5-closing.md @@ -31,3 +31,13 @@ open decisions; no fingerprint code, no seed or `sheet-ref.json` change, `docume K8. **Gates.** `pnpm rust:check` and `pnpm check:all` green; security PASS on the diff; fresh verifier on this contract. No merge, no release, no deploy, no R5.6. + +## Clarifications + +- 2026-10-24 (closing gates round 2, K4, orchestrator, submitted to the owner at the checkpoint): at `parse_envelope` the + refusal is a `serde_json::Error` naming the field (the function's existing signature), not `ReadFailure::Invalid`; its one + caller (`session.rs`, gated) drops the archive copy as before. Changing the signature would touch `session.rs`, outside this + go. Refusing a positional report, observation or envelope is part of K4: without it the three named shapes pass unseen + under a positional parent (Zod refused those containers too). +- 2026-10-24 (FLOOR): the R5.4 clarification (`.claude/audits/**` Markdown prose quoting a suppression keyword is a + descriptive mention) applies to this contract's audit reports; nothing else is requalified. diff --git a/docs/development/RUST.md b/docs/development/RUST.md index fda86c3c..22d70c75 100644 --- a/docs/development/RUST.md +++ b/docs/development/RUST.md @@ -3418,7 +3418,7 @@ closing gates, test `a_positional_parent_does_not_carry_a_refused_shape_past_the `read_report_document` (v3 branch: PDF import, bare archives, draft restore) and `parse_envelope` (the session's archive copy). Nothing else narrowed: an unknown field and an absent `severity` are read as before; `null` severity was and stays refused (optional, never nullable). Test `characterisation_serde_tolerance` turned -around (5 cases, the envelope entry included). Every R2-R4 suite, the PDF import suites, the envelope goldens and +around (6 cases, the envelope entry and positional parents included). Every R2-R4 suite, the PDF import suites, the envelope goldens and the N-1 reader pass unchanged; no authentic archive was rejected. Not covered by the go, left as is: the same derives on Report v2 and on the other contracts. @@ -3445,6 +3445,11 @@ Closing gates round 1 (257a29b): `pnpm check:all` green 03:39:24; security PASS blind under a positional observation or envelope (fixed, as above), and a stale "or null" message (fixed). Also fixed: a multicast address no longer counts as an own address (it binds and connects on Linux; the private-range rule masked it end to end). Kept: the binary's own-address test checks nothing more than -loopback where `ip` is absent; the internal typed re-reads (`pdf/write/export.rs`, `ops.rs`) read values the -core itself built and skip the raw shape check; the other nested v3 fields and v2 keep serde's leniency +loopback where `ip` is absent; the internal typed re-reads (`pdf/write/export.rs`, `ops.rs`, the export input of +`facade.rs`) read values the core itself built or the page's own state and skip the raw shape check; the other nested v3 fields and v2 keep serde's leniency (outside the go). + +Closing gates round 2 (1ec9e1b): `pnpm check:all` green 03:51:55; targeted fresh verifier K3 MET, K4 met in +behaviour (23 bypass probes refused, a census of 157 repository JSON files finds no authentic shape refused, +`--features cli` 261 passed), ECARTS(2) formal: the `parse_envelope` error type and an audit-prose FLOOR line, +both settled by a contract Clarification submitted to the owner.