fix(domain): shape check sees positional parents, multicast never an own address

This commit is contained in:
bchanot committed 2026-10-24 03:47:07 +02:00
1 parent 257a29b09b
commit 1ec9e1bea6
6 files changed
+273 -8

No files matched your search

@@ -106,3 +106,25 @@ fn the_envelope_entry_refuses_the_same_shapes() {
assert!(parse_envelope(&wrapped).is_err());
}
}
#[test]
fn a_positional_parent_does_not_carry_a_refused_shape_past_the_check() {
let mut report = demo();
let o = report["observations"][0].clone();
report["observations"][0] = json!([
o["id"], o["zones"], o["findings"], o["freeTextFindings"], { "mild": null }, o["comment"]
]);
refused_with(&report, "observations[0]: expected an object");
let envelope: Value = serde_json::from_str(&common::repo_file(
"apps/app/tests/fixtures/goldens/r2/envelope.demo.fr.nologos.json",
))
.unwrap();
let fields = envelope.as_object().unwrap();
let mut positional: Vec<Value> = fields.values().cloned().collect();
let at = fields.keys().position(|key| key == "report").unwrap();
positional[at] = sheet_as_array();
assert!(parse_envelope(&Value::Array(positional)).is_err());
let mut wrapped = envelope.clone();
wrapped["report"] = json!([1, 2, 3]);
assert!(parse_envelope(&wrapped).is_err());
}