refactor(anatomy): rename SVG data attrs (bone → anno) per new convention
User updated the clickable-zone convention in the source SVGs:
data-bone-id → data-anno-id
data-bone-fr → data-anno-name-fr
data-bone-en → data-anno-name-en
data-category → data-anno-category
data-opens-detail → data-anno-opens-detail
Bulk-renamed across:
- public/species/equine/Horse.svg + Horse_head.svg (86 anno-attrs each)
- src/anatomy/svgConvention.ts (parser + getBoneIdFromEvent)
- src/anatomy/types.ts (doc strings)
- src/components/canvas/AnatomyCanvas.tsx (querySelector + delegated click)
- src/styles/index.css (`[data-bone-id]` selectors → `[data-anno-id]`)
- src/domain/species/types.ts + schema/observation.ts (doc strings)
- docs/{ANATOMY-SVG-CONVENTION,ADDING-A-SPECIES,superpowers/specs,plans}.md
- CLAUDE.md + .claude/{memory/learnings,tasks/TODO}.md
- tests/unit/{anatomy.svgConvention,anatomy.svgLoader,components.AnatomyCanvas}.test.tsx
Internal TS type names and field names (Bone, boneId, parseSvgBones,
getBoneIdFromEvent) are kept intentionally — they're the application's
logical shape and the persisted JSON contract. ObservationZone.boneId is
the identifier seen in already-exported PDFs; renaming it would break
re-import of those PDFs. Only the SVG-side attribute names change.
90/90 tests pass, lint clean, build clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
e8c29c1fdf
commit
1109e33383
18 files changed
+308
-308
No files matched your search
@@ -14,8 +14,8 @@ Apply: any polymorphic field with a literal discriminant.
|
||||
|
||||
## LRN-002 | 2026-05-18 | SVG hitbox+visible twin pattern
|
||||
|
||||
Two SVG elements share same data-bone-id: hitbox (pointer-events:all, fill:transparent) + visible (pointer-events:none, colored).
|
||||
Parser groups by data-bone-id → Bone.hitboxEls[], Bone.visibleEls[].
|
||||
Two SVG elements share same data-anno-id: hitbox (pointer-events:all, fill:transparent) + visible (pointer-events:none, colored).
|
||||
Parser groups by data-anno-id → Bone.hitboxEls[], Bone.visibleEls[].
|
||||
Apply: any SVG-based interactive map needing precise click areas.
|
||||
|
||||
---
|
||||
|
||||
@@ -30,7 +30,7 @@
|
||||
- [ ] `src/lib/assert.ts` — already implemented
|
||||
|
||||
### 2b. Anatomy convention parser
|
||||
- [ ] `src/anatomy/svgConvention.ts` — parseSvgBones: walk DOM, group by data-bone-id
|
||||
- [ ] `src/anatomy/svgConvention.ts` — parseSvgBones: walk DOM, group by data-anno-id
|
||||
- [ ] `src/anatomy/svgLoader.ts` — loadSvg: fetch + DOMParser inline
|
||||
- [ ] Tests: valid SVG fixture → bones map; bad SVG → SvgConventionError
|
||||
|
||||
|
||||
Reference in new issue
Block a user