diff --git a/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md b/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md index 53a452fd..0191df1f 100644 --- a/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md +++ b/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md @@ -228,13 +228,10 @@ narrow, `mode.ts:90-92`, `editorBase.ts:44-50`). Resolution, executor's, under t null while hidden, `EditableAnnotations.tsx:256-265`, `useMoveGesture.ts:54-57`); dialogs that confirm an edit (`DeleteDialog`s, the discard confirmation) close without effect when the editor turns read-only, so no editing entry stays usable below 1 024 px (precision 5; today they stay open and still write, level-1 behaviour). -- Width change to read-only, documented limit: the drawing actions of the views section (`ViewDrawing.tsx:47`: - upload phase, cleaning candidate, repair offer with typed geometries, parent drawing choice) own three native modals - (`CleaningDialog`, `RepairDialog`, `ParentDrawingDialog`); hiding an open native modal is not proven safe, so they - unmount as today. Guarantees: a running upload continues and lands (it checks the session only, - `drawingUpload.ts:198-209`); every committed change, the history and the recovery copy are kept; on widening, the - repair offer comes back from the drawing's hint (`ViewDrawing.tsx:77`) and the cleaning choice from a new upload of - the same file. Written in `docs/development/V1-2-6_OWNER_TRIAL.md` (Lot I) and the checkpoint report. +- Width change to read-only, drawing actions of the views section (`ViewDrawing.tsx:47`): superseded by the answer + « Targeted counter-check before code » below (kept hidden, dialogs closed while read-only, one documented limit: + geometries typed inside an open repair dialog). Written in `docs/development/V1-2-6_OWNER_TRIAL.md` (Lot I) and the + checkpoint report. - Not changed: `ConflictDialog` (a save outcome). Lots: B2 (kept edit-only parts, guards, unit tests), H (Chromium: type in each preserved part, cross 1 024 px, no edit control and no focus in a hidden part, widen, values back; a drag across the crossing commits nothing; open delete and discard confirmations close). Plan §2 cites @@ -256,6 +253,38 @@ révision n »; « Enregistré » appears only after the server's save answer (` `draft_last_save.saved_at` formatted, never `Date.now()` or `new Date()`. Tests in Lot E: refusal and network failure → « Enregistré · révision n », editor still mounted; no saved line while the request is in flight; no browser clock read in `saveLine.ts` and `readSaveTime`. +Q: Targeted counter-check before code (2026-11-06, plan-challenger, REMAINING(4), 9 MINOR) / A: [gated 2026-11-06] +fixes, executor's, under the owner's rules (no plan redesign; this answer prevails over the plan lines it names): +- E2E per lot (MAJOR): lots B1, E and F, which change the draft header or `AppLayout`/`MobileDrawer` used by every + shell page, run the whole shell suite (`pnpm db:sandbox e2e-shell`, no filter); the other lots from B1 run every + `apps/app/e2e/shell/editor-*.spec.ts`. « The two sentinels » of plan :362 is struck: :55-59 and this line are the + rule. No sandbox go at B1 → every e2e step waits and the lot is not committed as validated; never on the trial stack + as found, never on DEV. +- Plan text on unmounted forms (MAJOR): CLARIFICATIONS « Unmounted forms » prevails over plan :76-78, :145-146, + :164-168 and :646-647. Lot B2 adds to its files: `general/CategoriesSection.tsx`, `references/ReferenceForm.tsx` + (via the panel), `annotations/sections/{RegionsSection,ViewsSection}.tsx`, `views/{DetailViewRow,CropEditor, + ViewDrawing}.tsx`, `tabs/{FindingsTab,VerificationTab,AnnotationsTab}.tsx`, `annotations/{EditableAnnotations, + PropertiesPanel}.tsx`, `DeleteDialog.tsx`, the discard confirmation, `editor/useViewport.ts`, the route; its unit + tests add, per preserved part: type, switch to read-only, no edit control in the accessibility tree, switch back, + value back. Lot H (plan :519-520) checks that the values come back, not only « unsaved kept ». +- Ids in read-only (MAJOR): an edit part kept hidden beside a read-only twin never shares an id with it: the read-only + twins (`CropValues`, the read-only body's `PropertiesPanel` and fields) take an id prefix of their own; the B2 + unique-id test also runs in read-only after a crossing, every place visited, a crop group open. +- Drawing actions (MAJOR): no longer a documented limit. `DrawingActions` stays mounted and hidden while read-only; + its three dialogs receive their open state (candidate, offer, asking) only while not read-only, so no native modal + is ever open inside a hidden part (`Dialog` mounts the modal only while open, `ModalDialog.tsx:72`) and the upload + phase, a pending cleaning candidate, a repair offer and a parent choice come back on widening; an upload settling + while read-only lands in the live hook. Remaining limit, documented: geometries typed inside an open repair dialog + are lost when it closes on the crossing (the dialog unmounts); the offer itself comes back. +- MINOR fixes: the read-only guard blurs before the hide: the viewport hook runs `commitFocusedField()` in its resize + handler before it changes the tier across 1 024 px, Chromium case « type, no blur, cross 1 024 px → unsaved, copy + written »; a value a field refuses is lost with that refusal (its message kept), stated as such; values a blur does + not commit (region range drafts until « Appliquer », creation drafts, refused values) are kept by the hidden place, + never committed, outside the document, the leave guard and the copy, as in level 1; focus requests go to the + visible annotation body only; « Aller à » another annotation drops a refused « non appliqué » geometry group, the + level-1 rule, kept and stated under choice 12; B2 tests add a click with no focus change (Safari-like) and the + panel closed by its header toggle while a reference field is focused, and the real path: pending creation and a + « Remplacer par un polygone » tracing, then Vérification, then « Aller à » an annotation → kept and focused. ## ACCEPTANCE CRITERIA 1. Four tabs from 1 024 px: Général, Annotations, Constats, Vérification, as an ARIA tablist (arrows, Home/End not @@ -346,8 +375,9 @@ read in `saveLine.ts` and `readSaveTime`. EVIDENCE: pending 21. [added 2026-11-06, owner precaution 2.8] No silent loss of typed input on a 1 024 px crossing or a recovery decision, as resolved in CLARIFICATIONS « Unmounted forms »: the listed edit-only parts kept and hidden while - read-only with their values back on widening, the three guards, the drawing-actions limit documented with its - guarantees; unit tests (B2) and Chromium journeys (H). + read-only with their values back on widening (drawing actions included, their dialogs closed while read-only), + the guards, distinct ids for read-only twins, the repair-dialog limit documented; unit tests (B2) and Chromium + journeys (H), as completed by CLARIFICATIONS « Targeted counter-check before code ». 22. [added 2026-11-06, owner precaution AC7] Save time read with the existing rights only, as resolved in CLARIFICATIONS « Save time rights »: no permission change, refusal or failure → « Enregistré · révision n » with the editor still mounted, nothing shown as saved before the server's answer, no browser clock; tests in Lot E.