From 0dc49debc4cfcb1988dcf339ec0b1619392561a5 Mon Sep 17 00:00:00 2001 From: bchanot Date: Thu, 15 Oct 2026 00:43:11 +0200 Subject: [PATCH] chore(memory): BDR-052, BDR-053, LRN-056, EVAL-022 (R2 maintenance, R3) --- .claude/memory/decisions.md | 12 ++++++++++++ .claude/memory/evals.md | 7 +++++++ .claude/memory/learnings.md | 10 ++++++++++ 3 files changed, 29 insertions(+) diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index b844dc51..de3b100c 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -406,3 +406,15 @@ Status: active; R2 delivered on feature/rust-r2-domain-core, awaiting owner vali Owner refused U+FFFD replacement of lone surrogate escapes (silent alteration of historical user data). Chosen (owner, 2026-10-14): refusal + quarantine. `js::parse_json` no pre-pass; serde_json refuses escape like any error; failure classified by strict escape scan (on failure only) → `JsonReadError::LoneSurrogate` → closed kind `lone_surrogate` (parse_input, sheet.check, draft.restore, archive.import). App: draft → `osteo:quarantine:draft` verbatim + existing `editor.draft_quarantined`; session archive → `osteo:quarantine:archive`; import → `ImportError('lone_surrogate')` + new `home.import.error_lone_surrogate` (owner-chosen detailed wording FR/EN, file untouched); editor action → refused, report unchanged, `core.action_failed`; publish gate → `invalid_shape`. Oracles untouched: L1 cases now assert TS kept surrogate + Rust refuses; test loader spells lone escapes out as literal text (never U+FFFD). Alt rejected: faithful preservation (own JSON reader + lossless WTF-16 string type over ~150 contract fields + serialiser, oracles re-frozen; multi-day, for corrupted/pasted-UTF-16 data only; door stays open since nothing is lost); in-band tunnel (placeholder code points mapped back at facade output; collisions with sheet strings, UTF-16 length drift, every output path must be post-processed: hacky). Status: active; merged with R2. + +## BDR-052 | 2026-10-14 | R2 maintenance: held session texts, resolution panel, save-failure banner + +Owner rule: no user data removed/overwritten implicitly when save or quarantine fails. Owner UI choice (AskUserQuestion): resolution panel in editor (download exact copy, delete permanently w/ confirmation, open adapted version w/ confirmation for pre-rebase draft, retry); New report / Import refused while held → alert + panel; storage-full banner on refused draft (or archive) write; set-aside texts UI = later. Code: occupied quarantine slot never replaced; draft+archive pair set aside together (rollback own copy); restore returns `held`, opens nothing; mirror writes only on report change; new session reads unread draft via core first (unreadable → set aside, readable → replaced as before); reset no-op without open report. rustls 0.23.46 (4 advisories, none reachable); `supabase/.temp/cli-latest` untracked. +Alt rejected: dropping held texts after warning (owner rule); multi-slot quarantine (scope); refusing every New report over an unread readable draft (behaviour change, not asked). +Status: closed (merged aab61c2). + +## BDR-053 | 2026-10-15 | R3 design: one Rust SVG reader, constant canvas op, highlight unexposed, declared stricter rules + +Plan rev 2 after 3 challengers (32 findings). Reader = prescan (markup state machine, caps before parse: 2 MiB, BOM, DOCTYPE, depth 64, 20k elements, attrs 256/100k, 16 xmlns, raw `<` 100k `=` 200k) → roxmltree 0.21.1 → own tree (qualified names as written, TS allowlist parity) → allowlist + declared extras (SVG ns only, comments dropped, text only title/desc ≤ 4 KiB, root without class/style/transform/filter/mask/clip-path, id grammar, href/url( local only after ASCII/CSS whitespace) → reference graph (cycles refused, expansion ≤ 50k) → serialiser (control whitespace as char refs, output ≤ 4 MiB). Product drawing with any removal refused at load (LRN-055). Facade: only `view.canvas {viewId}` (stateless, memoised per view; data-state still restyled in place). Highlight composition = core fn proven vs TS (O3), no facade op until R4 (snapshot-based call). Behaviour = code where ANNOTATION-RENDERING.md differed (doc rewritten first). Canvas failure → existing degraded notice + retry. +Alt rejected: roxmltree alone with nodes_limit (recursion overflows wasm stack, measured); `svg.sanitize` / `view.highlighted` ops now (no consumer, wrong source for R4); states in the canvas op (dead: restyle runs after every build); dangling-ref removal (rendering change); duplicate-id refusal; property tests (no generator crate). +Status: active; R3 awaiting owner validation, not merged. diff --git a/.claude/memory/evals.md b/.claude/memory/evals.md index 70aaa7c1..82fc8e72 100644 --- a/.claude/memory/evals.md +++ b/.claude/memory/evals.md @@ -164,3 +164,10 @@ Method: owner asked to fix L1 (no silent U+FFFD) + prove the 2 approved deletion Result: verifier CONFORME 13/13 (floor 2 = the approved deletions, authorised by REQUEST); security PASS, 6 LOW: wasm-bindgen `&str` would re-encode a raw lone surrogate (unreachable, JSON.stringify callers; documented invariant), `pretty_json` proof op refuses as invalid_json, scanner not string-aware (classification only), newest-only quarantine slot, archive quarantine failure under full storage lets a later reset remove it (pre-existing R2, reported to owner), semgrep partial parse. Final: core 142, Node 915 (app 320, supabase 40, core-wasm 26), PGlite pgTAP 12 files, real stack 446/446, types no drift, check:all green 1 min 32 s, module 1,040,784 B raw / 339,933 B gzip. Anomalies: refusal broke a test loader (oracle file freezes TS outputs with lone escapes) → loader spells escapes out, never normalises (LRN-055); `cargo deny advisories` (warn-only) shows RUSTSEC-2026-0346/0347/0348 on rustls 0.23.45 (worker, none applicable: no brotli, built-in session cache, no ECH) → bump follow-up; `supabase/.temp/cli-latest` tracked by mistake, rewritten by the CLI, restored; `export PATH=…` denied → absolute `~/.cargo/bin/cargo`; first commit with chained `git config` denied → plain commit OK. Action: gitflow finish into develop (owner authorised after L1 + checks), worktree cleanup (BLK-010), R3 summary only. + +## EVAL-022 | 2026-10-15 | R2 maintenance + R3 anatomy core — challengers, oracles, Chromium, verifier ×2, security ×3 + +Method: maintenance: AskUserQuestion for B UI, store rewrite + 27 tests, verifier (11/11, floor false positive on `cli-latest`) + security PASS (4 LOW fixed), check:all, merge. R3: 2 analyzers (facts), plan + 3 challengers (FATAL 3 / FATAL 6 / CONCERNS 4; blocker = roxmltree recursion, which I had measured independently) → rev 2; freeze O1–O6 with TS before any change; Rust reader/layer/compose; mutation checks per oracle test; wasm thresholds in fresh instances; app switch; Chromium DOM + 30 screenshots + perf vs develop baseline; CSP proof on image; verifier CONFORME 11/11; security PASS + MEDIUM (prescan closer desync) → fixed → pass 2 PASS (4M differential docs) + LOW (url whitespace) → fixed. +Result: all oracles green (O2 exact incl. order, O1/O3 tree-equal, 42 hostile + 10 generated declared or equal, 4 product SVGs untouched); Chromium live trees = O1, 30/30 pixel-identical; module 395.5 KB gz (+56); editor 503 vs 476 ms, detail 143 vs 125 ms (CPU ×4); check:all green. +Anomalies: my first prescan had the closer-overlap bug (security caught it, tests did not: corpus lacked overlapped closers); first wasm memory threshold measured leaked sessions (harness artefact) → per-case fresh instance; probe in perf script retained detached nodes (fake leak); `env` and `export` refused by harness → inline env vars; cargo fmt reformat broke python patch anchors ×3 (write whole file or re-read). +Action: owner LAN validation (TEST FONCTIONNEL / TEST GRAPHIQUE), owner decisions (EN trigger name, degraded wording), then merge; R4 not started. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index f9ea986a..b713f73f 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -426,3 +426,13 @@ Apply: R3/R4/R5 ports (same oracle stack), any wasm loaded by Vite, any agent fa Context: R2 rewrote lone surrogate escapes to U+FFFD before serde_json so JS-era texts still parsed (L1). Owner refused: silent change of historical data. Fix: drop pre-pass; serde_json already refuses; scan text only after failure to name kind (zero cost on valid input, exact refusal kind for UI message + quarantine). Trap found by fix: oracle file freezing TS outputs carried lone escapes → whole-file parse failed; test loader must spell escapes out as literal text (evidence kept), never re-normalise. Also: `u32::from_str_radix` accepts leading `+` → escape scanner checks hex digits explicitly. Apply: any reader of user data (R3 SVG, R4 PDF reader, R5 pipeline) → refuse with closed kind + keep original, never repair silently; a leniency step needs explicit owner decision and declared-difference test. + +## LRN-056 | 2026-10-15 | XML parser recursion, prescan closers, URL/CSS whitespace: three traps porting an SVG sanitiser + +- roxmltree 0.21.1 recurses per nesting level (parse_element ↔ parse_content); 1 MiB wasm stack overflows between 1,000 and 3,000 levels; nodes_limit checked too late. Measure parser depth on the real stack size before trusting "iterative" claims (plan rev 1 said iterative: false). Fix = own markup prescan before any parse; fixed release only in unreleased git. +- A prescan must search each closer AFTER its whole opener (`-->` from +4, `]]>` from +9, `?>` from +2): searching from +1 let `` desync scanner vs XML grammar and hide 5,000 levels (security audit MEDIUM). Prove with differential fuzz vs the real parser (auditor ran ~4M docs) + calibrated small-stack run. +- Locality of `href` / `url(#…)` must follow the browser's parsers: URL parser strips only C0+space, CSS tokenizer only space/tab/newline. JS `trim()`/`\s` include NBSP/ideographic/BOM → `\u00A0#a` passes as local, resolves as relative URL. TS engine has the same flaw (declared difference). +- Mutation checks on oracle tests find blind spots: namespace check mutant passed until a rebound-prefix corpus case was added. +- vitest/React: effect with per-render deps (useT closure) + setState(new array) → infinite render loop (OOM); guard side-effectful restore per attempt with a ref. +- Visual parity: freeze happy-dom trees + Chromium screenshots BEFORE switch; same-build double capture gives the noise floor (30/30 identical); synthetic controls validate the comparator; baseline = `git archive develop` built in scratchpad (no worktree). +Apply: R4 PDF reader/writer (byte scanners, inflate), Step 13 uploads (reader in worker child), any parser fed untrusted input.