diff --git a/.claude/audits/MVP-QA.md b/.claude/audits/MVP-QA.md new file mode 100644 index 00000000..2fa4edb0 --- /dev/null +++ b/.claude/audits/MVP-QA.md @@ -0,0 +1,154 @@ +# MVP — Manual QA Log + +**Date:** 2026-05-18 +**Phase:** 23.2 — Final manual QA pass before delivery +**Status:** NOT EXECUTED THIS SESSION + +## Context + +Automated browser walkthrough (`pnpm dev` + click-through) was **deliberately +skipped** in the `/init-project` session that produced the MVP. The session +spawned a non-interactive implementation agent, so a live browser dogfood was +out of scope. + +Everything below is the **expected behaviour checklist** distilled from the +plan (phase 23.2, steps 1.x). Each item is `[ ]` (untested) and must be +verified manually before declaring the MVP shippable. + +To run the walkthrough: + +```bash +pnpm dev +# open http://localhost:5173 +``` + +Then tick each box, annotate with PASS / WARN / FAIL, and capture screenshots +into `.claude/audits/screenshots/` if anything is off. + +--- + +## Checklist + +### Home screen + +- [ ] Home shows brand name, tagline, and both CTAs ("Nouveau bilan", + "Importer un PDF"). +- [ ] Brand text matches `VITE_APP_BRAND_NAME` / `window.__APP_CONFIG__.brandName` + when set, otherwise defaults to "Osteo Report". +- [ ] Tagline matches `VITE_APP_TAGLINE` / runtime config or default. + +### New-report flow + +- [ ] Click "Nouveau bilan" → navigates to `/new`. +- [ ] Practitioner section is **prefilled** if a previous report was cached + (localStorage `osteo:practitioner:v1`). +- [ ] Animal section is empty. +- [ ] Submit → navigates to `/editor`. + +### Editor — anatomy canvas + +- [ ] Editor loads the Horse main SVG without console errors. +- [ ] Zones are clickable (cursor change on hover). +- [ ] Clicking a non-spine zone toggles its visible state to `current` + (bright color). +- [ ] Clicking a spine zone (e.g. cervical / thoracic / lumbar / sacral) ALSO + opens the `VertebraPicker`; "Valider" stores the precise vertebra list. +- [ ] Clicking the head zone opens the `DetailModal` with the head detail SVG. +- [ ] Clicking inside the DetailModal adds detail zones to the current + observation. + +### Multi-observation behaviour + +- [ ] Add a second observation via "+ Nouvelle observation". +- [ ] Zones from the first observation now show the `linked` (muted) state + on the main canvas while the new observation is empty. + +### Pathology + free text + +- [ ] `PathologyPicker` shows only entries whose `appliesToZones` matches the + current observation's zones (or is empty/wildcard). +- [ ] `FreeTextPathologyInput` adds free-text chips. +- [ ] Removing a chip removes the pathology from the observation. + +### Severity + comment + +- [ ] Severity slider (0–10) is editable and the value is reflected in state. +- [ ] Comment textarea is editable and persists across observation switches. + +### Conclusion + recommendations + next RDV + +- [ ] Conclusion textarea editable. +- [ ] Recommendations textarea editable. +- [ ] "Prochain RDV" date picker editable, accepts ISO date. + +### PDF export + +- [ ] Click "Exporter en PDF" → file `bilan--.pdf` + downloads. +- [ ] Open the PDF in a viewer: + - [ ] Cover page shows brand header, tagline, practitioner block, animal + block, report date, conclusion. + - [ ] One observation page per observation, each with rasterized colorized + SVG + summary text. + - [ ] Footer on every page shows brand name + page X / Y. + +### PDF import (roundtrip) + +- [ ] On Home, click "Importer un PDF" → file picker. +- [ ] Pick the PDF just exported → editor reopens with full report state + restored (zones, pathologies, severity, conclusion, etc.). +- [ ] Now pick a random non-Osteo PDF → French ImportError shown + (no crash, no partial state). + +--- + +## Findings + +> Per-row: PASS / WARN / FAIL + note. +> **Currently all rows: NOT TESTED — automated browser QA out of scope for +> /init-project session. Verify manually via `pnpm dev` before delivery.** + +| # | Section | Result | Note | +|---|--------------------|--------|------| +| 1 | Home | TODO | Run `pnpm dev`, take screenshot. | +| 2 | New-report flow | TODO | Verify localStorage prefill path. | +| 3 | Canvas (zones) | TODO | Confirm DetailModal + VertebraPicker. | +| 4 | Multi-obs states | TODO | Confirm `linked` colour. | +| 5 | Pathology + free | TODO | Confirm zone filter. | +| 6 | Severity + comment | TODO | Confirm persistence across switches. | +| 7 | Conclusion + RDV | TODO | Confirm date picker. | +| 8 | PDF export | TODO | Open downloaded PDF in viewer. | +| 9 | PDF import | TODO | Roundtrip + non-osteo rejection. | + +--- + +## Automated coverage already in place + +| Surface | Where | +|------------------------------|------------------------------------------------| +| Schemas (Zod parse + reject) | `tests/unit/schema.*.test.ts` | +| Anatomy parser (real + fake) | `tests/unit/anatomy.*.test.ts` | +| Report store CRUD/mirror | `tests/unit/state.reportStore.test.ts` | +| Practitioner cache | `tests/unit/state.practitionerCache.test.ts` | +| Draft mirror | `tests/unit/state.draftMirror.test.ts` | +| VertebraPicker UI | `tests/unit/components.VertebraPicker.test.tsx`| +| PathologyPicker UI | `tests/unit/components.PathologyPicker.test.tsx`| +| AnatomyCanvas | `tests/unit/components.AnatomyCanvas.test.tsx` | +| PDF attachment + roundtrip | `tests/unit/pdf.*.test.ts` | + +Total: **88 / 88 passing** as of 2026-05-18. + +## CI gate + +``` +pnpm lint ✅ +pnpm typecheck ✅ +pnpm test:run ✅ (88 tests) +pnpm build ✅ +``` + +Docker image build (`docker build -t osteo-report:dev .`) was **skipped** +because the Docker daemon is not available in this session. The +`docker/entrypoint.sh` script was reviewed and `index.html` was patched to +load `/env.js` before the Vite bundle, with a stub `public/env.js` so local +dev does not 404 — runtime container writes the real `env.js` at start.