From 0aa0f6bc628a8f331fd335638edba4a69b0fd962 Mon Sep 17 00:00:00 2001 From: bchanot Date: Thu, 19 Nov 2026 15:44:25 +0100 Subject: [PATCH] docs(docs): rev 4 gate figures and the amended held-reason criterion --- .../contracts/2026-11-17-v1-2-6-u2-implementation.md | 8 ++++++++ .claude/tasks/plans/2026-11-17-v1-2-6-u2.md | 3 +++ docs/development/V1-2-6_OWNER_TRIAL.md | 4 ++-- docs/development/V1-2-6_UX_TESTS.md | 4 ++-- 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.claude/tasks/contracts/2026-11-17-v1-2-6-u2-implementation.md b/.claude/tasks/contracts/2026-11-17-v1-2-6-u2-implementation.md index 9078c535..23067251 100644 --- a/.claude/tasks/contracts/2026-11-17-v1-2-6-u2-implementation.md +++ b/.claude/tasks/contracts/2026-11-17-v1-2-6-u2-implementation.md @@ -340,6 +340,14 @@ focus hold) close criteria 2 and 6's open rulings. The plan's rev 4 rulings bind 30. **Why redo is held (point 6).** A held « Refaire » (pending work) and a held « Défaire » or « Refaire » (creation) carry an `aria-describedby` reason; a press on a held button shows that reason in the message line without any shift; other disabled causes unchanged; axe passes on the held state. + Amended at the final review (controller ruling, 2026-11-19; ledger « Final fix »): a reason shows only when + removing its cause would make the button usable (« Refaire » with something to redo, « Défaire » with something + to undo); a press on « Défaire » while work is pending cancels it without committing it, by mouse, touch and + keyboard, so the redo stack is kept (rule R-13); a held press does nothing else, on any tab. Texts: + « Refaire est suspendu pendant la modification en cours : annulez-la avec Défaire pour pouvoir refaire. », + « Refaire est suspendu pendant une création : abandonnez-la pour pouvoir refaire. », « Indisponible pendant + une création : créez l'annotation ou abandonnez-la. » (English pairs in `en.ts`). Where the reason appears on a + tablet is the owner's decision at the trial (measured: the message line is below the fold at the three sizes). 31. **Follow-ups and gates (rev 4).** TODO carries the rights paging, the catalogue progressive loading and the passwords requirement; §4.17 is rewritten for points 1 to 6 with the accepted behaviours moved out of the choices to judge; criteria 22 and 23 are met again on the final head (check:all, the shell suite without diff --git a/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md b/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md index 821b48ec..1deb9456 100644 --- a/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md +++ b/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md @@ -1610,6 +1610,9 @@ message API), `i18n/{fr,en}.ts`, unit and e2e tests. - The stale comment at `HistoryButtons.tsx:83` is fixed. - [ ] Steps: failing tests, FAIL, implement, gates (axe on the held state), commit `feat(editor): say why redo is unavailable during pending work`. +- Superseded at the final review (contract criterion 30, amendment of 2026-11-19): the pending-work text above was + false advice (a commit clears the redo stack); the texts, the « reason only when it helps » rule and « Défaire » + cancelling pending work are in the contract. ### Task 16: Documents, TODO, gates and the owner checkpoint (rev 4) diff --git a/docs/development/V1-2-6_OWNER_TRIAL.md b/docs/development/V1-2-6_OWNER_TRIAL.md index c9adb434..da10f474 100644 --- a/docs/development/V1-2-6_OWNER_TRIAL.md +++ b/docs/development/V1-2-6_OWNER_TRIAL.md @@ -794,8 +794,8 @@ Tablette en paysage (au moins 1 024 px de large ; en dessous, l'éditeur est en de suite et cache l'en-tête : prenez « Zone »), puis donnez le focus à « Refaire » puis à « Défaire » : un lecteur d'écran lit la raison. Appuyez dessus : la raison s'affiche sous le dessin et rien d'autre ne se passe. Puis « Annuler le tracé », reprenez l'outil « Sélectionner et déplacer », déplacez le point par deux flèches sans - valider et cliquez « Refaire » à la souris : la raison s'affiche, la série reste en attente. Cliquez « Défaire » : la série est annulée, et « Refaire » remet le - déplacement d'un pas. Sans rien à refaire, « Refaire » reste grisé sans phrase. + valider et cliquez « Refaire » à la souris : la raison s'affiche, la série reste en attente. Cliquez + « Défaire » : la série est annulée, et « Refaire » remet le déplacement d'un pas. Sans rien à refaire, « Refaire » reste grisé sans phrase. #### Acceptés pendant la construction Vous avez accepté ces quatre comportements ; ils ne sont plus à juger : diff --git a/docs/development/V1-2-6_UX_TESTS.md b/docs/development/V1-2-6_UX_TESTS.md index cc86d1af..152f1391 100644 --- a/docs/development/V1-2-6_UX_TESTS.md +++ b/docs/development/V1-2-6_UX_TESTS.md @@ -50,7 +50,7 @@ Implemented (contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`) ## U2 · Points and polygons -Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head: figures to be filled at the final gate run (the 2026-11-18 figures on 15b23f8 are in plan Task 10 and no longer describe the code). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`). +Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head, 2026-11-19 (code at 448a17ef, this page's figures added after): `pnpm check:all` exit 0; the shell suite without `editor-equine.spec.ts` 326 passed, 18 failed, 5 not run, the failures being the admin, catalogue-integrity, catalogue and admin-sheets-list tests that fail the same way before U2 (sandbox data), plus one `editor-signout.spec.ts` « Page crashed » that passes alone and four times repeated; both opt-in measures rerun (figures in the Performance row). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`). | Kind | Tests | |---|---| @@ -63,7 +63,7 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards ` | Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; « + » inserts and Backspace removes on a focused vertex, Backspace after an undo acts on the same focused handle; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series | | Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) | | Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Retirer le sommet {n} de {nom} », the handle group « Sommets de {nom} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) | -| Performance | commit latency under the 500 ms budget for drag, insert and remove, a measure run by hand at the gates (`e2e/support/measure-commit.ts`, `editor-measure-commit.spec.ts`, `MEASURE_COMMIT=1`) on a run-seeded equine-sized draft, never on the historical copy nor through `editor-equine.spec.ts`. Measured 2026-11-18 on a production build under `vite preview`, Chromium mouse at 1 280 px, CPU ×4, from the release to the painted frame showing the new geometry with the undo entry; on the final code (15b23f8): median / max drag 174.7 / 202.1 ms, « + » 175.1 / 178.3 ms, « − » 169.7 / 182.2 ms (three runs each; earlier figures in plan Task 10); the drag smoothness is a measure, not an assertion (`e2e/support/measure-drag.ts`, `editor-measure-drag.spec.ts`, run by hand). Measured 2026-11-18 on a production build under `vite preview`, Chromium touch at 1 180 px, CPU ×4: frame work p95 3.9 to 4.5 ms with the loupe (technique A, final code 15b23f8; 4.2 to 4.7 ms before), 4.0 to 4.4 ms outline only (B), 3.6 to 4.2 ms without a loupe; technique A kept. The figures are in plan Task 8; the owner's tablet trial is the real check | +| Performance | commit latency under the 500 ms budget for drag, insert and remove, a measure run by hand at the gates (`e2e/support/measure-commit.ts`, `editor-measure-commit.spec.ts`, `MEASURE_COMMIT=1`) on a run-seeded equine-sized draft, never on the historical copy nor through `editor-equine.spec.ts`. Measured 2026-11-18 on a production build under `vite preview`, Chromium mouse at 1 280 px, CPU ×4, from the release to the painted frame showing the new geometry with the undo entry; on the final code (448a17ef, 2026-11-19): median / max drag 179 / 206 ms, « + » 183 / 187.8 ms, « − » 178.6 / 179 ms (three runs each; 15b23f8 and earlier figures in plan Task 10); the drag smoothness is a measure, not an assertion (`e2e/support/measure-drag.ts`, `editor-measure-drag.spec.ts`, run by hand). Measured 2026-11-18 on a production build under `vite preview`, Chromium touch at 1 180 px, CPU ×4: frame work p95 3.9 to 4.5 ms with the loupe (technique A, final code 15b23f8; 4.2 to 4.7 ms before), 4.0 to 4.4 ms outline only (B), 3.6 to 4.2 ms without a loupe; technique A kept. Rerun on 448a17ef (2026-11-19, same setup): touch with the loupe, handler to frame median 3.6 ms, p95 5.1 ms (event to frame median 27 ms, p95 33.6 ms); mouse, handler to frame p95 3.9 ms. The figures are in plan Task 8; the owner's tablet trial is the real check | ## U3 · Category panel and own colour