From 049d5146b4d79b204e6da019e4d916fa409b8da8 Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 6 Nov 2026 17:47:55 +0100 Subject: [PATCH] chore(docs): U1 contract, re-check REMAINING(1) fixes Dialogs of kept parts open only in edit mode in a visible place; ids rule for both annotation bodies; kept parts mount at first edit render; repair geometries lifted; N2, N4, N6, N7 stated. --- .../contracts/2026-11-06-v1-2-6-ux-u1-1123.md | 28 +++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md b/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md index 0191df1f..22e29155 100644 --- a/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md +++ b/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md @@ -285,6 +285,29 @@ fixes, executor's, under the owner's rules (no plan redesign; this answer prevai level-1 rule, kept and stated under choice 12; B2 tests add a click with no focus change (Safari-like) and the panel closed by its header toggle while a reference field is focused, and the real path: pending creation and a « Remplacer par un polygone » tracing, then Vérification, then « Aller à » an annotation → kept and focused. +Q: Re-check of those fixes (2026-11-06, fresh plan-challenger, REMAINING(1), 7 MINOR) / A: [gated 2026-11-06] +fixes, executor's (prevail over the answers above where they differ): +- Dialogs in hidden places (MAJOR N1): a dialog of a kept part receives its open state only while editing AND its + place is visible (`!readOnly && usePlaceVisible()`), so an offer that settles while the views section is hidden + (left during an upload) or a widening on another tab never opens a native modal inside a hidden subtree; the dialog + opens when the section is shown again. `DeleteDialog` and the discard confirmation close through `onClose`, never + withheld. B2 test: an offer settling with the section hidden, and a widening on another tab, leave `dialog[open]` at + 0 until « Gérer les vues ». +- N2: on a crossing, a withheld dialog stays modal for its exit animation (0.15-0.18 s, `Dialog.tsx:47-61`) and its + unmount returns focus inside the editor; stated; H waits for a dialog count of 0 (LRN-111) before checking focus. +- N3: the general rule: anything rendered in both annotation bodies (properties panel and fields, overview panel and + its « Filtrer par nom », selection tag, test ids) takes the body's prefix or a `useId` id; the e2e helper scopes to + the visible body; the unique-id test runs with nothing selected and with a selection, in edit and after a crossing. +- N4: the split, stated and tested: a field that switches in place to its read-only value (`TextField.tsx:31-40`) + loses a value its commit refuses (message kept); a field inside a kept part keeps it. +- N5: a kept part mounts at its first edit-mode render and is kept from then on; a page opened read-only (narrow, + recovery pending, rights, frozen, inactive, historical) mounts no edit part, so the recovery bullet holds; test: a + page opened narrow has no edit body. +- N6: level-1 behaviour stated in the limits: an upload in flight when the editor turns read-only still attaches its + drawing (`drawingUpload.ts:184-191`, a commit the store accepts in narrow mode, an unsaved change); B2 test. +- N7: B2's files add `annotations/AnnotationFields.tsx` and `references/ReferencesPanel.tsx`. +- N8: the repair-dialog limit is removed: `geometries` moves from `RepairForm` into `RepairDialog`, keyed on the + offer, so typed repair geometries survive the crossing like the other kept values (`views/RepairDialog.tsx`, B2). ## ACCEPTANCE CRITERIA 1. Four tabs from 1 024 px: Général, Annotations, Constats, Vérification, as an ARIA tablist (arrows, Home/End not @@ -376,8 +399,9 @@ fixes, executor's, under the owner's rules (no plan redesign; this answer prevai 21. [added 2026-11-06, owner precaution 2.8] No silent loss of typed input on a 1 024 px crossing or a recovery decision, as resolved in CLARIFICATIONS « Unmounted forms »: the listed edit-only parts kept and hidden while read-only with their values back on widening (drawing actions included, their dialogs closed while read-only), - the guards, distinct ids for read-only twins, the repair-dialog limit documented; unit tests (B2) and Chromium - journeys (H), as completed by CLARIFICATIONS « Targeted counter-check before code ». + the guards, distinct ids for read-only twins, dialogs open only in edit mode in a visible place, kept parts mounted + from the first edit-mode render; unit tests (B2) and Chromium journeys (H), as completed by CLARIFICATIONS + « Targeted counter-check before code » and « Re-check of those fixes ». 22. [added 2026-11-06, owner precaution AC7] Save time read with the existing rights only, as resolved in CLARIFICATIONS « Save time rights »: no permission change, refusal or failure → « Enregistré · révision n » with the editor still mounted, nothing shown as saved before the server's answer, no browser clock; tests in Lot E.