fix(editor): final review fixes (touch undo guard, focus, save line)
Important 1: a touch press fires pointer leave between up and click; only a mouse leave (or a pointer cancel) forgets the refused field, so Annuler no longer undoes an unrelated change. Important 2: the LAN spec reads the revision before the attach, through shownRevision, which throws instead of NaN (spec stays not run). Minor 1: refocusIfHidden refocuses a still shown element the commit blurred (references search on a 1 024 px crossing). Minor 2: discardChanges keeps lastSave (reload path still drops it). Minor 3: the overview filter term lives in UiState / the read-only twin, not the card. Minor 4: categories section drops its inner h3 and the unused editor.general.categories keys. AC8: badge test. Assertions rewritten or added (R-24): - editor-tabs-general « Général no longer holds the categories editor »: queryByText of the deleted heading (now vacuous) -> queryByLabelText of the category name fields. - editor-focus-request « Annotations: selects the annotation »: findAllByText /anno-b|Sélection/ -> the properties panel holds Centre x = 20 (anno-b) and owns the focused heading. - editor-shell-layout panel walk: added after.at(-1) === 'side'. - editor-recovery title « Annuler les modifications » -> « Abandonner ». - new: touch/cancel/mouse press, references search crossing, discard keeps lastSave, filter kept, one categories heading, badge 1/2/0, shownRevision.
This commit is contained in:
1 parent
942d52a835
commit
0467885527
22 files changed
+327
-38
No files matched your search
@@ -171,7 +171,7 @@ describe('restore', () => {
|
||||
expect(node).toMatchObject({ reference_ids: [], children: [], review_status: 'inherited' })
|
||||
})
|
||||
|
||||
it('takes the reload path for « Annuler les modifications » under staleBase', async () => {
|
||||
it('takes the reload path for « Abandonner les modifications » under staleBase', async () => {
|
||||
seed(movedText(10), 2)
|
||||
await openReady({ revision: 5 })
|
||||
await store.getState().restoreCopy()
|
||||
@@ -182,6 +182,19 @@ describe('restore', () => {
|
||||
expect(storedCopy()).toBeNull()
|
||||
})
|
||||
|
||||
it('keeps `lastSave` on a plain discard, drops it on the reload path', async () => {
|
||||
await openReady({ revision: 3 })
|
||||
const saved = { revision: 3, savedAt: '2026-11-04T13:32:00Z' }
|
||||
store.setState({ lastSave: saved })
|
||||
commitMove(40)
|
||||
expect(await store.getState().discardChanges({ confirmed: true })).toEqual({ ok: true })
|
||||
expect(store.getState().lastSave).toBe(saved)
|
||||
store.setState({ staleBase: true })
|
||||
serverHas(baseText(), 6)
|
||||
await store.getState().discardChanges({ confirmed: true })
|
||||
expect(store.getState().lastSave).toBeNull()
|
||||
})
|
||||
|
||||
it('reports a copy the core refuses, keeps it, blocks editing until ignored', async () => {
|
||||
sessionStorage.setItem(
|
||||
copyKeyOf(),
|
||||
|
||||
Reference in new issue
Block a user