fix(editor): final review fixes (touch undo guard, focus, save line)

Important 1: a touch press fires pointer leave between up and click; only a
mouse leave (or a pointer cancel) forgets the refused field, so Annuler no
longer undoes an unrelated change. Important 2: the LAN spec reads the
revision before the attach, through shownRevision, which throws instead of NaN
(spec stays not run). Minor 1: refocusIfHidden refocuses a still shown element
the commit blurred (references search on a 1 024 px crossing). Minor 2:
discardChanges keeps lastSave (reload path still drops it). Minor 3: the
overview filter term lives in UiState / the read-only twin, not the card.
Minor 4: categories section drops its inner h3 and the unused
editor.general.categories keys. AC8: badge test.

Assertions rewritten or added (R-24):
- editor-tabs-general « Général no longer holds the categories editor »:
  queryByText of the deleted heading (now vacuous) -> queryByLabelText of the
  category name fields.
- editor-focus-request « Annotations: selects the annotation »: findAllByText
  /anno-b|Sélection/ -> the properties panel holds Centre x = 20 (anno-b) and
  owns the focused heading.
- editor-shell-layout panel walk: added after.at(-1) === 'side'.
- editor-recovery title « Annuler les modifications » -> « Abandonner ».
- new: touch/cancel/mouse press, references search crossing, discard keeps
  lastSave, filter kept, one categories heading, badge 1/2/0, shownRevision.
This commit is contained in:
bchanot committed 2026-11-09 12:19:32 +01:00
1 parent 942d52a835
commit 0467885527
22 files changed
+327 -38

No files matched your search

@@ -20,6 +20,8 @@ export interface UiState {
serial: number
tracing: Tracing | null
hint: string | null
/** The overview's « Filtrer par nom » term: it outlives a selection, not a view. */
filter: string
}
export type UiAction =
@@ -33,6 +35,7 @@ export type UiAction =
| { type: 'trace_add'; point: Point }
| { type: 'trace_cancel' }
| { type: 'hint'; hint: string | null }
| { type: 'filter'; term: string }
export const initialUi: UiState = {
viewId: null,
@@ -42,6 +45,7 @@ export const initialUi: UiState = {
serial: 0,
tracing: null,
hint: null,
filter: '',
}
const TOOL_OF: Record<Tracing['target'], ToolId> = {
@@ -108,5 +112,7 @@ export function uiReducer(state: UiState, action: UiAction): UiState {
return { ...state, tracing: null, hint: null }
case 'hint':
return { ...state, hint: action.hint }
case 'filter':
return { ...state, filter: action.term }
}
}
+6 -2
View File
@@ -140,10 +140,14 @@ export function heldElement(): HTMLElement | null {
/**
* After the render that hides parts: `held` (taken before) that left the page or sits in a
* hidden part hands its focus to the shown tab. An element still visible keeps its place.
* hidden part hands its focus to the shown tab; one still shown gets its focus back when
* the commit blurred it (never `body`), and the tab takes it if the element refuses.
*/
export function refocusIfHidden(held: HTMLElement | null): void {
if (held && (!held.isConnected || held.closest('[hidden]'))) focusActiveTab()
if (!held) return
const gone = !held.isConnected || held.closest('[hidden]')
if (!gone && document.activeElement !== held) held.focus()
if (gone || document.activeElement !== held) focusActiveTab()
}
/**
+7 -3
View File
@@ -208,8 +208,9 @@ function applyReload(
}
/**
* « Annuler les modifications » (confirmed): back to the saved text; with `staleBase` the
* server draft is reloaded instead (the saved text is an older revision's).
* « Abandonner les modifications » (confirmed): back to the saved text, which is the save
* `lastSave` describes, so the save line keeps it; with `staleBase` the server draft is
* reloaded instead (the saved text is an older revision's).
*/
export async function discardChanges(
api: StoreApi,
@@ -228,6 +229,9 @@ export async function discardChanges(
: { ok: false, reason: 'blocked', kind: 'not_ready' }
}
removeCopy(state.userId ?? '', state.versionId ?? '')
api.set(reloadPatch(state, state.savedText, replaced.state, state.savedRevision))
api.set({
...reloadPatch(state, state.savedText, replaced.state, state.savedRevision),
lastSave: state.lastSave,
})
return { ok: true }
}