fix(app): sheet creation form only for editors; review findings (V1-2.5 K)

Verifier C4: /app/admin/sheets/new shows Accès non autorisé without sheet_editor (display rule, server unchanged), tests. Security: M7 restates get_sheet_version grants; e2e enrolment check never prints the setup key. Contract clarifications: phone skips, run evidence, one intermittent e2e failure tracked.
This commit is contained in:
bchanot committed 2026-11-02 18:18:54 +01:00
1 parent 3d2b5a5f1c
commit 02625a76b6
5 files changed
+46 -3

No files matched your search

+2 -1
View File
@@ -113,7 +113,8 @@ async function enrolFromPage(
box.getByRole('img', { name: dict['mfa.enrol.qr_alt'] }),
).toBeVisible()
const secret = (await box.locator('code').textContent())?.trim() ?? ''
expect(secret).toMatch(/^[A-Z2-7]{16,}$/)
// A boolean, so a failure report never prints the secret.
expect(/^[A-Z2-7]{16,}$/.test(secret), 'base32 setup key shown').toBe(true)
await enterCode(box, dict, secret)
await expect(page.getByText(dict['mfa.enrol.done'])).toBeVisible()
return secret