fix(app): sheet creation form only for editors; review findings (V1-2.5 K)

Verifier C4: /app/admin/sheets/new shows Accès non autorisé without sheet_editor (display rule, server unchanged), tests. Security: M7 restates get_sheet_version grants; e2e enrolment check never prints the setup key. Contract clarifications: phone skips, run evidence, one intermittent e2e failure tracked.
This commit is contained in:
bchanot committed 2026-11-02 18:18:54 +01:00
1 parent 3d2b5a5f1c
commit 02625a76b6
5 files changed
+46 -3

No files matched your search

@@ -66,3 +66,23 @@ reopened.
The editor (V1-2.6), the review and publication screens (V1-2.7), deprecation and archive actions (V1-2.7),
the equine working copy content work (V1-2.8), any DEV operation (§16.11), recovery runbook rehearsal (V1-2.9).
## CLARIFICATIONS (after the fresh reviews of 2026-11-02 on 3d2b5a5)
- Skips: `apps/app/e2e/shell/admin.spec.ts` skips A0, A1 and S1 on the `chromium-375` project only (three
`test.skip(isPhone(info))`). These journeys run on desktop; every admin page at 375 px is covered by the
unskipped screens test and the access-per-right test. Deliberate, not a reduction.
- C4 gap fixed: `/app/admin/sheets/new` shows « Accès non autorisé » to any account without an active
`sheet_editor` grant (display rule; the server refuses creation anyway); unit tests for a reviewer, a
publisher and an owner without the capability.
- Security MEDIUM fixed: M7 restates the grants of the redefined `get_sheet_version`. LOW fixed: the e2e
enrolment check no longer prints the throwaway setup key on failure.
- Run evidence for the criteria a read-only verifier cannot run (orchestrator runs, sandbox only):
C1 `mfa-behaviour.sandbox.ts` 10/10 (twice by the executor, once on a fresh install); C9 sandbox fresh
install and upgrade from M6, pgTAP 1941 pass, types match (after the fixes: fresh install, 1941 pass, types
match); C11 `pnpm check:all` all checks passed on 4f6c0ba code (= 3d2b5a5 code), `pnpm e2e:shell` 108
passed / 6 skipped (slice J run, and again after the fixes), unit core-wasm 66, supabase 148, app 653.
- Tracked, not fixed: the P1 catalogue journey on `chromium-375` failed once in three full `e2e:shell` runs
(search typed, 8 cards instead of 1, FR and EN in the same run); passed alone twice and in the next full
run; cause not found, page snapshot overwritten. pgTAP 014 (« nine species ») fails on a stack where the
shell suite already ran (test species left behind): run `test-db` before `e2e:shell` on one stack.