From 00936c8c54602a5bfd8f19f1c1125df1db5873ad Mon Sep 17 00:00:00 2001 From: bchanot Date: Thu, 12 Nov 2026 15:21:30 +0100 Subject: [PATCH] docs(app): R1 follow-up, selection tag out of the visual flow --- docs/design/README.md | 9 +++++---- docs/development/BROWSER_TESTS.md | 2 +- docs/development/V1-2-6_OWNER_TRIAL.md | 2 ++ docs/development/V1-2-6_U1_CORRECTIONS.md | 12 +++++++++++- 4 files changed, 19 insertions(+), 6 deletions(-) diff --git a/docs/design/README.md b/docs/design/README.md index fb1220b1..fa8ac48a 100644 --- a/docs/design/README.md +++ b/docs/design/README.md @@ -106,10 +106,11 @@ Accepted deviations (owner 2026-11-02, V1-2.5): the boards stay as approved, not 2. On a phone, « Références » is a plain, non-collapsible card (`03`). Condition: it does not hide the anatomical area (it starts at or below the drawing's bottom, checked at 320 and 375 px). -Accepted deviation (owner 2026-11-12, brief « V1-2.6 — R1 — Dernier retour utilisateur »): board `04`'s -« Sélection : … » tag over the drawing is no longer shown, in the editor and its read-only twin. It was -redundant with the highlight and the side panel, and moved the drawing at each selection change. It stays in -the DOM as screen-reader-only text (`sr-only`, not a live region), so nothing is announced twice. +Accepted deviation (owner 2026-11-12, brief « V1-2.6 — R1 — Dernier retour utilisateur »): the « Sélection : … » +tag of board `04` (and of board `26` of `v1-2-6-r0/`) over the drawing is no longer shown, in the editor and its +read-only twin. It was redundant with the highlight and the side panel, and moved the drawing at each selection +change. It stays in the DOM as screen-reader-only text (`sr-only`, not a live region), so nothing is announced +twice. ## v1-2-6/ — V1-2.6 graphic editor maquettes (validated 2026-11-05) diff --git a/docs/development/BROWSER_TESTS.md b/docs/development/BROWSER_TESTS.md index 3ba03021..ef83c327 100644 --- a/docs/development/BROWSER_TESTS.md +++ b/docs/development/BROWSER_TESTS.md @@ -10,7 +10,7 @@ engines are installed. The suites live in `apps/app/e2e`. | Command | Backend | Dev server | Content | |---|---|---|---| | `pnpm e2e:ui` | none | Vite on `127.0.0.1:5191` | `e2e/ui/dialog.spec.ts`: the D13 contract of the shared Dialog on a test page; `e2e/ui/local-tool.spec.ts`: the disclaimer, edit and replace dialogs on the real local-tool routes | -| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references panel and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the four-tab shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (four tabs, cross-tab undo, typed text then the header undo, a refused field kept through a real Shift+Tab to « Défaire », Ctrl+Z outside and inside a field, « Aller à » for each issue kind, the save line from the count to « Enregistrement… » to the time and revision), `editor-shell-crossing` (every edit-only part typed, a 1 024 px crossing, no edit control and the focus on the shown tab, widening with the values back; the section and the panel open; unsaved work and the recovery copy kept; a drag across the crossing commits nothing; delete and discard confirmations closing; a decision withheld under the panel waiting for « Reprendre »), `editor-shell-layout` (no sideways scroll at 1 024, 1 180, 1 279 and 1 280 px on the four tabs, the sections and the panel, and at 320, 375 and 768 px read-only; axe from the top on every place; the canvas width without and with the panel as `canvas-width` and `canvas-width-panel` annotations; the keyboard order header, tab list, « Défaire », « Refaire », the panel when open, then tools, canvas and side column); the equine spec also times commit to paint with every place visited. Editor accounts, drafts and drawings are prepared by `e2e/support/editor.ts` (a drawing in its stored form, written by the core); `e2e/support/warm-up.ts` is the suite's global setup (the dev server reloads the page once when a route first loads a dependency, so one throwaway session visits the editor routes before the tests). Editing needs 1 024 px: these specs skip the 375 px project | +| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references panel and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting; the drawing's top unchanged when a point, a zone and a link are selected then deselected, on desktop and on the read-only twin at 375 px, with the selection tag out of the visual flow), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the four-tab shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (four tabs, cross-tab undo, typed text then the header undo, a refused field kept through a real Shift+Tab to « Défaire », Ctrl+Z outside and inside a field, « Aller à » for each issue kind, the save line from the count to « Enregistrement… » to the time and revision), `editor-shell-crossing` (every edit-only part typed, a 1 024 px crossing, no edit control and the focus on the shown tab, widening with the values back; the section and the panel open; unsaved work and the recovery copy kept; a drag across the crossing commits nothing; delete and discard confirmations closing; a decision withheld under the panel waiting for « Reprendre »), `editor-shell-layout` (no sideways scroll at 1 024, 1 180, 1 279 and 1 280 px on the four tabs, the sections and the panel, and at 320, 375 and 768 px read-only; axe from the top on every place; the canvas width without and with the panel as `canvas-width` and `canvas-width-panel` annotations; the keyboard order header, tab list, « Défaire », « Refaire », the panel when open, then tools, canvas and side column); the equine spec also times commit to paint with every place visited. Editor accounts, drafts and drawings are prepared by `e2e/support/editor.ts` (a drawing in its stored form, written by the core); `e2e/support/warm-up.ts` is the suite's global setup (the dev server reloads the page once when a route first loads a dependency, so one throwaway session visits the editor routes before the tests). Editing needs 1 024 px: these specs skip the 375 px project | Each suite runs on two Chromium projects: `chromium-desktop` (1280 × 800) and `chromium-375` (375 × 667, mobile viewport, touch). A test tagged `@phone` diff --git a/docs/development/V1-2-6_OWNER_TRIAL.md b/docs/development/V1-2-6_OWNER_TRIAL.md index 9040d1f0..a183ec7e 100644 --- a/docs/development/V1-2-6_OWNER_TRIAL.md +++ b/docs/development/V1-2-6_OWNER_TRIAL.md @@ -256,6 +256,8 @@ vous avez créée dans l'interface. Un clic sur une autre annotation la sélectionne ; un glisser, un panoramique ou un zoom ne désélectionne pas. Sur un écran tactile, un appui bref fait de même, un glisser ou un pincement non. Échap depuis le menu latéral ou l'en-tête de l'application ne fait rien. iOS Safari : à vérifier à la main, non couvert par les tests. + À chaque sélection et désélection, le dessin reste à sa place : aucune étiquette « Sélection : … » ne s'affiche + au-dessus. 4. Références : le bouton « Références » de l'en-tête ouvre un panneau latéral (non modal) avec une recherche sur la citation, le DOI et l'URL (« Rechercher une référence »). Dans « Constats », sélectionnez un constat qui cite une référence : le bouton « n référence(s) » ouvre le même panneau limité à « Citées par « … » (n) », avec « Tout afficher (n) » pour revenir à la liste entière. diff --git a/docs/development/V1-2-6_U1_CORRECTIONS.md b/docs/development/V1-2-6_U1_CORRECTIONS.md index 3e8238cf..cc582cc3 100644 --- a/docs/development/V1-2-6_U1_CORRECTIONS.md +++ b/docs/development/V1-2-6_U1_CORRECTIONS.md @@ -62,7 +62,15 @@ Escape), `bbdfd27` + `a1ee194` (D6b), `ab823f4` + `2327d61` + `0849e54` (browser 180, core-wasm 66; `e2e:ui` 227 passed; `e2e:shell` full suite on the sandbox 197 passed, 4 failed, 99 skipped. Status (owner, 2026-11-12): accepted technically on the report; the owner's manual validation on db:trial is still to do. Decision record BDR-113 (R1 editor only), learnings LRN-128 to LRN-130. The 4 failures are the `admin.spec.ts:717` timeouts (anomaly B, the taken working-copy slot), the same as in -the 188 / 90 / 4 baseline; every new R1 test passed. The criteria below are the contract as written. +the 188 / 90 / 4 baseline; every new R1 test passed. +Follow-up `927537b` (owner brief « V1-2.6 — R1 — Dernier retour utilisateur », 2026-11-12): the « Sélection : … » tag +is screen-reader-only (`sr-only`, not a live region) in the editor and the read-only twin, so the drawing no longer +moves when the selection changes; board `04` (and board `26` of `v1-2-6-r0/`) deviation recorded in +`docs/design/README.md`; one unit test and two layout-stability specs in `editor-deselect.spec.ts` (desktop, +read-only twin at 375 px). Gates on that commit: typecheck, lint, `pnpm test:run` (app 120 files, 1382 tests) green; +`e2e:shell` on `db:sandbox`, six editor specs (deselect, equine, access, annotations, geometry, journey): 37 passed, +37 skipped (other viewport), 0 failed. +The criteria below are the contract as written. - Labels: `editor.history.*` keys in `apps/app/src/i18n/fr.ts` and `en.ts` (FR « Défaire » / « Refaire », names « Défaire la dernière modification » and « Refaire la dernière modification défaite »; EN « Undo » / « Redo » @@ -153,6 +161,8 @@ the 188 / 90 / 4 baseline; every new R1 test passed. The criteria below are the pinch: 1 non-primary pointerdown, 2 pointerup, 0 click, selection kept. A one-finger drag on the read-only twin: 1 pointercancel (the browser pan took the touch), 0 click. iOS Safari is unverified: a manual check is listed in the TODO, it is not a proof. +- The « Sélection : … » tag is not shown (screen-reader-only text, not live): the highlight and the properties panel + carry the selection, and the drawing keeps its place when the selection changes (owner, 2026-11-12). ### R2 — The Références tab (D1 to D4)