CLI 2.1.306 prints an advisory plugin-directory section (ICON_MISSING, blocking: false) that the whole-output `warning` grep counted as a failure. The verdict is now the rc of `claude plugin validate --strict` (per-file warnings → 1, directory advisory never), through one helper shared with a positive control on two scratch manifests.
118 lines
4.6 KiB
Bash
118 lines
4.6 KiB
Bash
#!/usr/bin/env bash
|
|
# lib/tests/mods.test.sh — every mods/<name>/ plugin: the manifest name
|
|
# equals the folder, skills/<name> is the relative loading symlink
|
|
# ../mods/<name>, and (when the CLI offers `claude plugin test`) the mod
|
|
# passes `claude plugin validate --strict` (per-file warnings are errors; the
|
|
# advisory plugin-directory section does not change the exit code) and
|
|
# `claude plugin test`.
|
|
# MODS_ROOT overrides the repo root (fixture controls). Fails when no mod
|
|
# is found, so it can never pass vacuously.
|
|
set -u
|
|
ROOT="${MODS_ROOT:-$(cd "$(dirname "$0")/../.." && pwd)}"
|
|
CLI_TIMEOUT=120
|
|
pass=0; fail=0
|
|
WORK="$(mktemp -d)"; trap 'rm -rf "$WORK"' EXIT
|
|
ok() { pass=$((pass+1)); echo "PASS $1"; }
|
|
ko() { fail=$((fail+1)); echo "FAIL $1"; }
|
|
check() { if [ "$2" = "$3" ]; then ok "$1"; else ko "$1: got[$2] want[$3]"; fi; }
|
|
|
|
# bounded CMD...: stdout+stderr on stdout, rc 124 on timeout.
|
|
bounded() {
|
|
local t
|
|
t=$(command -v timeout || command -v gtimeout || true)
|
|
if [ -n "$t" ]; then "$t" "$CLI_TIMEOUT" "$@" 2>&1; return; fi
|
|
local out rc=0 pid i=0
|
|
out=$(mktemp) || return 1
|
|
"$@" >"$out" 2>&1 & pid=$!
|
|
while kill -0 "$pid" 2>/dev/null && [ "$i" -lt "$CLI_TIMEOUT" ]; do
|
|
sleep 1; i=$((i+1))
|
|
done
|
|
if kill -0 "$pid" 2>/dev/null; then kill "$pid" 2>/dev/null; rc=124
|
|
else wait "$pid" || rc=$?; fi
|
|
cat "$out"; rm -f "$out"; return "$rc"
|
|
}
|
|
|
|
# validate_strict DIR: output in STRICT_OUT, rc of the CLI (124 = timeout).
|
|
validate_strict() {
|
|
STRICT_OUT=$(bounded claude plugin validate --strict "$1")
|
|
}
|
|
|
|
manifest_name() {
|
|
python3 -c 'import json,sys; print(json.load(open(sys.argv[1])).get("name",""))' \
|
|
"$1" 2>/dev/null
|
|
}
|
|
|
|
# cli_unavailable: prints the reason and returns 0 when the capability is missing.
|
|
cli_unavailable() {
|
|
command -v claude >/dev/null 2>&1 || { echo "claude not found"; return 0; }
|
|
local rc=0 out
|
|
out=$(bounded claude plugin test --help) || rc=$?
|
|
[ "$rc" -eq 124 ] && { echo "probe timed out after ${CLI_TIMEOUT}s"; return 0; }
|
|
# An unknown subcommand prints the generic `claude plugin` usage with rc 0:
|
|
# only the command's own usage line proves it exists.
|
|
if [ "$rc" -ne 0 ] || ! printf '%s' "$out" | grep -q 'claude plugin test'; then
|
|
echo "no 'claude plugin test' command"; return 0
|
|
fi
|
|
return 1
|
|
}
|
|
|
|
check_cli() {
|
|
local name="$1" dir="$2" out rc=0
|
|
validate_strict "$dir" || rc=$?
|
|
if [ "$rc" -eq 124 ]; then ko "$name: validate timed out after ${CLI_TIMEOUT}s"
|
|
elif [ "$rc" -ne 0 ]; then
|
|
local detail
|
|
detail=$(printf '%s' "$STRICT_OUT" | grep -E '^(✘|error:|⚠ Found)' \
|
|
| head -2 | tr '\n' ' ')
|
|
detail="$detail (rerun: claude plugin validate --strict $dir)"
|
|
ko "$name: validate --strict rc=$rc: $detail"
|
|
else ok "$name: validate --strict passed"; fi
|
|
rc=0
|
|
out=$(bounded claude plugin test "$dir") || rc=$?
|
|
if [ "$rc" -eq 124 ]; then ko "$name: plugin test timed out after ${CLI_TIMEOUT}s"
|
|
elif [ "$rc" -ne 0 ]; then
|
|
ko "$name: plugin test rc=$rc: $(printf '%s' "$out" | tail -3 | tr '\n' ' ')"
|
|
else ok "$name: plugin test passed"; fi
|
|
}
|
|
|
|
# strict_discriminates: --strict must fail per-file warnings, pass a clean one.
|
|
strict_discriminates() {
|
|
local rc
|
|
mkdir -p "$WORK/warnfix/.claude-plugin" "$WORK/cleanfix/.claude-plugin"
|
|
echo '{"name":"warnfix"}' > "$WORK/warnfix/.claude-plugin/plugin.json"
|
|
echo '{"name":"cleanfix","version":"0.1.0","description":"d",'\
|
|
'"author":{"name":"x"}}' > "$WORK/cleanfix/.claude-plugin/plugin.json"
|
|
rc=0; validate_strict "$WORK/cleanfix" || rc=$?
|
|
if [ "$rc" -eq 124 ]; then ko "strict control: validate timed out"
|
|
else check "strict control: clean fixture passes --strict" "$rc" 0; fi
|
|
rc=0; validate_strict "$WORK/warnfix" || rc=$?
|
|
if [ "$rc" -eq 124 ]; then ko "strict control: validate timed out"
|
|
else check "strict control: per-file warnings fail --strict" "$rc" 1; fi
|
|
}
|
|
|
|
manifests=()
|
|
for m in "$ROOT"/mods/*/.claude-plugin/plugin.json; do
|
|
[ -f "$m" ] && manifests+=("$m")
|
|
done
|
|
if [ "${#manifests[@]}" -eq 0 ]; then ko "no mod found under $ROOT/mods"; fi
|
|
|
|
use_cli=1
|
|
if reason=$(cli_unavailable); then
|
|
use_cli=0
|
|
echo "SKIP: claude plugin test unavailable ($reason) — validate/test not run"
|
|
fi
|
|
[ "$use_cli" -eq 1 ] && strict_discriminates
|
|
|
|
for m in ${manifests[@]+"${manifests[@]}"}; do
|
|
dir="$(dirname "$(dirname "$m")")"; name="$(basename "$dir")"
|
|
check "$name: manifest name matches folder" "$(manifest_name "$m")" "$name"
|
|
link="$ROOT/skills/$name"
|
|
if [ -L "$link" ]; then
|
|
check "$name: loading link target" "$(readlink "$link")" "../mods/$name"
|
|
else ko "$name: skills/$name is not a symlink"; fi
|
|
[ "$use_cli" -eq 1 ] && check_cli "$name" "$dir"
|
|
done
|
|
|
|
echo "mods: $pass pass, $fail fail"
|
|
[ "$fail" -eq 0 ]
|