13 KiB
CONTRACT — memory-capture (phase 4b)
- date: 2026-11-03 | flow: ship-feature | branch: feature/memory-capture (off develop
29624d7) - status: active
REQUEST (verbatim — IMMUTABLE)
Phase 4b of the context mod queue (BDR-125), TODO.md "Phase 4b-4d, memory v2 capture, read, feedback" — the 4b capture part: failure ledger (tool results with isError, deny or non-zero exit carrying a distinctive error line → normalized + verbatim + command, redacted at capture, bounded ring per session in $.store, matched against the registry error index; unmatched = new failure modes), milestones (feat/fix commit, gitflow finish, a suite red then green), a memory_pending tool returning unmatched failures + milestones, called first by /capitalize, /close and every CAPITALIZE step; one context note at the next prompt after a milestone, never per turn, never at Stop; writing stays model draft + user approval + lib/memory.sh. Designed 2026-10-25 (measured: 5 of 7 real errors had no entry, error 4-gram match exact). 4c (read side) is the next ship-feature; 4d stays deferred.
(user brief 2026-11-02, step 3: "Phases 4b à 4d". The TODO bullet "4b capture (mod)" at develop 29624d7 is the design seed.)
Session constraints (same brief): default model opus; verifier, security-auditor and plan-challengers pinned on opus; never commit a /model or UI write of settings.json (LRN-253); plan text through Write/Edit (BLK-039); destructive steps on the live tree in the main loop after the user's go, mv over rm (BLK-040).
CLARIFICATIONS
Pass A (gaps found by the STEP 0d read-before, put to the user at the STEP 1 brainstorm; answers land [gated]):
- Engine facts that reshape the seed (types 2.1.277 on disk, CLI 2.1.317): a non-zero Bash exit is an
isErrorresult whose text startsExit code N(no exit-code field; the typed record with stdout/stderr/gitOperation exists on success only);$.storeis per plugin, machine-wide, cross-project, 4 MiB total (not per session); there is no$.state; a registered tool exists from the prompt aftersession.start; sub-agents with atools:allowlist cannot call an MCP tool (commit-changer); gitleaks rules are compiled into the binary (no data to port as-is);session.idchanges on /clear and resume. - Spike 2026-11-03 (probe mod, headless, CLI 2.1.317;
.claude/tasks/plans/2026-11-03-memory-capture-spike/REPORT.md): a non-zero exit, a deny rule and an unapproved ask all come back fromnext(e)asisError: truewith the reason only intext(Exit code N\n<stderr>,Permission to use Bash with command … has been denied.,Claude requested permissions to use Bash, but you haven't granted it yet.), never adenyfield;classic.PermissionDeniednever fired;classic.PostToolUseFailurefires on non-zero exits (error= text); success results carry{stdout, stderr, interrupted}and NOgitOperation, even on real commits (direct and in a script); stdout reaches the hook in clear (TOKEN=abc123), so redaction is needed.
Brainstorm answers [gated 2026-11-03] (user: "oui" to recommendations 1-8):
- Host: a new mod
mods/memory/(it will also host 4c), toolmemory_pending→mcp__memory__memory_pending. - Failure = a Bash
isErrorresult whose text startsExit code N, main loop and sub-agents; excluded: permission refusals (Permission to use …,… haven't granted it yet), guard redirects (model-router: …),tool_use_error, and a failure with no error line afterExit code N; distinctive line = the last non-empty line afterExit code N; deduplicated per session by normalized line. - Store: keyed by project root; ≤ 50 failures per session, ≤ 2 KiB per entry, the 3 most recent sessions per project kept (survives /clear), global cap 1 MiB of the 4 MiB
$.store. - Match: index built at call time from backticked spans of BLK and LRN bodies (superseded excluded); known = shares ≥ 1 normalized word 4-gram (digits, paths, hex → placeholders); known entries carry the ID, the rest are "new".
- Milestones: a successful
git commitwhose message startsfeatorfix(read from the command text), a successfulgitflow.sh finishexceptfinish chore, the samemake test …command going red then green; one-line note at the next prompt, once per milestone. - Redaction: TS pattern set =
KEY=valuefor TOKEN|API_KEY|SECRET|PASSWORD|PASSWD, the 7 /guardrails SECRET_PATTERNS,Bearertokens, URLs withuser:pass@; 40-hex SHAs kept; no gitleaks call. - Consumers: /capitalize, /close and CAPITALIZE steps call it first; /commit-change calls it before dispatching commit-changer and passes the result; /hotfix stays silent unless the tool returns a new failure.
- The tool stays deferred like
route; skills load it withToolSearchonce per session. 2-amended[gated 2026-11-04](noise gate, plan Task 7 step 3; user: option A): the distinctive line must hold an error-shaped word, matched case-insensitive on the redacted line byerror|fatal|cannot|can't|no such|not found|denied|failed|failure|unexpected|invalid|exception|traceback|panic|usage:|SC\d{4}|> \d+|assert; a line without one is no line and the failure is dropped (same treatment as a letterless line). Measured on 14 days of transcripts (NOISE.md): 83 % noise on the shipped rule, every useful sample kept by the filter, 81 → 27 captures. Options B (no sub-agent capture) and C (ship as is) declined.
ACCEPTANCE CRITERIA (seed, enriched at STEP 3 [gated])
- A mod captures failures (scope decided at the brainstorm) as entries {normalized line, verbatim excerpt, command, tool, time}, redacted BEFORE storage, in a bounded store layout decided at the brainstorm (entries per session, bytes per entry, eviction of stale sessions, total under the 4 MiB
$.storecap). - Each captured failure is matched against an error index built from the project's
.claude/memory/registries (rule decided at the brainstorm); matched ones carry the entry ID, unmatched ones are "new failure modes". - Milestones (definitions decided at the brainstorm) are recorded per session.
- A
memory_pendingtool returns the unmatched failures and the milestones of the current session (shape decided at the brainstorm); it never writes a registry. - One context note at the first prompt after a milestone, at most once per milestone, never per turn, never at Stop.
- /capitalize, /close and the CAPITALIZE steps of feat, bugfix, hotfix, ship-feature and commit-change call
memory_pendingfirst and feed its output to their candidate scan; the approval gate andlib/memory.shwriting are unchanged; every citer patched, doctrine-citers census green. - Redaction proven by a test whose oracle does not share the redactor (LRN-237): fixtures carrying secret-shaped strings (allowlisted for gitleaks) come out redacted.
- The mod fails open on every hook, has the
~/.claude/<name>.json"enabled": falseoff switch, passesclaude plugin validate --strictandclaude plugin test(mods suite green), andmake testis green. - Proof: a failure in session N is visible through
memory_pendingin the same session and survives a /clear as decided; the noise rate measured on real transcripts before shipping (LRN-047).
STEP 3 gate [gated 2026-11-04] (user: "oui aux deux, lance"): plan r3 (docs/superpowers/plans/2026-11-03-memory-capture.md, f2daf76, § R2 and § R3 override the task text) approved; the build-time off switch ~/.claude/memory.json {"enabled": false} approved (written by the controller before Task 1, moved away before Task 9).
[gated 2026-11-04]Mod tests:mods/memory/hooks/register.test.tsholds the plan's named tests (TOFF, TFAIL, the redaction set, CAP1-CAP10, ID1, ID2, RACE1, TIME1, IDX1-IDX8, MS1-MS6, NT1-NT4) and the mods suite is green;mods/memory/hooks/register.tsholds no line over 80 columns. CHECK: cd /home/bchanot/Documents/claude && T=mods/memory/hooks/register.test.ts && for n in TOFF TFAIL CAP1 CAP3 CAP8 CAP10 ID1 ID2 RACE1 TIME1 IDX1 IDX3 IDX8 MS1 MS3 MS4 MS5 NT1 NT3; do /usr/bin/grep -q "$n" "$T" || exit 1; done && [ "$(awk 'length($0) > 80' mods/memory/hooks/register.ts | wc -l)" = 0 ] && a=$(make test suite=lib/tests/mods.test.sh 2>&1) && printf '%s\n' "$a" | /usr/bin/grep -q 'all suites green' && echo MOD-OK EXPECT: MOD-OK EVIDENCE: MET exit=0 marker-found :: MOD-OK[gated 2026-11-04]Mod layout: manifest namememory,hooks/hooks.jsonmodules./register.ts, tracked linkskills/memory -> ../mods/memory; the tool name in code ismemory_pendingand the served namemcp__memory__memory_pending. CHECK: cd /home/bchanot/Documents/claude && jq -e '.name == "memory"' mods/memory/.claude-plugin/plugin.json >/dev/null && [ "$(readlink skills/memory)" = "../mods/memory" ] && git ls-files --error-unmatch skills/memory >/dev/null 2>&1 && /usr/bin/grep -q "mcp__memory__memory_pending" mods/memory/hooks/register.ts && echo LAYOUT-OK EXPECT: LAYOUT-OK EVIDENCE: MET exit=0 marker-found :: LAYOUT-OK[gated 2026-11-04]Consumers: capitalize carries the bold label**Captured first.**; feat, bugfix, ship-feature, hotfix and commit-change namememory_pending; agents/commit-changer.md names the captured block and the heredoc channel. CHECK: cd /home/bchanot/Documents/claude && /usr/bin/grep -q '**Captured first.**' skills/capitalize/SKILL.md && for f in feat bugfix ship-feature hotfix commit-change; do /usr/bin/grep -q 'memory_pending' "skills/$f/SKILL.md" || exit 1; done && /usr/bin/grep -q 'MEMCAP_EOF' agents/commit-changer.md && echo CONSUMERS-OK EXPECT: CONSUMERS-OK EVIDENCE: MET exit=0 marker-found :: CONSUMERS-OK[gated 2026-11-04]Noise measured:.claude/tasks/plans/2026-11-03-memory-capture-spike/NOISE.mdholds main-loop and sub-agent counts and the noise share, and no captured sample line (noexcerpt, nocommand:lines). CHECK: cd /home/bchanot/Documents/claude/.claude/tasks/plans/2026-11-03-memory-capture-spike && [ -s NOISE.md ] && /usr/bin/grep -qi 'sub-agent' NOISE.md && /usr/bin/grep -qi 'noise' NOISE.md && ! /usr/bin/grep -qiE '^\s*-?\s*(excerpt|command):' NOISE.md && echo NOISE-OK EXPECT: NOISE-OK EVIDENCE: MET exit=0 marker-found :: NOISE-OK[gated 2026-11-04]Whole branch:make testall suites green and shellcheck clean on the health stack; settings.json untouched by the branch. CHECK: cd /home/bchanot/Documents/claude && t=$(make test 2>&1) && printf '%s\n' "$t" | /usr/bin/grep -q 'all suites green' && shellcheck ./.sh hooks/.sh lib/*.sh && [ -z "$(git diff develop...HEAD --stat -- settings.json)" ] && echo BRANCH-OK EXPECT: BRANCH-OK EVIDENCE: MET exit=0 marker-found :: BRANCH-OK[gated 2026-11-04]Error-shaped line filter (answer 2-amended):register.tsholds theERRORISHpattern,register.test.tsholdsCAP11(anExit code 1whose last line isrc=0stores nothing;ls: cannot accessandunexpected EOF while looking for matchinglines are stored), the mods suite is green. CHECK: cd /home/bchanot/Documents/claude && /usr/bin/grep -q 'ERRORISH' mods/memory/hooks/register.ts && /usr/bin/grep -q 'CAP11' mods/memory/hooks/register.test.ts && a=$(make test suite=lib/tests/mods.test.sh 2>&1) && printf '%s\n' "$a" | /usr/bin/grep -q 'all suites green' && echo ERRORISH-OK EXPECT: ERRORISH-OK EVIDENCE: MET exit=0 marker-found :: ERRORISH-OK
FILE SCOPE (final, STEP 3 [gated 2026-11-04])
- mods// (new mod: .claude-plugin/plugin.json, hooks/hooks.json, hooks/register.ts, hooks/register.test.ts), skills/ link — or mods/model-router if the brainstorm picks it as host
- skills/capitalize/SKILL.md, skills/close/SKILL.md, skills/{feat,bugfix,hotfix,ship-feature,commit-change}/SKILL.md, agents/commit-changer.md (§ Capitalize candidates, one line), lib/capitalize-commit.md (unchanged unless a citer needs it)
- CLAUDE.global.md ("Proactive capitalization", only if the brainstorm changes it), README.md, USAGE.md, CHANGELOG.md, ARCHITECTURE.md
- .claude/tasks/TODO.md, .claude/tasks/plans/ (spike notes), docs/superpowers/{specs,plans} (transient)
PROOF (Task 9)
- Step 0 (2026-11-04, user go):
~/.claude/memory.jsonmoved to$CLAUDE_JOB_DIR/tmp/memory.json.off; capture is on from the next session. - Step 1 headless (2026-11-04 12:08,
claude -p --model haiku, live user settings, modmemory@skills-dir, scratch repo$CLAUDE_JOB_DIR/tmp/proof9/repo.gYdoonfeature/probe,GITFLOW_NO_PUSH=1, fixture.claude/memory/blockers.mdwith one unrelated BLK): four tool calls as scripted (ToolSearch select,ls /nonexistent-dir-xyz,git commit --allow-empty -m "fix: probe",mcp__memory__memory_pending {}), rc 0, cost $0.011. Answer:memory_pending (project repo.gYdo, 1 session(s))/index: read blockers.md; skipped learnings.md (missing)/milestones (this session): - commit fix: probe (12:08)/failures: - NEW ×1 ls: cannot access '/nonexistent-dir-xyz': No such file or directory — command: ls /nonexistent-dir-xyz+ excerpt. Log:$CLAUDE_JOB_DIR/tmp/proof9/out.jsonl. The run leaves ap:<tmp path>key in the real store; the sweep ages it out (R3 conf 12). - Step 3 interactive (user + model, R3 conf 5): pending — in a scratch repo on a feature branch the model runs
git commit --allow-empty -m "fix: probe", the user sends two composer prompts, the transcript grep expects exactly onememory: commit fix: probeon the first; then/clearand amemory_pendingcall lists the probe session(earlier session).