Compare commits
4
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
78aad7db1a | ||
|
|
55edd0a6c7 | ||
|
|
2b7aeb8605 | ||
|
|
858bd41782 |
No files matched your search
@@ -0,0 +1,60 @@
|
|||||||
|
# CONTRACT — advisor-points-b3
|
||||||
|
- date: 2026-11-18 | flow: ship-feature | branch: feature/advisor-points-b3
|
||||||
|
- status: active
|
||||||
|
|
||||||
|
## REQUEST (verbatim — IMMUTABLE)
|
||||||
|
corrige les deux bugs mis dans le todos puis passe a C
|
||||||
|
|
||||||
|
Answers 2026-11-18 that scope this run: "Did 'les deux bugs' also mean TODO:10-11?" → "Yes, do 10-11 first". Route line wording → "First challenge call (Recommended)": "(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due)". BUGS-FOUND :114 Advisor row → "Yes, same run (Recommended)". Flow → "/ship-feature (Recommended)". TODO:11 → "Skip when gates clean": feat/bugfix skip the end-of-run call when GATE 0, verifier and security passed first try and no stuck call ran; doctrine edit in effort-shift item 3 + 2 skills.
|
||||||
|
|
||||||
|
Skill args (/ship-feature): Advisor run B3 (TODO:10-11 + BUGS-FOUND :114 residual; user 2026-11-18). (1) The challenge route line in 12 skills (feat, bugfix, hotfix, ship-feature, init-project, audit-delta, code-clean, onboard, harden, pack-seo seo + geo, pack-web-validate web-validate) reads "(route: own level before the challenge; send it with the challenger dispatch)"; lib/challenge-plan.md now puts the main-loop advisor call (and a plan read) before the dispatch. User wording: "(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due)". (2) Same 12 skills: each CHALLENGE SUMMARY template gains the `Advisor:` row lib/challenge-plan.md OUTPUT requires; BUGS-FOUND :114 residual → FIXED. (3) TODO:11 user decision "skip when gates clean": /feat and /bugfix skip the end-of-run advisor call when GATE 0, the verifier and security all passed on their first run and no stuck call ran; doctrine in lib/effort-shift.md § Advisor item 3 + skills/feat + skills/bugfix end lines; TODO:11 closed, BDR-150 status line. Method as B2: blocks in files + exact-once applier, simulated on a mktemp scratch copy with every contract CHECK before dispatch (LRN-296); markers and `§ Label` citations on one line followed by `)` or `;`; criteria plain `N.` labels (gates.sh now rejects others); full make test at the gates.sh default timeout; gates in order GATE 0 → verifier → security after CONFORME; at capitalize memory_pending first; docs CHANGELOG [Unreleased] Advisor doctrine bullet, README/USAGE only if they cite the changed lines.
|
||||||
|
|
||||||
|
## CLARIFICATIONS
|
||||||
|
Q: route line wording / A: user wording above [gated 2026-11-18]
|
||||||
|
Q: fold BUGS-FOUND :114 Advisor row into the run / A: yes [gated 2026-11-18]
|
||||||
|
Q: flow / A: /ship-feature [gated 2026-11-18]
|
||||||
|
Q: TODO:11 decision / A: skip when gates clean, feat and bugfix only [gated 2026-11-18]
|
||||||
|
Q: route wording vs a PLAN Read first / A: keep verbatim [gated 2026-11-18]
|
||||||
|
Q: Advisor row format / A: row with its three values inline; one-line summaries gain "/ advisor" [gated 2026-11-18]
|
||||||
|
Q: "gates clean" / A: strict: GATE 0 MET, verifier CONFORME, security PASS (not DEGRADED), each first attempt; anything else runs the call [gated 2026-11-18]
|
||||||
|
Q: add-ons / A: ADVISOR field in FEAT/BUGFIX COMPLETE; item 3 "end step" wording (BUGS-FOUND :118 wording part) [gated 2026-11-18]
|
||||||
|
Q: STEP 3 dispositions (plan "Dispositions shown at the STEP 3 gate": verdict out of view runs the call; all-manual GATE 0 MET counts; NEED-DECISION / deferred BLOCKER / REPORTED findings count as clean; a skip discharges its point and trigger; bugfix end route kept; reuse clause names later code commits) / A: approved as listed [gated 2026-11-18]
|
||||||
|
|
||||||
|
## ACCEPTANCE CRITERIA
|
||||||
|
1. No skill keeps the old route annotation "send it with the challenger dispatch". [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=$(git grep -c 'send it with the challenger dispatch' -- skills | wc -l); [ "$n" -eq 0 ] && echo OLD-ROUTE-GONE
|
||||||
|
EXPECT: OLD-ROUTE-GONE
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: OLD-ROUTE-GONE
|
||||||
|
2. Each of the 12 challenge callers carries the new route annotation exactly once, on its `mcp__model-router__route(phase=…)` line. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in skills/feat/SKILL.md skills/bugfix/SKILL.md skills/hotfix/SKILL.md skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md; do c=$(grep -F 'mcp__model-router__route(phase=' "$f" | grep -cF '(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).'); [ "$c" -eq 1 ] && n=$((n+1)); done; [ "$n" -eq 12 ] && echo ROUTE-12
|
||||||
|
EXPECT: ROUTE-12
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ROUTE-12
|
||||||
|
3. In the 9 block-form CHALLENGE SUMMARY templates, the line right after `Lenses returned` is the `Advisor:` row, its noun equal to the noun of the block's own `BLOCKERs addressed` row. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md; do awk 'BEGIN{ok=0} /BLOCKERs addressed : <n>/{if (match($0,/named [a-z-]+ change/)) x=substr($0,RSTART+6,RLENGTH-13)} p{if (x!="" && index($0,"Advisor : <the " x " change it drove | called, no change | not called (absent | error | already called this run)>")) ok=1; p=0} /Lenses returned : correctness/{p=1} END{exit !ok}' "$f" && n=$((n+1)); done; [ "$n" -eq 9 ] && echo ROWS-9
|
||||||
|
EXPECT: ROWS-9
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ROWS-9
|
||||||
|
4. feat, bugfix and hotfix name the advisor in their one-line CHALLENGE SUMMARY. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in feat bugfix hotfix; do grep -qF 'lenses returned / advisor)' skills/$f/SKILL.md && grep -qF 'CHALLENGE SUMMARY' skills/$f/SKILL.md && n=$((n+1)); done; [ "$n" -eq 3 ] && echo SENTENCES-3
|
||||||
|
EXPECT: SENTENCES-3
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: SENTENCES-3
|
||||||
|
5. lib/effort-shift.md § Advisor item 3 keeps "never skipped for an earlier plan or stuck call" and names its two skips (audit-delta/tour with no fix; feat/bugfix on the strict rule, "(not DEGRADED)" and the verdict-out-of-view clause included); a skipped call discharges its point; feat/bugfix sit at their commit step; for the six gate flows a later merge proposal reuses the last run's answer or skip and names any later code commit (doc and memory commits excepted); "end step of feat" and "predates the newer commits" are gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && t=$(awk '/^3\. Before proposing a merge/{p=1} p&&/^$/{exit} p' lib/effort-shift.md | tr '\n' ' ' | tr -s ' '); for s in 'Wired at the commit step of feat and bugfix, at the end step of ship-feature' 'never skipped for an earlier plan or stuck call. Two skips only:' 'feat and bugfix when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt (any other verdict, a retry, a loop iteration or a verdict no longer in view runs the call)' '`skipped (gates clean on first pass)`' 'A skipped call discharges its point and the trigger it covers.' 'a later merge proposal reuses the last run' 'and names any code commit made after it (doc and memory commits excepted).'; do printf '%s' "$t" | grep -qF -- "$s" || exit 1; done; printf '%s' "$t" | grep -qF 'end step of feat' && exit 1; printf '%s' "$t" | grep -qF 'predates the newer commits' && exit 1; echo ITEM3-OK
|
||||||
|
EXPECT: ITEM3-OK
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ITEM3-OK
|
||||||
|
6. skills/feat and skills/bugfix restate the skip condition ("(not DEGRADED)" and the verdict-out-of-view clause included) at their end-of-run line, before the COMPLETE summary, and the summary template carries the `ADVISOR` field with its three values; the old "as an `Advisor:` line" wording is gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && for f in skills/feat/SKILL.md skills/bugfix/SKILL.md; do t=$(tr '\n' ' ' < "$f" | tr -s ' '); for s in 'end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt; any other verdict, a retry, a loop iteration or a verdict no longer in view runs the call.' '`ADVISOR` field, and a fix it drives goes back through the gates.' ': <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>'; do printf '%s' "$t" | grep -qF -- "$s" || exit 1; done; printf '%s' "$t" | grep -qF 'goes into the summary as an `Advisor:` line' && exit 1; a=$(grep -n '§ Advisor), skipped when' "$f" | cut -d: -f1); c=$(grep -nE '^ *(FEAT|BUGFIX) COMPLETE$' "$f" | tail -1 | cut -d: -f1); d=$(grep -n 'ADVISOR .*: <one-line answer' "$f" | cut -d: -f1); [ -n "$a" ] && [ -n "$c" ] && [ -n "$d" ] && [ "$a" -lt "$c" ] && [ "$c" -lt "$d" ] || exit 1; done; echo FEAT-BUGFIX-SKIP
|
||||||
|
EXPECT: FEAT-BUGFIX-SKIP
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: FEAT-BUGFIX-SKIP
|
||||||
|
7. CHANGELOG [Unreleased] "Advisor doctrine" bullet names the new callers, the summary row and route, the feat/bugfix skip (not DEGRADED), their commit step, the `ADVISOR` field and the reuse clause that names later code commits; "It sits at the end step of feat, bugfix" and "the answer goes into the reply, summary or finish proposal" are gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && u=$(awk '/^## \[Unreleased\]/{p=1;next} /^## \[/{p=0} p' CHANGELOG.md); for s in 'skills/{feat,bugfix,hotfix,ship-feature,init-project,onboard,code-clean,harden,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md' 'the CHALLENGE SUMMARY of every caller gains an `Advisor:` row' 'with the first tool call of `lib/challenge-plan.md`' 'feat and bugfix skip it when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt' 'It sits at the commit step of feat and bugfix and at the end step of ship-feature' 'and a later merge proposal reuses the last run' 'names any code commit made after it (doc and memory commits excepted).' 'or into the feat/bugfix summary'; do printf '%s' "$u" | grep -qF -- "$s" || exit 1; done; printf '%s' "$u" | grep -qF 'It sits at the end step of feat, bugfix' && exit 1; printf '%s' "$u" | grep -qF 'the answer goes into the reply, summary or finish proposal' && exit 1; echo CHANGELOG-OK
|
||||||
|
EXPECT: CHANGELOG-OK
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: CHANGELOG-OK
|
||||||
|
8. Full make test green. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test </dev/null 2>&1 | tail -1
|
||||||
|
EXPECT: all suites green
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||||
|
9. No wording changed outside the planned edits; every marker and `§ Label` citation stays on one line followed by `)` or `;`; new prose lines ≤ 80 columns, except by name the 12 route lines and the template rows (`Advisor` row, `ADVISOR` field), which run as wide as the rows beside them, and the CHANGELOG bullet (one unwrapped line, like every bullet in that file) (manual). [gated 2026-11-18]
|
||||||
|
|
||||||
|
## FILE SCOPE
|
||||||
|
skills/feat/SKILL.md, skills/bugfix/SKILL.md, skills/hotfix/SKILL.md, skills/ship-feature/SKILL.md, skills/init-project/SKILL.md, skills/audit-delta/SKILL.md, skills/code-clean/SKILL.md, skills/onboard/SKILL.md, skills/harden/SKILL.md, skills/pack-seo/skills/seo/SKILL.md, skills/pack-seo/skills/geo/SKILL.md, skills/pack-web-validate/skills/web-validate/SKILL.md, lib/effort-shift.md, CHANGELOG.md
|
||||||
|
(bookkeeping: .claude/tasks/TODO.md, .claude/audits/BUGS-FOUND.md, .claude/memory via memory.sh, this contract; transient plan under docs/superpowers/plans/)
|
||||||
+1
-1
@@ -20,7 +20,7 @@ The BDR-125 context queue is delivered: phases 0, 0b, 4a, 1, 5, 2 and 4b-4d ship
|
|||||||
- **memory commit chokepoint**: `lib/memory.sh check --staged`, run by `lib/memory-commit.sh commit` before every memory commit (rc 6, registry unstaged), also refuses a staged v2 registry whose new `## ` entry does not carry the next free ID: the highest ID seen at any heading level, fenced or not, in HEAD and above the entry in the staged file, plus one, the same reading `add` uses. stderr: `memory: <file>:<line>: new entry <ID> is not the next free ID <PREFIX>-NNN`. A committed ID is never renamed: fix the uncommitted heading and every uncommitted mention of its ID (the `superseded by` line from `add --supersedes`, the journal line), or drop the new entry and re-add it with `memory.sh add`. Skipped when the registry is absent from HEAD, HEAD is v1 (an `upgrade` commit), HEAD has an open code fence, or HEAD has no well-formed `## ` entry. Tests: `lib/tests/memory.test.sh`.
|
- **memory commit chokepoint**: `lib/memory.sh check --staged`, run by `lib/memory-commit.sh commit` before every memory commit (rc 6, registry unstaged), also refuses a staged v2 registry whose new `## ` entry does not carry the next free ID: the highest ID seen at any heading level, fenced or not, in HEAD and above the entry in the staged file, plus one, the same reading `add` uses. stderr: `memory: <file>:<line>: new entry <ID> is not the next free ID <PREFIX>-NNN`. A committed ID is never renamed: fix the uncommitted heading and every uncommitted mention of its ID (the `superseded by` line from `add --supersedes`, the journal line), or drop the new entry and re-add it with `memory.sh add`. Skipped when the registry is absent from HEAD, HEAD is v1 (an `upgrade` commit), HEAD has an open code fence, or HEAD has no well-formed `## ` entry. Tests: `lib/tests/memory.test.sh`.
|
||||||
- **model-router write guard fails closed**: when the guard's own check throws or times out, a main-loop Edit, Write or NotebookEdit of a code file outside a skill run is held with `model-router: the write guard failed (<kind>), so this write is held. Enter /hotfix, /feat, /bugfix or /ship-feature, or re-enter the skill you were running, then make this edit.` One log line per session: `model-router: write guard failed (<kind>): main-loop code writes are held until a skill runs`. Sub-agents, skill runs (typed, model-declared phase, typed `/route`) and `.md` / `.txt` files still pass; an error raised by a downstream tool is replayed as before. The guard used to let the write through on its own failure. Tests: `mods/model-router/hooks/register.test.ts` (GUARD: a failing guard …).
|
- **model-router write guard fails closed**: when the guard's own check throws or times out, a main-loop Edit, Write or NotebookEdit of a code file outside a skill run is held with `model-router: the write guard failed (<kind>), so this write is held. Enter /hotfix, /feat, /bugfix or /ship-feature, or re-enter the skill you were running, then make this edit.` One log line per session: `model-router: write guard failed (<kind>): main-loop code writes are held until a skill runs`. Sub-agents, skill runs (typed, model-declared phase, typed `/route`) and `.md` / `.txt` files still pass; an error raised by a downstream tool is replayed as before. The guard used to let the write through on its own failure. Tests: `mods/model-router/hooks/register.test.ts` (GUARD: a failing guard …).
|
||||||
- **model-router: Fable leaves auto-routing**: the `best` and `big` tiers default to opus then sonnet (were fable>opus>sonnet and opus>fable>sonnet), so Opus is the strongest model the router routes to and Fable is the advisor (`advisorModel` in settings.json). Fable stays in the model table and first in the fallback rank, so a hand pick of fable ranks above opus. The first-use Change dialog offers opus, sonnet and haiku; the bare `/model` dialog still offers fable, labelled `fable (custom)`. The ask before Fable only fires when a machine override puts fable at the head of `best`: otherwise `/route ask-tier on` answers `(inert: best is not headed by fable)` and `/route show` prints `ask-tier: inert`. An agent on a best or big row keeps its opus frontmatter when Opus is down. The `tiers.best does not lead the fallback chain` log is gone; `routing.json` is unchanged. Tests: `mods/model-router/hooks/register.test.ts`; `lib/tests/effort-routing.test.sh` floors every row on its tier's head. The `/client-handover` skill-runner children and the `lib/model-gate.md` dispatch doctrine pin `model: "opus"` instead of `"fable"` (BDR-150: Fable is the advisor, never a dispatch target), and the model gate lets a sub-agent pass when the route answer says its model is `fixed at spawn`. Tests: `lib/tests/model-routing.test.sh` refuses any fable dispatch pin under agents/, skills/ and lib/; `lib/tests/effort-routing.test.sh` checks the 7 opus/effort="high" client-handover dispatches.
|
- **model-router: Fable leaves auto-routing**: the `best` and `big` tiers default to opus then sonnet (were fable>opus>sonnet and opus>fable>sonnet), so Opus is the strongest model the router routes to and Fable is the advisor (`advisorModel` in settings.json). Fable stays in the model table and first in the fallback rank, so a hand pick of fable ranks above opus. The first-use Change dialog offers opus, sonnet and haiku; the bare `/model` dialog still offers fable, labelled `fable (custom)`. The ask before Fable only fires when a machine override puts fable at the head of `best`: otherwise `/route ask-tier on` answers `(inert: best is not headed by fable)` and `/route show` prints `ask-tier: inert`. An agent on a best or big row keeps its opus frontmatter when Opus is down. The `tiers.best does not lead the fallback chain` log is gone; `routing.json` is unchanged. Tests: `mods/model-router/hooks/register.test.ts`; `lib/tests/effort-routing.test.sh` floors every row on its tier's head. The `/client-handover` skill-runner children and the `lib/model-gate.md` dispatch doctrine pin `model: "opus"` instead of `"fable"` (BDR-150: Fable is the advisor, never a dispatch target), and the model gate lets a sub-agent pass when the route answer says its model is `fixed at spawn`. Tests: `lib/tests/model-routing.test.sh` refuses any fable dispatch pin under agents/, skills/ and lib/; `lib/tests/effort-routing.test.sh` checks the 7 opus/effort="high" client-handover dispatches.
|
||||||
- **Advisor doctrine (`CLAUDE.global.md` § Workflow, `lib/effort-shift.md` § Advisor, `lib/challenge-plan.md`, `lib/verify-secure-loop.md`, `agents/plan-challenger.md`, `agents/verifier.md`, `agents/security-auditor.md`, `agents/analyzer.md`, `skills/{feat,bugfix,ship-feature,init-project,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md`)**: when a stronger model is needed (an approach to settle before building, a stuck problem, a long task before calling it done, a change to recommend to the doctrine, the architecture or a public interface), the main loop calls the advisor tool (Fable, settings `advisorModel`, set by `/advisor`), at least on the written plan before the plan challengers are dispatched (`lib/challenge-plan.md`, every skill that challenges a plan, once per skill run, not before a re-challenge: an answer that lands a real flaw revises the plan file as plain plan text with no advisor attribution, the advice never enters a challenger brief, and the CHALLENGE SUMMARY gains an `Advisor:` row; the ORCHESTRATOR PROTOCOL in `agents/plan-challenger.md` mirrors this advisor-first step and the row), once per verify-secure run at the first gate loop to fail twice (floor, conformity, security, or a second structural failure, counting main-loop calls since GATE 0 first ran; the advice stays in the main loop and never enters an executor brief; every cap or escalation STOP carries it and says whether it predates the last iteration), and before proposing a merge (`gitflow finish`) or calling a long task done: one end-of-run call per skill run, never skipped for an earlier plan or stuck call. It sits at the end step of feat, bugfix, ship-feature, init-project, a11y and guardrails: the main loop first prints the run's diff stat, the answer goes into the reply, summary or finish proposal as an `Advisor:` line, a fix it drives goes back through the gates, and a later proposal reuses the answer and says it predates the newer commits. It also sits at the end of audit-delta and tour when the run applied a fix (tour: main loop only, never a runner), and at release-candidate STEP 4 before the go / hold ask. In those three the answer is reported only: a fix it calls for waits for a new run, and at the release gate it makes hold the recommended answer. The same six gate skills carry a `Stuck:` line that points at the verify-secure rule. Inside a skill run these points cover the triggers: no second call for the same recommendation. `plan-challenger`, `verifier`, `security-auditor` and `analyzer` may call it only when dispatched as a sub-agent, at most once per dispatch, late, before their verdict or report; the analyzer's output rests on the code it read, never on the advice alone, and advice proposing a design or a fix counts only where the brief asks for one. For the three gates advice only adds: the verifier may go back to a contract criterion and tags a resulting NOT-MET `(advisor-prompted)`, never clearing a gap on advice; the challenger never drops or lowers a finding on advice alone; the security-auditor tags an added finding `advisor:<STEP 3 class>` at that class's severity (REPORTED LOW when it matches no class), and tags a raised one `<rule>+advisor` only when the class's severity is higher than the finding's own; a raise that does not apply, or matches no class, changes nothing (no tag, no PROOF count). Its PROOF ends with `; advisor <n> added/raised`. Executors and every other sub-agent do not call it, even when the tool is listed. Advisor absent or erroring → proceed as written; advice waives no gate, cap or guard and, at a loop cap, feeds the STOP diagnosis. Fable on main comes only from a hand pick, a typed `/route model=fable`, a phase naming `model: fable` or a machine override that puts fable in a tier (BDR-150). Prose that still named Fable as the `audit` row head or a skill-runner pin (`agents/plan-challenger.md`, `lib/challenge-plan.md`, `lib/effort-shift.md`, `skills/tour/SKILL.md`) now says opus.
|
- **Advisor doctrine (`CLAUDE.global.md` § Workflow, `lib/effort-shift.md` § Advisor, `lib/challenge-plan.md`, `lib/verify-secure-loop.md`, `agents/plan-challenger.md`, `agents/verifier.md`, `agents/security-auditor.md`, `agents/analyzer.md`, `skills/{feat,bugfix,hotfix,ship-feature,init-project,onboard,code-clean,harden,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md`, `skills/pack-seo/skills/{seo,geo}/SKILL.md`, `skills/pack-web-validate/skills/web-validate/SKILL.md`)**: when a stronger model is needed (an approach to settle before building, a stuck problem, a long task before calling it done, a change to recommend to the doctrine, the architecture or a public interface), the main loop calls the advisor tool (Fable, settings `advisorModel`, set by `/advisor`), at least on the written plan before the plan challengers are dispatched (`lib/challenge-plan.md`, every skill that challenges a plan, once per skill run, not before a re-challenge: an answer that lands a real flaw revises the plan file as plain plan text with no advisor attribution, the advice never enters a challenger brief, and the CHALLENGE SUMMARY of every caller gains an `Advisor:` row (the plan change it drove, `called, no change` or `not called (absent | error | already called this run)`), each caller sending its route before the challenge with the first tool call of `lib/challenge-plan.md`; the ORCHESTRATOR PROTOCOL in `agents/plan-challenger.md` mirrors this advisor-first step and the row), once per verify-secure run at the first gate loop to fail twice (floor, conformity, security, or a second structural failure, counting main-loop calls since GATE 0 first ran; the advice stays in the main loop and never enters an executor brief; every cap or escalation STOP carries it and says whether it predates the last iteration), and before proposing a merge (`gitflow finish`) or calling a long task done: one end-of-run call per skill run, never skipped for an earlier plan or stuck call, except that feat and bugfix skip it when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt, their summary's `ADVISOR` field then reading `skipped (gates clean on first pass)`. It sits at the commit step of feat and bugfix and at the end step of ship-feature, init-project, a11y and guardrails: the main loop first prints the run's diff stat, the answer goes into the reply or finish proposal as an `Advisor:` line, or into the feat/bugfix summary's `ADVISOR` field, a fix it drives goes back through the gates, and a later merge proposal reuses the last run's answer, or its skip, and names any code commit made after it (doc and memory commits excepted). It also sits at the end of audit-delta and tour when the run applied a fix (tour: main loop only, never a runner), and at release-candidate STEP 4 before the go / hold ask. In those three the answer is reported only: a fix it calls for waits for a new run, and at the release gate it makes hold the recommended answer. The same six gate skills carry a `Stuck:` line that points at the verify-secure rule. Inside a skill run these points cover the triggers: no second call for the same recommendation. `plan-challenger`, `verifier`, `security-auditor` and `analyzer` may call it only when dispatched as a sub-agent, at most once per dispatch, late, before their verdict or report; the analyzer's output rests on the code it read, never on the advice alone, and advice proposing a design or a fix counts only where the brief asks for one. For the three gates advice only adds: the verifier may go back to a contract criterion and tags a resulting NOT-MET `(advisor-prompted)`, never clearing a gap on advice; the challenger never drops or lowers a finding on advice alone; the security-auditor tags an added finding `advisor:<STEP 3 class>` at that class's severity (REPORTED LOW when it matches no class), and tags a raised one `<rule>+advisor` only when the class's severity is higher than the finding's own; a raise that does not apply, or matches no class, changes nothing (no tag, no PROOF count). Its PROOF ends with `; advisor <n> added/raised`. Executors and every other sub-agent do not call it, even when the tool is listed. Advisor absent or erroring → proceed as written; advice waives no gate, cap or guard and, at a loop cap, feeds the STOP diagnosis. Fable on main comes only from a hand pick, a typed `/route model=fable`, a phase naming `model: fable` or a machine override that puts fable in a tier (BDR-150). Prose that still named Fable as the `audit` row head or a skill-runner pin (`agents/plan-challenger.md`, `lib/challenge-plan.md`, `lib/effort-shift.md`, `skills/tour/SKILL.md`) now says opus.
|
||||||
- **gates.sh timeout**: the default per-CHECK timeout (`GATES_TIMEOUT`) is 600 s, up from 120 s. A full `make test` (about 135 s) went NOT-MET on the timeout alone. A run lasts the sum of its CHECKs: a caller with a shorter limit (a foreground tool call stops at 600 s) runs it in the background, and a killed run writes nothing back, so the floor stays PENDING.
|
- **gates.sh timeout**: the default per-CHECK timeout (`GATES_TIMEOUT`) is 600 s, up from 120 s. A full `make test` (about 135 s) went NOT-MET on the timeout alone. A run lasts the sum of its CHECKs: a caller with a shorter limit (a foreground tool call stops at 600 s) runs it in the background, and a killed run writes nothing back, so the floor stays PENDING.
|
||||||
|
|
||||||
### Removed
|
### Removed
|
||||||
|
|||||||
@@ -0,0 +1,266 @@
|
|||||||
|
# Advisor call points, run B3 — Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Make the 12 plan-challenge callers send their route with the first tool call of `lib/challenge-plan.md` and print the `Advisor:` summary row, and let /feat and /bugfix skip their end-of-run advisor call when every gate passed at its first attempt.
|
||||||
|
|
||||||
|
**Architecture:** Prose doctrine edits only. Every edit is a block below or a fixed old/new pair in `docs/superpowers/plans/2026-11-18-advisor-points-b3/apply.py`, which reads the blocks from THIS file and asserts each anchor occurs exactly once before writing anything (LRN-296). No other wording changes.
|
||||||
|
|
||||||
|
**Tech Stack:** Markdown doctrine, Python 3 applier, bash contract oracles (`lib/gates.sh`), `make test`.
|
||||||
|
|
||||||
|
**Spec:** design approved in chat 2026-11-18 (bounded path); contract `.claude/tasks/contracts/2026-11-18-advisor-points-b3-1056.md` (REQUEST verbatim + CLARIFICATIONS [gated]).
|
||||||
|
|
||||||
|
## Global Constraints
|
||||||
|
|
||||||
|
- Branch `feature/advisor-points-b3` off develop; SDD runs in place in `/home/bchanot/Documents/claude` (decline a worktree); commits `docs(doctrine): …`.
|
||||||
|
- Files: the 12 challenge callers skills/{feat,bugfix,hotfix,ship-feature,init-project,audit-delta,code-clean,onboard,harden}/SKILL.md, skills/pack-seo/skills/{seo,geo}/SKILL.md, skills/pack-web-validate/skills/web-validate/SKILL.md; lib/effort-shift.md; CHANGELOG.md. Nothing else.
|
||||||
|
- Route annotation verbatim (user 2026-11-18, LRN-268): `(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).` The `mcp__model-router__route(phase="…")` marker and its phase stay as they are (effort-routing lock).
|
||||||
|
- Skip rule (user 2026-11-18, strict): feat and bugfix skip the end-of-run call only when GATE 0 said MET, the verifier CONFORME and security PASS, each on its first attempt; any other verdict, a retry or a loop iteration runs the call. ship-feature, init-project, a11y and guardrails keep the call with no skip.
|
||||||
|
- `lib/effort-shift.md` keeps "one end-of-run call per skill run, never skipped for an earlier plan or stuck call" and names the two skips beside it (LRN-029). The feat and bugfix end lines restate the skip condition at the site: those steps cite the lib, they do not load it (LRN-297).
|
||||||
|
- Every marker and every `§ Label` citation on one line, followed by `)` or `;`; new prose lines ≤ 80 columns. Exempt by name: the 12 route lines (one line each, as before: the marker and its annotation never wrap) and the template rows (`Advisor` row, `ADVISOR` field), which run as wide as the rows beside them, and the CHANGELOG bullet (one unwrapped line, like every bullet in that file).
|
||||||
|
- Advice stays in the main loop, never in an executor, gate or challenger brief (BDR-066, LRN-083).
|
||||||
|
|
||||||
|
## Review Focus
|
||||||
|
|
||||||
|
- A skip read as "skip whenever nothing failed loudly" → the condition names the three verdicts and "each on its first attempt", and says what runs the call (criteria 5, 6).
|
||||||
|
- A skipped call that looks forgotten → the COMPLETE templates carry an `ADVISOR` field with `skipped (gates clean on first pass)` (criterion 6).
|
||||||
|
- The blanket "never skipped" contradicted by the new skip → item 3 keeps it and states "Two skips only" right after (criterion 5).
|
||||||
|
- A row noun that disagrees with the block's own `BLOCKERs addressed` row (plan / bundle / scope / proposals / finding-set) → criterion 3 compares them per file.
|
||||||
|
- A test-locked phrase moved (feat "verifier + one security dispatch", seo `## FIX BUNDLE`, the route phase markers) → simulated with the scoped suites and the full suite on a scratch clone before dispatch.
|
||||||
|
|
||||||
|
## Dispositions shown at the STEP 3 gate
|
||||||
|
|
||||||
|
- A first-attempt verdict no longer in view (after a compaction) counts as not clean: the call runs (stated in item 3 and both end lines).
|
||||||
|
- A security PASS on a DEGRADED scan (semgrep absent, checklist only; the auditor prints `PASS` with `DEGRADED` on its TOOL line) is not clean: the call runs. This is the "strict" choice; it is spelled "security PASS (not DEGRADED)" everywhere.
|
||||||
|
- An all-manual contract (`RUNNABLE: 0 of n`) that GATE 0 reports MET counts as MET: the verifier still judges every criterion, and its CONFORME is the second condition. (The stricter alternative: "GATE 0 said MET with at least one runnable oracle".)
|
||||||
|
- A skipped call discharges its point and the global "long task before calling it done" trigger it covers (item 3), so a literal reader does not make the call anyway.
|
||||||
|
- bugfix STEP 6 item 3 keeps its `mcp__model-router__route(phase="reflect")` line "(route: end-of-run review)" unchanged: on a skip it still sets the level of the tail (summary, doc sync); cost one idle route call. feat's reload route stays too.
|
||||||
|
- Item 3 also takes the wording part of BUGS-FOUND :118 beyond "commit step": the six gate flows are named, and "says it predates the newer commits" (always true in feat and bugfix, since doc and memory commits follow the call) becomes "names any code commit made after it (doc and memory commits excepted)", for all six flows, with "the last run's answer, or its skip" (a branch can carry several runs). :118 is marked partly fixed at bookkeeping (its stuck-budget half stays open).
|
||||||
|
- Counted as clean by the rule as written (the rule names gate verdicts only): an internal NEED-DECISION the main loop settled, a `[deferred]` challenge BLOCKER, a security PASS that carries REPORTED (non-blocking) findings. The trivial /bugfix path skips the plan challenge, so a clean trivial run makes no advisor call at all.
|
||||||
|
- Residual, not tested here: pairing the route call with the server-side advisor call is unverified in this repo (`lib/effort-shift.md`: the router cannot see the advisor tool). The route applies from the next request either way; pairing only saves a request.
|
||||||
|
- Residual: no standing test locks the skip sentence; a TODO line proposes a loops-light lock (a test file is outside this run's file scope).
|
||||||
|
|
||||||
|
## Acceptance criteria (the contract's final list)
|
||||||
|
|
||||||
|
The contract on disk already holds this final list with its CHECK lines (written before the gate so the plan, the contract and the simulation use one numbering; it replaced the 7-row seed written before the design, keeping its meanings: seed 2 → 2, seed 3 → 3 + 4, seed 4 → 5, seed 5 → 6, seed 6 → 7, seed 7 → 8; 9 is new). On approval its criteria are tagged `[gated 2026-11-18]`; the contract text is the one the verifier judges. Tokens: 1 OLD-ROUTE-GONE, 2 ROUTE-12, 3 ROWS-9, 4 SENTENCES-3, 5 ITEM3-OK, 6 FEAT-BUGFIX-SKIP, 7 CHANGELOG-OK, 8 `all suites green` (full `make test`, default gates timeout), 9 manual.
|
||||||
|
|
||||||
|
1. No skill keeps "send it with the challenger dispatch".
|
||||||
|
2. Each of the 12 callers carries the new route annotation once, on its `mcp__model-router__route(phase=…)` line.
|
||||||
|
3. In the 9 block templates the line right after `Lenses returned` is the `Advisor` row, its noun equal to the block's own `BLOCKERs addressed` noun.
|
||||||
|
4. feat, bugfix and hotfix name `advisor` in their one-line CHALLENGE SUMMARY.
|
||||||
|
5. Item 3 keeps "never skipped for an earlier plan or stuck call" and names its two skips (audit-delta/tour with no fix; feat/bugfix on the strict rule, including "(not DEGRADED)" and the verdict-out-of-view clause); a skipped call discharges its point; feat/bugfix sit at their commit step; for the six gate flows a later merge proposal reuses the last run's answer or skip and names any later code commit; "end step of feat" and "predates the newer commits" are gone.
|
||||||
|
6. feat and bugfix restate the skip at their end-of-run line, before the COMPLETE template, whose `ADVISOR` field lists the three values; "as an `Advisor:` line" is gone from both skills.
|
||||||
|
7. The CHANGELOG [Unreleased] "Advisor doctrine" bullet carries the cl-* blocks; "It sits at the end step of feat, bugfix" and "the answer goes into the reply, summary or finish proposal" are gone.
|
||||||
|
8. Full make test green.
|
||||||
|
9. Manual: no wording changed outside the planned edits; markers and `§ Label` citations on one line followed by `)` or `;`; the line-width rule of Global Constraints.
|
||||||
|
|
||||||
|
Every oracle was simulated on a scratch clone: red before the applier, green after; criteria 3 and 6 also turn red on a moved row, a mismatched noun and an `ADVISOR` field placed above the template.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Edit table (what apply.py does)
|
||||||
|
|
||||||
|
| # | File(s) | Anchor (exact, once) | Action |
|
||||||
|
|---|---------|----------------------|--------|
|
||||||
|
| E1 | the 12 callers | `send it with the challenger dispatch).` | replace with Block route-new |
|
||||||
|
| E2 | the 9 block-form callers | `\n<indent>Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)\n` | append `<indent>` + Block row, `{noun}` = the noun of the block's own `BLOCKERs addressed` row |
|
||||||
|
| E3 | skills/feat/SKILL.md | `(BLOCKERs addressed / deferred / lenses returned), surfacing any deferred BLOCKER in\nthe STEP 1 pass B batch.\n` | replace with Block feat-summary |
|
||||||
|
| E4 | skills/bugfix/SKILL.md | `(BLOCKERs addressed / deferred / lenses returned), folding any deferred BLOCKER into\nthe STEP 3 approval gate.\n` | replace with Block bugfix-summary |
|
||||||
|
| E5 | skills/hotfix/SKILL.md | `CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned). A BLOCKER\nthat shows the fix is wrong or incomplete means this was never\n` | replace with Block hotfix-summary |
|
||||||
|
| E6 | skills/feat/SKILL.md | the 4-line end-of-run paragraph of STEP 5 (`Before the summary, … back through the gates.`) | replace with Block end-report |
|
||||||
|
| E7 | skills/bugfix/SKILL.md | the same paragraph in STEP 6 item 3, 3-space indent | replace with Block end-report, 3-space indent |
|
||||||
|
| E8 | skills/feat/SKILL.md | `VERIFIED : <what was checked>\n` | append Block feat-field |
|
||||||
|
| E9 | skills/bugfix/SKILL.md | ` REGRESSION : <checked areas>\n` | append Block bugfix-field, 3-space indent |
|
||||||
|
| E10 | lib/effort-shift.md | item 3 (10 lines, `3. Before proposing a merge` … `is a new run.`) | replace with Block item3 |
|
||||||
|
| E11 | CHANGELOG.md | `skills/{feat,bugfix,ship-feature,init-project,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md` | replace with Block cl-files |
|
||||||
|
| E12 | CHANGELOG.md | ``and the CHALLENGE SUMMARY gains an `Advisor:` row;`` | replace with Block cl-row |
|
||||||
|
| E13 | CHANGELOG.md | `never skipped for an earlier plan or stuck call. It sits at the end step of feat, bugfix, ship-feature, init-project, a11y and guardrails:` | replace with Block cl-skip |
|
||||||
|
| E14 | CHANGELOG.md | `and a later proposal reuses the answer and says it predates the newer commits.` | replace with Block cl-reuse |
|
||||||
|
| E15 | CHANGELOG.md | ``the answer goes into the reply, summary or finish proposal as an `Advisor:` line,`` | replace with Block cl-answer |
|
||||||
|
|
||||||
|
Row nouns (E2): ship-feature plan, init-project plan, audit-delta finding-set, code-clean scope, onboard proposals, harden bundle (5-space indent), seo bundle, geo bundle, web-validate bundle; every other block uses a 2-space indent.
|
||||||
|
|
||||||
|
Groups: `skills` = E1-E9 (12 + 9 + 3 + 2 + 2 = 28 edits), `lib` = E10-E15 (6 edits), `all` = both. `all` counts every anchor of both groups before it writes any file, so an ABORT leaves the tree untouched (no half-applied doctrine reaches the live `~/.claude` symlinks).
|
||||||
|
|
||||||
|
## Blocks
|
||||||
|
|
||||||
|
Each block body is inserted as written (the applier strips the final newline of an inline block: route-new, row, the five cl-* blocks). The row noun is a deliberate per-template choice: it repeats the noun of the block's own `BLOCKERs addressed` row (plan, bundle, scope, proposals, finding-set).
|
||||||
|
|
||||||
|
### Block route-new
|
||||||
|
```
|
||||||
|
send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block row
|
||||||
|
```
|
||||||
|
Advisor : <the {noun} change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block feat-summary
|
||||||
|
```
|
||||||
|
(BLOCKERs addressed / deferred / lenses returned / advisor), surfacing any
|
||||||
|
deferred BLOCKER in the STEP 1 pass B batch.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block bugfix-summary
|
||||||
|
```
|
||||||
|
(BLOCKERs addressed / deferred / lenses returned / advisor), folding any
|
||||||
|
deferred BLOCKER into the STEP 3 approval gate.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block hotfix-summary
|
||||||
|
```
|
||||||
|
CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned / advisor).
|
||||||
|
A BLOCKER that shows the fix is wrong or incomplete means this was never
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block end-report
|
||||||
|
```
|
||||||
|
Before the summary, the main loop prints the run's diff stat, then makes its
|
||||||
|
end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when
|
||||||
|
GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED),
|
||||||
|
each on its first attempt; any other verdict, a retry, a loop iteration or
|
||||||
|
a verdict no longer in view runs the call. The answer, or the skip, goes
|
||||||
|
into the summary's `ADVISOR` field, and a fix it drives goes back through
|
||||||
|
the gates.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block feat-field
|
||||||
|
```
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block bugfix-field
|
||||||
|
```
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block item3
|
||||||
|
```
|
||||||
|
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
||||||
|
done. Wired at the commit step of feat and bugfix, at the end step
|
||||||
|
of ship-feature, init-project, a11y, guardrails, audit-delta and
|
||||||
|
tour, and at the release gate of release-candidate: one end-of-run
|
||||||
|
call per skill run, never skipped for an earlier plan or stuck call.
|
||||||
|
Two skips only: audit-delta and tour when the run applied no fix;
|
||||||
|
feat and bugfix when GATE 0 said MET, the verifier CONFORME and
|
||||||
|
security PASS (not DEGRADED), each on its first attempt (any other
|
||||||
|
verdict, a retry, a loop iteration or a verdict no longer in view
|
||||||
|
runs the call), their summary then reading
|
||||||
|
`skipped (gates clean on first pass)`. A skipped call discharges
|
||||||
|
its point and the trigger it covers. In the six flows that run the
|
||||||
|
gates (feat, bugfix, ship-feature, init-project, a11y, guardrails),
|
||||||
|
the main loop first prints the run's diff stat, a fix the answer
|
||||||
|
drives goes back through the gates, and a later merge proposal
|
||||||
|
reuses the last run's answer, or its skip, and names any code commit
|
||||||
|
made after it (doc and memory commits excepted). Elsewhere the
|
||||||
|
answer is reported only and a fix it calls for is a new run.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-files
|
||||||
|
```
|
||||||
|
skills/{feat,bugfix,hotfix,ship-feature,init-project,onboard,code-clean,harden,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md`, `skills/pack-seo/skills/{seo,geo}/SKILL.md`, `skills/pack-web-validate/skills/web-validate/SKILL.md
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-row
|
||||||
|
```
|
||||||
|
and the CHALLENGE SUMMARY of every caller gains an `Advisor:` row (the plan change it drove, `called, no change` or `not called (absent | error | already called this run)`), each caller sending its route before the challenge with the first tool call of `lib/challenge-plan.md`;
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-skip
|
||||||
|
```
|
||||||
|
never skipped for an earlier plan or stuck call, except that feat and bugfix skip it when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt, their summary's `ADVISOR` field then reading `skipped (gates clean on first pass)`. It sits at the commit step of feat and bugfix and at the end step of ship-feature, init-project, a11y and guardrails:
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-reuse
|
||||||
|
```
|
||||||
|
and a later merge proposal reuses the last run's answer, or its skip, and names any code commit made after it (doc and memory commits excepted).
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-answer
|
||||||
|
```
|
||||||
|
the answer goes into the reply or finish proposal as an `Advisor:` line, or into the feat/bugfix summary's `ADVISOR` field,
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 1: apply the run (12 skills, item 3, CHANGELOG), one commit
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: skills/{feat,bugfix,hotfix,ship-feature,init-project,audit-delta,code-clean,onboard,harden}/SKILL.md, skills/pack-seo/skills/{seo,geo}/SKILL.md, skills/pack-web-validate/skills/web-validate/SKILL.md, lib/effort-shift.md, CHANGELOG.md
|
||||||
|
|
||||||
|
**Interfaces:**
|
||||||
|
- Consumes: the plan blocks and `apply.py` committed as the branch's first commit by the controller (`chore(plan): …`).
|
||||||
|
- Produces: nothing a later task reads.
|
||||||
|
|
||||||
|
Stop rule for every step: an `ABORT` line, a CHECK that does not print its EXPECT token, or a suite that is not green → first `git restore -- skills/feat/SKILL.md skills/bugfix/SKILL.md skills/hotfix/SKILL.md skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md lib/effort-shift.md CHANGELOG.md` (these files are live through the `~/.claude` symlinks), then stop and report the output verbatim. Never edit a doctrine file by hand and never re-run the applier on a partly applied tree; the controller decides.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Confirm the base**
|
||||||
|
|
||||||
|
Run: `cd /home/bchanot/Documents/claude && git branch --show-current && git status --short && git log --oneline -1`
|
||||||
|
Expected: `feature/advisor-points-b3`, no modified tracked file, HEAD is the `chore(plan)` commit.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Apply both groups at once**
|
||||||
|
|
||||||
|
Run: `cd /home/bchanot/Documents/claude && python3 docs/superpowers/plans/2026-11-18-advisor-points-b3/apply.py docs/superpowers/plans/2026-11-18-advisor-points-b3.md . all`
|
||||||
|
Expected: `applied 34 edits (all)`. An `ABORT` line means nothing was written.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Contract criteria 1-7**
|
||||||
|
|
||||||
|
Run: `cd /home/bchanot/Documents/claude && bash lib/gates.sh status .claude/tasks/contracts/2026-11-18-advisor-points-b3-1056.md | tail -1`, then the CHECK of criteria 1 to 7 one by one (copy each `CHECK:` line from the contract).
|
||||||
|
Expected: `PENDING(8)`, then OLD-ROUTE-GONE, ROUTE-12, ROWS-9, SENTENCES-3, ITEM3-OK, FEAT-BUGFIX-SKIP, CHANGELOG-OK.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Scoped suites**
|
||||||
|
|
||||||
|
Run: `cd /home/bchanot/Documents/claude && for s in plan-challenger effort-routing doctrine-citers loops-light loops-heavy seo-geo-contract; do make test suite=lib/tests/$s.test.sh 2>&1 | tail -1; done`
|
||||||
|
Expected: six lines `all suites green`.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit (one commit: the skills' skip and item 3 land together)**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
cd /home/bchanot/Documents/claude && git add skills/feat/SKILL.md skills/bugfix/SKILL.md skills/hotfix/SKILL.md skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md lib/effort-shift.md CHANGELOG.md && git commit -m "docs(doctrine): challenge route rides the first challenge call; summary Advisor row; feat/bugfix skip the end call on clean gates" && git status --short
|
||||||
|
```
|
||||||
|
Expected: no modified tracked file left.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Review fix (STEP 6 opus review, applied on top of 55edd0a)
|
||||||
|
|
||||||
|
Important 1: the security auditor prints `SECURITY — VERDICT: PASS` on a DEGRADED scan (DEGRADED shows on its `TOOL:` line only), while lib/verify-secure-loop.md teaches reading DEGRADED off the VERDICT line, so "(not DEGRADED)" can be checked against the wrong line. Minor 1: the "skip settles the global trigger" clause lives only in the lib, which feat and bugfix do not load. Minor 3: the CHANGELOG reads as if feat and bugfix were the only skip. The root fix of Important 1 (verify-secure-loop.md and the auditor protocol) is out of scope: BUGS-FOUND.
|
||||||
|
|
||||||
|
| # | File(s) | Anchor (exact, once) | Action |
|
||||||
|
|---|---------|----------------------|--------|
|
||||||
|
| R1 | skills/feat/SKILL.md | Block end-tail-old | replace with Block end-tail-new |
|
||||||
|
| R2 | skills/bugfix/SKILL.md | Block end-tail-old, 3-space indent | replace with Block end-tail-new, 3-space indent |
|
||||||
|
| R3 | CHANGELOG.md | `except that feat and bugfix skip it when` | replace with Block cl-skips |
|
||||||
|
|
||||||
|
Group `review1` = R1-R3 (3 edits). Criteria 6 and 7 keep their needles whole (the new text sits after "runs the call." and before "`ADVISOR` field, and a fix it drives goes back through the gates.").
|
||||||
|
|
||||||
|
### Block end-tail-old
|
||||||
|
```
|
||||||
|
a verdict no longer in view runs the call. The answer, or the skip, goes
|
||||||
|
into the summary's `ADVISOR` field, and a fix it drives goes back through
|
||||||
|
the gates.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block end-tail-new
|
||||||
|
```
|
||||||
|
a verdict no longer in view runs the call. DEGRADED shows on the
|
||||||
|
auditor's `TOOL:` line, beside a PASS. A skip also settles the global
|
||||||
|
"long task before calling it done" trigger. The answer, or the skip,
|
||||||
|
goes into the summary's `ADVISOR` field, and a fix it drives goes back
|
||||||
|
through the gates.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Block cl-skips
|
||||||
|
```
|
||||||
|
except that audit-delta and tour skip it when the run applied no fix and feat and bugfix skip it when
|
||||||
|
```
|
||||||
|
|
||||||
|
### Task R: apply the review fix, one commit
|
||||||
|
|
||||||
|
Stop rule as Task 1 (restore `skills/feat/SKILL.md skills/bugfix/SKILL.md CHANGELOG.md` first on any red step).
|
||||||
|
|
||||||
|
- [ ] **Step 1:** `cd /home/bchanot/Documents/claude && python3 docs/superpowers/plans/2026-11-18-advisor-points-b3/apply.py docs/superpowers/plans/2026-11-18-advisor-points-b3.md . review1` → `applied 3 edits (review1)`.
|
||||||
|
- [ ] **Step 2:** run the CHECK of contract criteria 6 and 7 → FEAT-BUGFIX-SKIP, CHANGELOG-OK; then `for s in loops-light doctrine-citers; do make test suite=lib/tests/$s.test.sh 2>&1 | tail -1; done` → two lines `all suites green`.
|
||||||
|
- [ ] **Step 3:** `git add skills/feat/SKILL.md skills/bugfix/SKILL.md CHANGELOG.md && git commit -m "docs(doctrine): feat/bugfix skip names where DEGRADED shows and the global trigger; changelog names both skips"`
|
||||||
@@ -0,0 +1,158 @@
|
|||||||
|
#!/usr/bin/env python3
|
||||||
|
"""Apply run B3 blocks to a repo root.
|
||||||
|
|
||||||
|
Usage: apply.py <plan.md> <repo root> <skills|lib|all|review1>
|
||||||
|
Blocks are read from the plan (### Block <name> + fenced body). Every anchor
|
||||||
|
must occur exactly once in its file; any miss aborts before writing anything.
|
||||||
|
"""
|
||||||
|
import pathlib
|
||||||
|
import re
|
||||||
|
import sys
|
||||||
|
|
||||||
|
CALLERS = [
|
||||||
|
"skills/feat/SKILL.md", "skills/bugfix/SKILL.md", "skills/hotfix/SKILL.md",
|
||||||
|
"skills/ship-feature/SKILL.md", "skills/init-project/SKILL.md",
|
||||||
|
"skills/audit-delta/SKILL.md", "skills/code-clean/SKILL.md",
|
||||||
|
"skills/onboard/SKILL.md", "skills/harden/SKILL.md",
|
||||||
|
"skills/pack-seo/skills/seo/SKILL.md",
|
||||||
|
"skills/pack-seo/skills/geo/SKILL.md",
|
||||||
|
"skills/pack-web-validate/skills/web-validate/SKILL.md",
|
||||||
|
]
|
||||||
|
# block-form callers: (file, indent, noun of its BLOCKERs addressed row)
|
||||||
|
BLOCKS = [
|
||||||
|
("skills/ship-feature/SKILL.md", 2, "plan"),
|
||||||
|
("skills/init-project/SKILL.md", 2, "plan"),
|
||||||
|
("skills/audit-delta/SKILL.md", 2, "finding-set"),
|
||||||
|
("skills/code-clean/SKILL.md", 2, "scope"),
|
||||||
|
("skills/onboard/SKILL.md", 2, "proposals"),
|
||||||
|
("skills/harden/SKILL.md", 5, "bundle"),
|
||||||
|
("skills/pack-seo/skills/seo/SKILL.md", 2, "bundle"),
|
||||||
|
("skills/pack-seo/skills/geo/SKILL.md", 2, "bundle"),
|
||||||
|
("skills/pack-web-validate/skills/web-validate/SKILL.md", 2, "bundle"),
|
||||||
|
]
|
||||||
|
ROUTE_OLD = "send it with the challenger dispatch)."
|
||||||
|
LENSES = ("Lenses returned : correctness / robustness / simplicity "
|
||||||
|
"(NAME any that failed to return)\n")
|
||||||
|
FEAT_SUM = ("(BLOCKERs addressed / deferred / lenses returned), surfacing any "
|
||||||
|
"deferred BLOCKER in\nthe STEP 1 pass B batch.\n")
|
||||||
|
BUG_SUM = ("(BLOCKERs addressed / deferred / lenses returned), folding any "
|
||||||
|
"deferred BLOCKER into\nthe STEP 3 approval gate.\n")
|
||||||
|
HOT_SUM = ("CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses "
|
||||||
|
"returned). A BLOCKER\nthat shows the fix is wrong or incomplete "
|
||||||
|
"means this was never\n")
|
||||||
|
END_OLD = (
|
||||||
|
"Before the summary, the main loop prints the run's diff stat, then "
|
||||||
|
"makes its\nend-of-run advisor call (`lib/effort-shift.md` § Advisor);"
|
||||||
|
" its answer\ngoes into the summary as an `Advisor:` line, and a fix it "
|
||||||
|
"drives goes\nback through the gates.\n")
|
||||||
|
FEAT_VERIFIED = "VERIFIED : <what was checked>\n"
|
||||||
|
BUG_REGRESSION = " REGRESSION : <checked areas>\n"
|
||||||
|
ITEM3_OLD = (
|
||||||
|
"3. Before proposing a merge (`gitflow finish`) or calling a long task\n"
|
||||||
|
" done. Wired at the end step of feat, bugfix, ship-feature,\n"
|
||||||
|
" init-project, a11y, guardrails, audit-delta and tour, and at the\n"
|
||||||
|
" release gate of release-candidate: one end-of-run call per skill\n"
|
||||||
|
" run, never skipped for an earlier plan or stuck call; audit-delta\n"
|
||||||
|
" and tour skip it when the run applied no fix. In the six flows that\n"
|
||||||
|
" run the gates, the main loop first prints the run's diff stat, a fix\n"
|
||||||
|
" the answer drives goes back through the gates, and a later proposal\n"
|
||||||
|
" reuses the answer and says it predates the newer commits. Elsewhere\n"
|
||||||
|
" the answer is reported only and a fix it calls for is a new run.\n")
|
||||||
|
CL_FILES = ("skills/{feat,bugfix,ship-feature,init-project,a11y,guardrails,"
|
||||||
|
"audit-delta,tour,release-candidate}/SKILL.md")
|
||||||
|
CL_ROW = "and the CHALLENGE SUMMARY gains an `Advisor:` row;"
|
||||||
|
CL_SKIP = ("never skipped for an earlier plan or stuck call. It sits at the "
|
||||||
|
"end step of feat, bugfix, ship-feature, init-project, a11y and "
|
||||||
|
"guardrails:")
|
||||||
|
CL_REUSE = ("and a later proposal reuses the answer and says it predates the "
|
||||||
|
"newer commits.")
|
||||||
|
CL_ANSWER = ("the answer goes into the reply, summary or finish proposal as an "
|
||||||
|
"`Advisor:` line,")
|
||||||
|
|
||||||
|
|
||||||
|
def read_blocks(plan):
|
||||||
|
text = pathlib.Path(plan).read_text(encoding="utf-8")
|
||||||
|
pattern = r"^### Block (\S+)\n```\n(.*?)```\n"
|
||||||
|
return dict(re.findall(pattern, text, re.S | re.M))
|
||||||
|
|
||||||
|
|
||||||
|
def inline(block):
|
||||||
|
return block.rstrip("\n")
|
||||||
|
|
||||||
|
|
||||||
|
def indent(block, width):
|
||||||
|
pad = " " * width
|
||||||
|
return "".join(pad + line if line.strip() else line
|
||||||
|
for line in block.splitlines(True))
|
||||||
|
|
||||||
|
|
||||||
|
def skills_edits(b):
|
||||||
|
edits = [(f, ROUTE_OLD, inline(b["route-new"])) for f in CALLERS]
|
||||||
|
for rel, width, noun in BLOCKS:
|
||||||
|
old = "\n" + " " * width + LENSES
|
||||||
|
row = inline(b["row"]).replace("{noun}", noun) + "\n"
|
||||||
|
edits.append((rel, old, old + " " * width + row))
|
||||||
|
edits += [
|
||||||
|
("skills/feat/SKILL.md", FEAT_SUM, b["feat-summary"]),
|
||||||
|
("skills/bugfix/SKILL.md", BUG_SUM, b["bugfix-summary"]),
|
||||||
|
("skills/hotfix/SKILL.md", HOT_SUM, b["hotfix-summary"]),
|
||||||
|
("skills/feat/SKILL.md", END_OLD, b["end-report"]),
|
||||||
|
("skills/bugfix/SKILL.md", indent(END_OLD, 3),
|
||||||
|
indent(b["end-report"], 3)),
|
||||||
|
("skills/feat/SKILL.md", FEAT_VERIFIED,
|
||||||
|
FEAT_VERIFIED + b["feat-field"]),
|
||||||
|
("skills/bugfix/SKILL.md", BUG_REGRESSION,
|
||||||
|
BUG_REGRESSION + indent(b["bugfix-field"], 3)),
|
||||||
|
]
|
||||||
|
return edits
|
||||||
|
|
||||||
|
|
||||||
|
def lib_edits(b):
|
||||||
|
return [
|
||||||
|
("lib/effort-shift.md", ITEM3_OLD, b["item3"]),
|
||||||
|
("CHANGELOG.md", CL_FILES, inline(b["cl-files"])),
|
||||||
|
("CHANGELOG.md", CL_ROW, inline(b["cl-row"])),
|
||||||
|
("CHANGELOG.md", CL_SKIP, inline(b["cl-skip"])),
|
||||||
|
("CHANGELOG.md", CL_REUSE, inline(b["cl-reuse"])),
|
||||||
|
("CHANGELOG.md", CL_ANSWER, inline(b["cl-answer"])),
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
def review1_edits(b):
|
||||||
|
"""STEP 6 review fix, applied on top of 55edd0a."""
|
||||||
|
old, new = b["end-tail-old"], b["end-tail-new"]
|
||||||
|
return [
|
||||||
|
("skills/feat/SKILL.md", old, new),
|
||||||
|
("skills/bugfix/SKILL.md", indent(old, 3), indent(new, 3)),
|
||||||
|
("CHANGELOG.md", "except that feat and bugfix skip it when",
|
||||||
|
inline(b["cl-skips"])),
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
def all_edits(b):
|
||||||
|
return skills_edits(b) + lib_edits(b)
|
||||||
|
|
||||||
|
|
||||||
|
GROUPS = {"skills": skills_edits, "lib": lib_edits, "all": all_edits,
|
||||||
|
"review1": review1_edits}
|
||||||
|
|
||||||
|
|
||||||
|
def main():
|
||||||
|
plan, root, group = sys.argv[1], pathlib.Path(sys.argv[2]), sys.argv[3]
|
||||||
|
edits = GROUPS[group](read_blocks(plan))
|
||||||
|
texts = {}
|
||||||
|
for rel, old, new in edits:
|
||||||
|
text = texts.get(rel)
|
||||||
|
if text is None:
|
||||||
|
text = (root / rel).read_text(encoding="utf-8")
|
||||||
|
count = text.count(old)
|
||||||
|
if count != 1:
|
||||||
|
sys.exit(f"ABORT {rel}: anchor count {count} != 1: {old[:60]!r}")
|
||||||
|
texts[rel] = text.replace(old, new, 1)
|
||||||
|
for rel, text in texts.items():
|
||||||
|
(root / rel).write_text(text, encoding="utf-8")
|
||||||
|
print(f"applied {len(edits)} edits ({group})")
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
main()
|
||||||
+17
-9
@@ -115,15 +115,23 @@ triggers in CLAUDE.global.md § Workflow):
|
|||||||
(a contract micro-gate, an early escalation, the STOP diagnosis) and
|
(a contract micro-gate, an early escalation, the STOP diagnosis) and
|
||||||
never enters an executor brief.
|
never enters an executor brief.
|
||||||
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
||||||
done. Wired at the end step of feat, bugfix, ship-feature,
|
done. Wired at the commit step of feat and bugfix, at the end step
|
||||||
init-project, a11y, guardrails, audit-delta and tour, and at the
|
of ship-feature, init-project, a11y, guardrails, audit-delta and
|
||||||
release gate of release-candidate: one end-of-run call per skill
|
tour, and at the release gate of release-candidate: one end-of-run
|
||||||
run, never skipped for an earlier plan or stuck call; audit-delta
|
call per skill run, never skipped for an earlier plan or stuck call.
|
||||||
and tour skip it when the run applied no fix. In the six flows that
|
Two skips only: audit-delta and tour when the run applied no fix;
|
||||||
run the gates, the main loop first prints the run's diff stat, a fix
|
feat and bugfix when GATE 0 said MET, the verifier CONFORME and
|
||||||
the answer drives goes back through the gates, and a later proposal
|
security PASS (not DEGRADED), each on its first attempt (any other
|
||||||
reuses the answer and says it predates the newer commits. Elsewhere
|
verdict, a retry, a loop iteration or a verdict no longer in view
|
||||||
the answer is reported only and a fix it calls for is a new run.
|
runs the call), their summary then reading
|
||||||
|
`skipped (gates clean on first pass)`. A skipped call discharges
|
||||||
|
its point and the trigger it covers. In the six flows that run the
|
||||||
|
gates (feat, bugfix, ship-feature, init-project, a11y, guardrails),
|
||||||
|
the main loop first prints the run's diff stat, a fix the answer
|
||||||
|
drives goes back through the gates, and a later merge proposal
|
||||||
|
reuses the last run's answer, or its skip, and names any code commit
|
||||||
|
made after it (doc and memory commits excepted). Elsewhere the
|
||||||
|
answer is reported only and a fix it calls for is a new run.
|
||||||
|
|
||||||
Inside a skill run, the points above also cover the triggers of
|
Inside a skill run, the points above also cover the triggers of
|
||||||
CLAUDE.global.md § Workflow; no second call for the same recommendation.
|
CLAUDE.global.md § Workflow; no second call for the same recommendation.
|
||||||
|
|||||||
@@ -170,7 +170,7 @@ Then show the user the same compact table inline.
|
|||||||
|
|
||||||
### 3b-bis. CHALLENGE THE PROPOSALS (before the gate)
|
### 3b-bis. CHALLENGE THE PROPOSALS (before the gate)
|
||||||
|
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
This axis' findings + proposed fixes are a proposal set worth attacking before
|
This axis' findings + proposed fixes are a proposal set worth attacking before
|
||||||
the human gate. Persist THIS axis' finding list (not the whole append-only
|
the human gate. Persist THIS axis' finding list (not the whole append-only
|
||||||
report) to `.claude/tasks/plans/<date>-<axis>-<HHMM>.md`, then run
|
report) to `.claude/tasks/plans/<date>-<axis>-<HHMM>.md`, then run
|
||||||
@@ -192,6 +192,7 @@ CHALLENGE SUMMARY (3b-bis — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named finding-set change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named finding-set change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the finding-set change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
```
|
```
|
||||||
|
|
||||||
- "Fix what you find" said **in the invocation** does NOT skip this gate:
|
- "Fix what you find" said **in the invocation** does NOT skip this gate:
|
||||||
|
|||||||
+10
-6
@@ -127,7 +127,7 @@ RISK: <low/medium — what could go wrong>
|
|||||||
fast-path is not exempt: a 1-line fix with a visible choice still asks.
|
fast-path is not exempt: a 1-line fix with a visible choice still asks.
|
||||||
|
|
||||||
## STEP 3b — CHALLENGE THE FIX PLAN (before the contract)
|
## STEP 3b — CHALLENGE THE FIX PLAN (before the contract)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Unless the fix is the trivial 1-2 line case STEP 3 already fast-paths, the
|
Unless the fix is the trivial 1-2 line case STEP 3 already fast-paths, the
|
||||||
DIAGNOSIS + FIX PLAN is a reflection worth attacking before it hardens into a
|
DIAGNOSIS + FIX PLAN is a reflection worth attacking before it hardens into a
|
||||||
contract. Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
contract. Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -137,8 +137,8 @@ dispositions. Three blind challengers attack it (correctness = is the root cause
|
|||||||
right; robustness = blast radius / regressions; simplicity = is the fix minimal);
|
right; robustness = blast radius / regressions; simplicity = is the fix minimal);
|
||||||
RE-THINK every aspect a BLOCKER lands, re-challenge once if the plan materially
|
RE-THINK every aspect a BLOCKER lands, re-challenge once if the plan materially
|
||||||
changed. STEP 3.5 writes the contract from the REVISED plan. Print a CHALLENGE SUMMARY
|
changed. STEP 3.5 writes the contract from the REVISED plan. Print a CHALLENGE SUMMARY
|
||||||
(BLOCKERs addressed / deferred / lenses returned), folding any deferred BLOCKER into
|
(BLOCKERs addressed / deferred / lenses returned / advisor), folding any
|
||||||
the STEP 3 approval gate.
|
deferred BLOCKER into the STEP 3 approval gate.
|
||||||
|
|
||||||
## STEP 3.5 — CONTRACT
|
## STEP 3.5 — CONTRACT
|
||||||
|
|
||||||
@@ -233,9 +233,12 @@ Parse the `BUGFIX-EXEC REPORT`:
|
|||||||
two sentences of body).
|
two sentences of body).
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: end-of-run review).
|
`mcp__model-router__route(phase="reflect")` first (route: end-of-run review).
|
||||||
Before the summary, the main loop prints the run's diff stat, then makes its
|
Before the summary, the main loop prints the run's diff stat, then makes its
|
||||||
end-of-run advisor call (`lib/effort-shift.md` § Advisor); its answer
|
end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when
|
||||||
goes into the summary as an `Advisor:` line, and a fix it drives goes
|
GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED),
|
||||||
back through the gates.
|
each on its first attempt; any other verdict, a retry, a loop iteration or
|
||||||
|
a verdict no longer in view runs the call. The answer, or the skip, goes
|
||||||
|
into the summary's `ADVISOR` field, and a fix it drives goes back through
|
||||||
|
the gates.
|
||||||
4. Print summary:
|
4. Print summary:
|
||||||
```
|
```
|
||||||
BUGFIX COMPLETE
|
BUGFIX COMPLETE
|
||||||
@@ -244,6 +247,7 @@ Parse the `BUGFIX-EXEC REPORT`:
|
|||||||
FILE(S) : <changed files>
|
FILE(S) : <changed files>
|
||||||
TEST(S) : <added/updated tests, or "none — verified manually">
|
TEST(S) : <added/updated tests, or "none — verified manually">
|
||||||
REGRESSION : <checked areas>
|
REGRESSION : <checked areas>
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
```
|
```
|
||||||
|
|
||||||
## STEP 7 — DOC SYNC (automatic)
|
## STEP 7 — DOC SYNC (automatic)
|
||||||
|
|||||||
@@ -122,7 +122,7 @@ TOTALS: <N blocking, N warn, N info>
|
|||||||
If no issues found: report clean state and stop.
|
If no issues found: report clean state and stop.
|
||||||
|
|
||||||
## STEP 3b — CHALLENGE THE SCOPE (before approval)
|
## STEP 3b — CHALLENGE THE SCOPE (before approval)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The STEP 3 report is the proposed cleanup scope — worth attacking before the
|
The STEP 3 report is the proposed cleanup scope — worth attacking before the
|
||||||
human approves it. It is still inline, so FIRST persist it to
|
human approves it. It is still inline, so FIRST persist it to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (STEP 3 report format, one item
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (STEP 3 report format, one item
|
||||||
@@ -144,6 +144,7 @@ CHALLENGE SUMMARY (STEP 3b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named scope change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named scope change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the scope change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
AskUserQuestion:
|
AskUserQuestion:
|
||||||
Approve which items for execution? (all / <item numbers> / clarify <item>)
|
Approve which items for execution? (all / <item numbers> / clarify <item>)
|
||||||
|
|||||||
+10
-6
@@ -124,7 +124,7 @@ in the contract's CLARIFICATIONS `[gated]` and in the plan. A choice that
|
|||||||
surfaces only during execution comes back as `NEED-DECISION` (STEP 3).
|
surfaces only during execution comes back as `NEED-DECISION` (STEP 3).
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE PLAN (before branching)
|
## STEP 1b — CHALLENGE THE PLAN (before branching)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The STEP 1 plan is a reflection worth attacking before a branch is spent on it.
|
The STEP 1 plan is a reflection worth attacking before a branch is spent on it.
|
||||||
Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` = `build-plan`,
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` = `build-plan`,
|
||||||
@@ -132,8 +132,8 @@ Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
|||||||
Three blind challengers attack it; RE-THINK every aspect a BLOCKER lands (a named
|
Three blind challengers attack it; RE-THINK every aspect a BLOCKER lands (a named
|
||||||
plan change, or `[deferred]`), re-challenge once if the plan materially changed. The
|
plan change, or `[deferred]`), re-challenge once if the plan materially changed. The
|
||||||
STEP 3 executor receives the REVISED plan. Before dispatch, print a CHALLENGE SUMMARY
|
STEP 3 executor receives the REVISED plan. Before dispatch, print a CHALLENGE SUMMARY
|
||||||
(BLOCKERs addressed / deferred / lenses returned), surfacing any deferred BLOCKER in
|
(BLOCKERs addressed / deferred / lenses returned / advisor), surfacing any
|
||||||
the STEP 1 pass B batch.
|
deferred BLOCKER in the STEP 1 pass B batch.
|
||||||
|
|
||||||
## STEP 2 — BRANCH
|
## STEP 2 — BRANCH
|
||||||
|
|
||||||
@@ -207,9 +207,12 @@ propose/apply executor).
|
|||||||
Then `mcp__model-router__route(phase="reflect")` (route: nested commit-change loaded at apply; reload feat's level).
|
Then `mcp__model-router__route(phase="reflect")` (route: nested commit-change loaded at apply; reload feat's level).
|
||||||
|
|
||||||
Before the summary, the main loop prints the run's diff stat, then makes its
|
Before the summary, the main loop prints the run's diff stat, then makes its
|
||||||
end-of-run advisor call (`lib/effort-shift.md` § Advisor); its answer
|
end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when
|
||||||
goes into the summary as an `Advisor:` line, and a fix it drives goes
|
GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED),
|
||||||
back through the gates.
|
each on its first attempt; any other verdict, a retry, a loop iteration or
|
||||||
|
a verdict no longer in view runs the call. The answer, or the skip, goes
|
||||||
|
into the summary's `ADVISOR` field, and a fix it drives goes back through
|
||||||
|
the gates.
|
||||||
|
|
||||||
Print summary:
|
Print summary:
|
||||||
```
|
```
|
||||||
@@ -218,6 +221,7 @@ FEATURE : <name>
|
|||||||
FILE(S) : <created/modified files>
|
FILE(S) : <created/modified files>
|
||||||
TEST(S) : <added tests>
|
TEST(S) : <added tests>
|
||||||
VERIFIED : <what was checked>
|
VERIFIED : <what was checked>
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
```
|
```
|
||||||
|
|
||||||
## STEP 6 — DOC SYNC (automatic)
|
## STEP 6 — DOC SYNC (automatic)
|
||||||
|
|||||||
@@ -522,7 +522,7 @@ Extract the score and critical-alert count from `.claude/audits/HARDEN.md` for t
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
||||||
extract the `## 8. Fix bundle` section from HARDEN.md to
|
extract the `## 8. Fix bundle` section from HARDEN.md to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
||||||
@@ -557,6 +557,7 @@ If MODE=fix and `.claude/audits/HARDEN.md` ends with `READY TO APPLY — awaitin
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Options :
|
Options :
|
||||||
A) Apply all
|
A) Apply all
|
||||||
|
|||||||
@@ -94,7 +94,7 @@ point. Run it ONLY when the settled fix touches control flow or behaviour — an
|
|||||||
off-by-one, a wrong operator/variable, a behaviour-changing config value, or a
|
off-by-one, a wrong operator/variable, a behaviour-changing config value, or a
|
||||||
missing import that alters execution. In doubt → it is probably a `/bugfix`.
|
missing import that alters execution. In doubt → it is probably a `/bugfix`.
|
||||||
|
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` =
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` =
|
||||||
@@ -102,8 +102,8 @@ For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
|||||||
contract's acceptance criteria. Three blind challengers attack the fix; the main
|
contract's acceptance criteria. Three blind challengers attack the fix; the main
|
||||||
loop RE-THINKS any aspect a BLOCKER lands (a named change to the fix, or
|
loop RE-THINKS any aspect a BLOCKER lands (a named change to the fix, or
|
||||||
`[deferred]`) and re-challenges once if it materially changed. Print a
|
`[deferred]`) and re-challenges once if it materially changed. Print a
|
||||||
CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned). A BLOCKER
|
CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned / advisor).
|
||||||
that shows the fix is wrong or incomplete means this was never
|
A BLOCKER that shows the fix is wrong or incomplete means this was never
|
||||||
a hotfix — escalate to `/bugfix` (its STEP 3b runs the same phase under the full
|
a hotfix — escalate to `/bugfix` (its STEP 3b runs the same phase under the full
|
||||||
verify+secure loop).
|
verify+secure loop).
|
||||||
|
|
||||||
|
|||||||
@@ -192,7 +192,7 @@ Invoke `writing-plans` (vendored superpowers skill) with BRIEF + skeleton.
|
|||||||
Granular tasks (2-5 min each), exact file paths, TDD: tests before code.
|
Granular tasks (2-5 min each), exact file paths, TDD: tests before code.
|
||||||
|
|
||||||
## STEP 6b — CHALLENGE THE PLAN (before the gate)
|
## STEP 6b — CHALLENGE THE PLAN (before the gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Before the human sees the implementation plan, harden it. Run
|
Before the human sees the implementation plan, harden it. Run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = the plan STEP 6 wrote under
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = the plan STEP 6 wrote under
|
||||||
`docs/superpowers/plans/`, `KIND` = `build-plan`, `SCOPE` = the skeleton + task file
|
`docs/superpowers/plans/`, `KIND` = `build-plan`, `SCOPE` = the skeleton + task file
|
||||||
@@ -213,6 +213,7 @@ CHALLENGE SUMMARY (STEP 6b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the plan change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve and start? (yes / request changes)
|
Approve and start? (yes / request changes)
|
||||||
```
|
```
|
||||||
Changes → back to STEP 6. Approved → continue.
|
Changes → back to STEP 6. Approved → continue.
|
||||||
|
|||||||
@@ -917,7 +917,7 @@ Vérifier que les 4 fichiers `.claude/audits/ONBOARD_REPORT.md`, `.claude/audits
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 7b — CHALLENGE THE PROPOSALS (before the human gate)
|
## STEP 7b — CHALLENGE THE PROPOSALS (before the human gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The 4 audit files are on disk; `AUDIT_PROPOSALS.md` is the artifact worth
|
The 4 audit files are on disk; `AUDIT_PROPOSALS.md` is the artifact worth
|
||||||
attacking before the human spends a gate on it. Run
|
attacking before the human spends a gate on it. Run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` =
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` =
|
||||||
@@ -961,6 +961,7 @@ CHALLENGE SUMMARY (STEP 7b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named proposals change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named proposals change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the proposals change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Prochaine étape : générer .claude/tasks/TODO.md depuis .claude/audits/AUDIT_PROPOSALS.md approuvé.
|
Prochaine étape : générer .claude/tasks/TODO.md depuis .claude/audits/AUDIT_PROPOSALS.md approuvé.
|
||||||
|
|
||||||
|
|||||||
@@ -86,7 +86,7 @@ your bundle."
|
|||||||
```
|
```
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The analyzer returned a `## FIX BUNDLE` — worth attacking before any edit lands.
|
The analyzer returned a `## FIX BUNDLE` — worth attacking before any edit lands.
|
||||||
**Skip if intervention mode = conservative** (nothing is applied). Else persist the
|
**Skip if intervention mode = conservative** (nothing is applied). Else persist the
|
||||||
bundle verbatim to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
bundle verbatim to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -138,6 +138,7 @@ CHALLENGE SUMMARY (STEP 1b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve all / select (ids) / skip all?
|
Approve all / select (ids) / skip all?
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -511,7 +511,7 @@ the reports."
|
|||||||
```
|
```
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Both envelopes now carry a `## FIX BUNDLE` — worth attacking before any edit lands.
|
Both envelopes now carry a `## FIX BUNDLE` — worth attacking before any edit lands.
|
||||||
**Skip if intervention mode = conservative** (nothing is applied). Else persist both
|
**Skip if intervention mode = conservative** (nothing is applied). Else persist both
|
||||||
bundles (seo + geo, verbatim) to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
bundles (seo + geo, verbatim) to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -583,6 +583,7 @@ CHALLENGE SUMMARY (STEP 1b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve all / select (ids) / skip all?
|
Approve all / select (ids) / skip all?
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -256,7 +256,7 @@ grep -c '^### \[Critique\]' .claude/audits/VALIDATE.md
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
||||||
extract the `## 5. Fix bundle` section from VALIDATE.md to
|
extract the `## 5. Fix bundle` section from VALIDATE.md to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
||||||
@@ -296,6 +296,7 @@ CHALLENGE SUMMARY (STEP 2b — 3 lenses) :
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Options :
|
Options :
|
||||||
A) Apply all
|
A) Apply all
|
||||||
|
|||||||
@@ -133,7 +133,7 @@ request nor the STEP 1 brainstorm settled (check the contract's CLARIFICATIONS
|
|||||||
first) → one batch before STEP 2b; answers append to the contract `[gated]`.
|
first) → one batch before STEP 2b; answers append to the contract `[gated]`.
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE PLAN (adversarial, before the gate)
|
## STEP 2b — CHALLENGE THE PLAN (adversarial, before the gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Before the human sees the plan, harden it. Run `$HOME/.claude/lib/challenge-plan.md`:
|
Before the human sees the plan, harden it. Run `$HOME/.claude/lib/challenge-plan.md`:
|
||||||
- `PLAN` = the plan STEP 2 wrote under `docs/superpowers/plans/`
|
- `PLAN` = the plan STEP 2 wrote under `docs/superpowers/plans/`
|
||||||
- `KIND` = `build-plan`
|
- `KIND` = `build-plan`
|
||||||
@@ -163,6 +163,7 @@ CHALLENGE SUMMARY (STEP 2b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the plan change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve and execute? (yes / request changes)
|
Approve and execute? (yes / request changes)
|
||||||
```
|
```
|
||||||
This block EXPOSES each in-force item with the plan's CLAIMED disposition, for human
|
This block EXPOSES each in-force item with the plan's CLAIMED disposition, for human
|
||||||
|
|||||||
Reference in new issue
Block a user