diff --git a/hooks/session-start.sh b/hooks/session-start.sh index e4245ec..ae6c1e7 100644 --- a/hooks/session-start.sh +++ b/hooks/session-start.sh @@ -445,6 +445,11 @@ _memory_digest() { # _digest_assemble } if [ "$_ss_digest" = 1 ]; then + # phase 4d: the weekly /memory-feedback reminder, bounded, never fatal + _ss_mf="$(dirname "${BASH_SOURCE[0]}")/../lib/memory-feedback-remind.sh" + _ss_tmo=(); command -v timeout >/dev/null 2>&1 && _ss_tmo=(timeout 2) + [ -f "$_ss_mf" ] && { "${_ss_tmo[@]}" bash "$_ss_mf" 2>/dev/null || true; } + unset _ss_mf _ss_tmo _ss_root=$(git rev-parse --show-toplevel 2>/dev/null) || _ss_root=$PWD # A foreign repository (`gitflow.protect` false) gets no digest. _ss_protect=$(git -C "$_ss_root" config --get gitflow.protect 2>/dev/null) diff --git a/lib/memory-feedback-remind.sh b/lib/memory-feedback-remind.sh new file mode 100755 index 0000000..20b9a69 --- /dev/null +++ b/lib/memory-feedback-remind.sh @@ -0,0 +1,30 @@ +#!/usr/bin/env bash +# lib/memory-feedback-remind.sh — the phase 4d reminder line of the +# session-start banner (BDR-057: transcripts live 7 days). One line when +# /memory-feedback never ran, or ran REMIND_DAYS+ days ago and the memory +# store changed since. Silent once both gates are recorded ("closed":true), +# with "recall": false, or on any error; always rc 0. bash 3.2 safe, +# portable (find -mtime, no stat -c), no JSON parse. +REMIND_DAYS=5 +state="$HOME/.claude/memory-feedback/state.json" + +store="" +for f in "$HOME"/.claude/plugins/store/memory_skills-dir-*.json; do + [ -f "$f" ] || continue + if [ -z "$store" ] || [ "$f" -nt "$store" ]; then store=$f; fi +done +[ -n "$store" ] || exit 0 +# recall off: no record can come (the 4b capture still writes the store) +grep -Eq '"recall"[[:space:]]*:[[:space:]]*false' \ + "$HOME/.claude/memory.json" 2>/dev/null && exit 0 +if [ ! -f "$state" ]; then + echo "memory feedback: never run → /memory-feedback" + exit 0 +fi +[ -r "$state" ] || exit 0 +grep -q '"closed":true' "$state" 2>/dev/null && exit 0 +[ "$store" -nt "$state" ] || exit 0 +[ -n "$(find "$state" -mtime +$((REMIND_DAYS - 1)) 2>/dev/null)" ] || exit 0 +echo "memory feedback: last run ${REMIND_DAYS}+ d ago," \ + "transcripts expire at 7 → /memory-feedback" +exit 0 diff --git a/lib/tests/memory-feedback-remind.test.sh b/lib/tests/memory-feedback-remind.test.sh new file mode 100755 index 0000000..37f18b2 --- /dev/null +++ b/lib/tests/memory-feedback-remind.test.sh @@ -0,0 +1,51 @@ +#!/usr/bin/env bash +# lib/tests/memory-feedback-remind.test.sh — the phase 4d banner line: +# shown when /memory-feedback never ran, or ran 5+ days ago and the store +# changed since; silent once both gates are recorded, with recall off, or +# on any error. +set -u +ROOT="$(cd "$(dirname "$0")/../.." && pwd)" +LIB="$ROOT/lib/memory-feedback-remind.sh" +WORK="$(mktemp -d)" || exit 1 +trap 'chmod -R u+rw "$WORK" 2>/dev/null; rm -rf "$WORK"' EXIT +pass=0; fail=0 +check() { if [ "$2" = "$3" ]; then pass=$((pass+1)); else fail=$((fail+1)); + printf 'FAIL %s: got[%s] want[%s]\n' "$1" "$2" "$3"; fi; } +# home : a fixture HOME with a store file (unless "nostore") +home() { + mkdir -p "$WORK/$1/.claude/plugins/store" "$WORK/$1/.claude/memory-feedback" + [ "$1" = nostore ] || : > "$WORK/$1/.claude/plugins/store/memory_skills-dir-a.json" + echo "$WORK/$1" +} +OPEN='{"lastRun":1,"closed":false}' +# old : a state.json last written on 2026-01-01 +old() { + printf '%s' "$2" > "$1/.claude/memory-feedback/state.json" + touch -t 202601010000 "$1/.claude/memory-feedback/state.json" +} +run() { HOME="$1" bash "$LIB" 2>&1; echo "rc=$?"; } +DUE='memory feedback: last run 5+ d ago, transcripts expire at 7 → /memory-feedback' + +check MR1-no-store "$(run "$(home nostore)")" "rc=0" +check MR2-never "$(run "$(home never)")" "memory feedback: never run → /memory-feedback +rc=0" +h=$(home due); old "$h" "$OPEN" +check MR3-due "$(run "$h")" "$DUE +rc=0" +h=$(home quiet); old "$h" "$OPEN" +touch -t 202512010000 "$h/.claude/plugins/store/memory_skills-dir-a.json" +check MR4-store-unchanged "$(run "$h")" "rc=0" +h=$(home fresh) +printf '%s' "$OPEN" > "$h/.claude/memory-feedback/state.json" +touch -t 209901010000 "$h/.claude/plugins/store/memory_skills-dir-a.json" +check MR5-ran-today "$(run "$h")" "rc=0" +h=$(home closed); old "$h" '{"lastRun":1,"closed":true}' +check MR6-closed "$(run "$h")" "rc=0" +h=$(home off); old "$h" "$OPEN"; printf '{"recall": false}' > "$h/.claude/memory.json" +check MR7-recall-off "$(run "$h")" "rc=0" +h=$(home locked); old "$h" "$OPEN" +chmod 000 "$h/.claude/memory-feedback/state.json" +check MR8-unreadable "$(run "$h")" "rc=0" + +printf 'memory-feedback-remind: %d passed, %d failed\n' "$pass" "$fail" +[ "$fail" -eq 0 ] diff --git a/lib/tests/session-digest.test.sh b/lib/tests/session-digest.test.sh index ceb2c0a..cc835e8 100644 --- a/lib/tests/session-digest.test.sh +++ b/lib/tests/session-digest.test.sh @@ -243,6 +243,17 @@ check SD14c-false "$(run "$p" "$WORK/startup.json" | digests)" 0 check SD14d-banner "$(run "$p" "$WORK/startup.json" | grep -c '^$')" \ "$(run "$p" "$WORK/startup.json" | grep -c '^$')" +# SD17: the 4d reminder line prints before the digest, never inside it +h17="$WORK/h17"; mkdir -p "$h17/.claude/plugins/store" +: > "$h17/.claude/plugins/store/memory_skills-dir-a.json" +p=$(mkproj sd17); blk "$p" 1 open "Seventeen" +out17=$(cd "$p" && HOME="$h17" bash "$SS" <"$WORK/startup.json" 2>/dev/null) +check SD17-line "$(printf '%s\n' "$out17" \ + | grep -c '^memory feedback: never run')" 1 +check SD17-before-digest "$(printf '%s\n' "$out17" \ + | grep -n -e '^memory feedback' -e '^memory digest' | cut -d: -f2 \ + | tr '\n' ' ')" "memory feedback memory digest " + # SD15: no hook run of this suite called the claude CLI (BLK-043) check SD15-no-claude-calls "$(claude_stub_calls)" 0