diff --git a/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md b/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md index b198546..6ee9a45 100644 --- a/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md +++ b/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md @@ -12,6 +12,7 @@ Phase 5 of the context mod queue (BDR-125): per-project and per-conversation pro - Floor-guard `[gated 2026-11-02]` (user): the four shellcheck suppressions are authorized with their reasons: `lib/profile.sh:2` SC2016 (file-wide; the jq programs quote `$var` on purpose), `lib/cc.sh` SC2016,SC1003 (the inner `bash -c` expands `$HOME` itself; `'^\'` is dtach's detach key), `lib/pack-census.sh:2` SC2088 (`~/.claude/skills` is a grep pattern, not a path), `lib/tests/cc.test.sh` SC1091 (sources a fixture); the plan file's code samples mirror them. The five deleted suites `lib/tests/{profile-default,profile-set-managed,profile-census,gstack-removed,toggle-external-repo-resolution}.test.sh` tested the retired symlink mechanism; their live checks moved to `lib/tests/profile.test.sh` (set/current/unset semantics, default profile) and `lib/tests/pack-census.test.sh` (fragment invariants, retired gstack names, old-layout citers). - STEP 6 code review `[gated 2026-11-02]` (user): `backend.json` and `web-full.json` are dropped (they were byte-identical to `dev.json` and `full.json`, so `current` named the wrong profile and the advisor looped); nine profiles remain (full, max, minimal, dev, design, web, seo, qa, audit), the advisor maps backend → dev and web-full → full, and the census forbids two fragments with equal `enabledPlugins` + deny set. `higgsfield-websites` stays in pack-higgsfield (OFF by default, ON in `max` only; amends BDR-109, recorded in the phase 5 BDR). `lib/cc.sh` keeps `set -a; . ~/.claude/.env` as `dtach_claude` did (accepted risk, recorded in the BDR). Also ruled by the controller: the project root for the local file follows Claude Code's rule (git common dir root when inside a repo, else the dir; shared `.claude/settings.json` read from the session dir); the profile-name match considers only the connector names a fragment manages; profile and session names are allowlisted `^[a-z0-9][a-z0-9-]*$`. - Floor-guard 2 `[gated 2026-11-02]` (user): the two `# shellcheck disable=SC2086` at lib/tests/cc.test.sh:62 and lib/tests/profile.test.sh:147 are authorized (test loops that word-split an argument string on purpose). Wording fix of the STEP 6 ruling: outside a git repo the root is the nearest ancestor holding `.claude/`, `CLAUDE.md` or `.git` below `$HOME` (the walk the suite tests), not the bare dir. Criterion 3's deny set reads minimal, dev, seo, qa, audit (backend dropped). +- Scope note `[gated 2026-11-02]` (user ask in this run): commit 08ae797 adds one TODO item to `.claude/tasks/TODO.md` (model-router: ask before routing to Fable, queued after the phase 5 merge). `.claude/tasks/` is a durable registry, outside the implementation scope; it is authorized and not part of the phase 5 diff under review. - Design-derived criteria are appended at STEP 3 `[gated]`. ## ACCEPTANCE CRITERIA