From e99cc2d7efbf3e7b5b06c0d05691bbb1631b8aba Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 2 Nov 2026 10:18:18 +0100 Subject: [PATCH] chore(contract): phase 5 floor-guard authorizations [gated] (4 shellcheck directives, 5 retired suites) --- .claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md b/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md index 63df674..5a21886 100644 --- a/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md +++ b/.claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md @@ -9,6 +9,7 @@ Phase 5 of the context mod queue (BDR-125): per-project and per-conversation pro - Spikes 1b/1c/2b 2026-11-01 (headless): a pack manifest `defaultEnabled:false` is OFF with nothing written (local or `--settings` true turns it on); the typed short slash `/` on a pack skill expands like `/:`; in a `--settings` conversation `/reload-plugins` re-reads neither the flag file nor a local true over a flag false, so a pack OFF by flag only comes back through a relaunch. - Brainstorm answers 2026-11-01 (user): no profile = `full` (packs ON, connectors present, as today); gstack split in three packs (dev / browser / design); both higgsfield connectors denied by `deniedMcpServers` in every profile except design, web, web-full, full, max; launcher `cc [profile]` as a function in `lib/cc.sh` sourced from `~/.bashrc` (user step), exporting `CLAUDE_PROFILE`, `CLAUDE_PROFILE_SETTINGS`, `TMPDIR` and running `claude --settings`; approach A = tracked packs `skills/pack-/` (relative symlinks into `skills-external/`, five real dirs moved), profiles as literal settings fragments `lib/profiles/.json`; `profile.sh current --plain` is the single truth for gates, hooks and statusline (supersedes BDR-024); a backend/dev profile still gets the design proposal mid-skill (`set web` / `enable design` + `/reload-plugins`, or relaunch when the source is the flag); listing budget measured last. Spec: `docs/superpowers/specs/2026-11-01-phase5-profiles-packs-design.md` (sections 1-9 approved in chat). - Pass B 2026-11-01 `[gated]` (plan `docs/superpowers/plans/2026-11-01-phase5-profiles-packs.md`, user answers): `lib/tests/higgsfield.test.sh` is kept, trimmed to the skills-external sync and CLI probes (spec said delete); the "no citer left" census covers hooks lib agents skills rules templates mods, root `*.sh`, CLAUDE.global.md, README, USAGE, ARCHITECTURE, Makefile, plugins.lock.json, .gitignore and excludes `lib/tests/fixtures/`, `docs/`, `.claude/`, CHANGELOG, MIGRATION; gstack `./setup` is skipped with a warn ("run make link first") when `skills/gstack` is not the helper tree, never run-then-clean. Defaults accepted by silence: `profile.sh -C `; `--plain` keys `flag=`, `model-source=`, `mcp-off=`, `connector:*=denied`, `plugin:=`; new files `lib/pack-census.sh`, `lib/gstack-removed.list`, suites profile/cc/pack-census/statusline; impeccable = pack symlink to `skills-external/impeccable` moved there by the installer (not tracked, no `git mv`); `~/.bashrc` user step removes `dtach_claude` + `alias cc` and sources `lib/cc.sh`; `deniedMcpServers` union documented (`cc x web` over a `dev` project keeps the connectors denied). +- Floor-guard `[gated 2026-11-02]` (user): the four shellcheck suppressions are authorized with their reasons: `lib/profile.sh:2` SC2016 (file-wide; the jq programs quote `$var` on purpose), `lib/cc.sh` SC2016,SC1003 (the inner `bash -c` expands `$HOME` itself; `'^\'` is dtach's detach key), `lib/pack-census.sh:2` SC2088 (`~/.claude/skills` is a grep pattern, not a path), `lib/tests/cc.test.sh` SC1091 (sources a fixture); the plan file's code samples mirror them. The five deleted suites `lib/tests/{profile-default,profile-set-managed,profile-census,gstack-removed,toggle-external-repo-resolution}.test.sh` tested the retired symlink mechanism; their live checks moved to `lib/tests/profile.test.sh` (set/current/unset semantics, default profile) and `lib/tests/pack-census.test.sh` (fragment invariants, retired gstack names, old-layout citers). - Design-derived criteria are appended at STEP 3 `[gated]`. ## ACCEPTANCE CRITERIA