chore(audits): log guard fail-closed and hard_deny clause residuals
This commit is contained in:
1 parent
162d4c1263
commit
e22893daa4
1 file changed
+4
@@ -97,6 +97,10 @@
|
|||||||
- lib/memory.sh `_mem_removed_lines` refuses a `memory.sh upgrade` commit of a v1 file where a dialect heading (`### BLK-n`) sits below the first `## ` entry: its rewrite to `## ` counts as a removed line inside an entry, so mixed-dialect v1 registries cannot be upgraded through memory-commit. Same for /prune-memory's `heading level` fix on a v2 file. Severity: low. Discovered while: /feat staged-next-id executor (T8m fixture). Not fixed.
|
- lib/memory.sh `_mem_removed_lines` refuses a `memory.sh upgrade` commit of a v1 file where a dialect heading (`### BLK-n`) sits below the first `## ` entry: its rewrite to `## ` counts as a removed line inside an entry, so mixed-dialect v1 registries cannot be upgraded through memory-commit. Same for /prune-memory's `heading level` fix on a v2 file. Severity: low. Discovered while: /feat staged-next-id executor (T8m fixture). Not fixed.
|
||||||
- lib/memory.sh `_mem_check_next_ids` assumes line order is chronological: a hand-inserted ID line above a new entry, or an ID line removed above the first entry, can refuse an entry `add` wrote correctly (named in the `_mem_next_id` comment). IDs at or above 2^53 lose precision in awk (same limit as `_mem_next_id`). Severity: low. Discovered while: /feat staged-next-id plan challenge. Not fixed.
|
- lib/memory.sh `_mem_check_next_ids` assumes line order is chronological: a hand-inserted ID line above a new entry, or an ID line removed above the first entry, can refuse an entry `add` wrote correctly (named in the `_mem_next_id` comment). IDs at or above 2^53 lose precision in awk (same limit as `_mem_next_id`). Severity: low. Discovered while: /feat staged-next-id plan challenge. Not fixed.
|
||||||
|
|
||||||
|
<!-- /feat guard-fail-closed 2026-11-16 (859e504) and /hotfix hard-deny-mod-off (8c21c4b): residuals, not BDR-125 -->
|
||||||
|
- settings.json `autoMode.hard_deny[6]` mod off-switch clause is a closed list: it does not name removing the `skills/<name>` symlink, a same-name dev copy shadowing a mod (`--plugin-dir`, `~/.claude/dev-mods/<session>/`), the memory mod's partial `"recall": false`, or `/route off` typed inside a skill run (the "Passing a gate" entry only bars `/route` outside a run). Its closing "The user maintains these files by hand" may now read as covering every edit to `~/.claude/<mod>.json`, including ordinary routing overrides (classifier over-refusal, unmeasured). `profile.sh disable` reaches only `model-router@skills-dir` (memory is not a managed id). Severity: low. Discovered while: /hotfix hard-deny-mod-off security gate and doc audit. Not fixed.
|
||||||
|
- mods/model-router/hooks/register.ts write guard: if the config load keeps throwing, no hook latches in-session (Skill and skill.prompt await ensureConfig first), so main-loop code writes stay held until a sub-agent writes; no throw source known today. The `next.called` replay branch is pinned only indirectly (the kit hides the downstream error). Severity: low. Discovered while: /feat guard-fail-closed plan challenge and security gate. Not fixed.
|
||||||
|
|
||||||
<!-- /hotfix doctor-skilloverrides-residue 2026-11-14: non-blocking gate finding, not BDR-125 -->
|
<!-- /hotfix doctor-skilloverrides-residue 2026-11-14: non-blocking gate finding, not BDR-125 -->
|
||||||
- doctor.sh `warn`/`pass`/`fail` print through `echo -e`: jq's `\uXXXX` escapes in the residue diff (:153) come back as raw control bytes (ESC sequences) on the terminal. Source = the user's own tracked settings.json (no trust boundary). Fix direction: `printf '%s\n'` in the shared helpers. Severity: low. Discovered while: /hotfix doctor-skilloverrides-residue security gate. Not fixed.
|
- doctor.sh `warn`/`pass`/`fail` print through `echo -e`: jq's `\uXXXX` escapes in the residue diff (:153) come back as raw control bytes (ESC sequences) on the terminal. Source = the user's own tracked settings.json (no trust boundary). Fix direction: `printf '%s\n'` in the shared helpers. Severity: low. Discovered while: /hotfix doctor-skilloverrides-residue security gate. Not fixed.
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user