chore: drop dead detect-plugins sources, refresh comments left by BDR-125 phases

This commit is contained in:
bchanot committed 2026-11-09 18:02:30 +01:00
1 parent 0912918125
commit d3943cbce6
8 files changed
+28 -23

No files matched your search

+6 -4
View File
@@ -509,7 +509,8 @@ CLAUDE_MD_CHARS=$(wc -c < "$REPO/CLAUDE.global.md" 2>/dev/null || echo 0)
CLAUDE_MD_TOKENS=$((CLAUDE_MD_CHARS / 4)) CLAUDE_MD_TOKENS=$((CLAUDE_MD_CHARS / 4))
# Skill descriptions across the whole live catalog — every SKILL.md # Skill descriptions across the whole live catalog — every SKILL.md
# reachable through ~/.claude/skills/*/SKILL.md, symlinks included # reachable through ~/.claude/skills/*/SKILL.md and
# ~/.claude/skills/pack-*/skills/*/SKILL.md, symlinks included
# (lib/doctor-skills.sh; catches a `|`/`>` block-scalar description that # (lib/doctor-skills.sh; catches a `|`/`>` block-scalar description that
# the old `grep '^description:' | head -1` counted as 0 chars, and a # the old `grep '^description:' | head -1` counted as 0 chars, and a
# symlinked skill dir that the old `find -maxdepth 2` without `-L` missed). # symlinked skill dir that the old `find -maxdepth 2` without `-L` missed).
@@ -605,9 +606,10 @@ else
fi fi
# Check expected skills are present. Repo-owned skills only: gstack skills # Check expected skills are present. Repo-owned skills only: gstack skills
# (health, status, …) are OFF by default and toggled per profile — requiring # ship in three packs (pack-gstack-dev/-browser/-design; on by manifest
# them here false-warns on a default install, and "run link.sh" cannot # default = full, off per project or conversation by a profile) and live
# restore them (they are profile-managed, not link.sh-managed). # under skills/pack-gstack-*/skills/<n>, while the check below reads
# $HOME/.claude/skills/<n>/SKILL.md, so they are excluded here.
EXPECTED_SKILLS=( EXPECTED_SKILLS=(
"analyze" "doc" "init-project" "onboard" "plugin-check" "analyze" "doc" "init-project" "onboard" "plugin-check"
"refactor" "ship-feature" "status" "refactor" "ship-feature" "status"
+13 -10
View File
@@ -25,22 +25,25 @@ else
warn "Cannot write log to $REPO — continuing without log file" warn "Cannot write log to $REPO — continuing without log file"
fi fi
# Load shared detection library # Load shared libraries
# shellcheck source=lib/detect-plugins.sh disable=SC1091
source "$REPO/lib/detect-plugins.sh"
# shellcheck source=lib/gstack-playwright.sh disable=SC1091 # shellcheck source=lib/gstack-playwright.sh disable=SC1091
source "$REPO/lib/gstack-playwright.sh" source "$REPO/lib/gstack-playwright.sh"
# shellcheck source=lib/gstack-links.sh disable=SC1091 # shellcheck source=lib/gstack-links.sh disable=SC1091
source "$REPO/lib/gstack-links.sh" source "$REPO/lib/gstack-links.sh"
# ── Guard hand-curated config against installer drift ──────── # ── Guard hand-curated config against installer drift ────────
# graphify's installer (Step 7) rewrites CLAUDE.md + .claude/settings.json # graphify's installer (Step 7) runs `graphify install` (appends a
# (clobbers the curated graphify section + injects aggressive MANDATORY # `# graphify` block to ~/.claude/CLAUDE.md = CLAUDE.global.md, which holds
# hooks), and `claude plugin install` (Step 5) flips enable-states in # the curated `## graphify` section: it matches the heading and appends,
# settings.json. These 4 files are maintained by hand + commit, never by # it does not clobber) and `graphify claude install` (writes CLAUDE.md and
# the installer. Snapshot them now and restore on exit so a run leaves them # .claude/settings.json in the caller's cwd, injecting aggressive MANDATORY
# exactly as it found them. Pre-existing local edits are preserved; only the # hooks). The EXIT trap restores the 4 $REPO files in GUARDED_CONFIGS
# installer's drift is undone. NOTE: this makes these files install-immutable # (fully effective when run from $REPO, e.g. `make plugin`). `claude plugin
# install` (Step 5) flips enable-states in settings.json. These 4 files are
# maintained by hand + commit, never by the installer. Snapshot them now and
# restore on exit so a run leaves them exactly as it found them. Pre-existing
# local edits are preserved; only the installer's drift is undone. NOTE: this
# makes these files install-immutable
# — anything the installer should add to them must be committed by hand. # — anything the installer should add to them must be committed by hand.
# CLAUDE.md = project memory (graphify's rewrite target); CLAUDE.global.md # CLAUDE.md = project memory (graphify's rewrite target); CLAUDE.global.md
# = user-scope global memory (deployed as ~/.claude/CLAUDE.md). # = user-scope global memory (deployed as ~/.claude/CLAUDE.md).
+1 -1
View File
@@ -1,7 +1,7 @@
#!/usr/bin/env bash #!/usr/bin/env bash
# ============================================================ # ============================================================
# lib/detect-plugins.sh — Single source of truth for plugin detection # lib/detect-plugins.sh — Single source of truth for plugin detection
# Sourced by: session-start.sh, doctor.sh, install-plugins.sh, update-all.sh # Sourced by: session-start.sh, doctor.sh
# #
# Each function returns 0 (detected) or 1 (not detected). # Each function returns 0 (detected) or 1 (not detected).
# No output — callers handle messaging. # No output — callers handle messaging.
+2 -1
View File
@@ -3,7 +3,8 @@
# lib/doctor-skills.sh — doctor.sh's skill-catalog stats # lib/doctor-skills.sh — doctor.sh's skill-catalog stats
# #
# `skill_catalog_stats <skills_dir>` counts every skill reachable # `skill_catalog_stats <skills_dir>` counts every skill reachable
# through <skills_dir>/*/SKILL.md (symlinks included — Python's # through <skills_dir>/*/SKILL.md and <skills_dir>/pack-*/skills/*/SKILL.md
# (symlinks included — Python's
# glob.glob follows them, verified: a symlinked skill dir matches the # glob.glob follows them, verified: a symlinked skill dir matches the
# pattern the same as a real one) and sums their description length, # pattern the same as a real one) and sums their description length,
# reusing lib/skill-routing-census.py's extract_description() (handles # reusing lib/skill-routing-census.py's extract_description() (handles
+2 -1
View File
@@ -6,7 +6,8 @@
# assets (bin/, browse/dist/, design/dist/, lib/diagram-render/dist/, # assets (bin/, browse/dist/, design/dist/, lib/diagram-render/dist/,
# ETHOS.md, scripts/jargon-list.json, freeze/bin/, */sections/*.md, # ETHOS.md, scripts/jargon-list.json, freeze/bin/, */sections/*.md,
# review/checklist.md + specialists/, …) that per-skill SKILL.md # review/checklist.md + specialists/, …) that per-skill SKILL.md
# symlinks never expose (BDR-030 links gstack skills individually). # symlinks never expose (BDR-030 links gstack skills individually
# (superseded by BDR-134: packs)).
# `link_gstack_helpers()` walks the submodule ONCE and mirrors every one # `link_gstack_helpers()` walks the submodule ONCE and mirrors every one
# of those assets under <dst>, so make-pdf, diagram, the freeze hook, # of those assets under <dst>, so make-pdf, diagram, the freeze hook,
# cso/plan-*-review sections etc. actually resolve — before this, only # cso/plan-*-review sections etc. actually resolve — before this, only
+1 -1
View File
@@ -6,7 +6,7 @@
# single-occurrence + column-0 closing brace) so drift in install-plugins.sh # single-occurrence + column-0 closing brace) so drift in install-plugins.sh
# propagates into this test instead of testing a stale copy. GUARDED_CONFIGS, # propagates into this test instead of testing a stale copy. GUARDED_CONFIGS,
# CFG_SNAPSHOT, REPO and an info() stub are defined here — the array literal # CFG_SNAPSHOT, REPO and an info() stub are defined here — the array literal
# at install-plugins.sh:43-44 is outside the extracted range. # GUARDED_CONFIGS array in install-plugins.sh is outside the extracted range.
set -u set -u
INSTALL_SH="$(cd "$(dirname "$0")/../.." && pwd)/install-plugins.sh" INSTALL_SH="$(cd "$(dirname "$0")/../.." && pwd)/install-plugins.sh"
pass=0; fail=0 pass=0; fail=0
+2 -2
View File
@@ -54,8 +54,8 @@ for item in hooks githooks agents skills lib templates rules; do
CHANGED=$((CHANGED + 1)) CHANGED=$((CHANGED + 1))
done done
# GStack is exposed via per-skill symlinks under skills/ (browse, # GStack skills are tracked links under skills/pack-gstack-*/skills/<n>
# canary, autoplan, design-review, …) created by gstack's own `./setup`, # -> skills-external/gstack/<n> (packs, BDR-134),
# PLUS a shared helper tree at skills/gstack/ mirroring every asset the # PLUS a shared helper tree at skills/gstack/ mirroring every asset the
# skills hardcode (bin/, browse/dist/, ETHOS.md, …) that a per-skill # skills hardcode (bin/, browse/dist/, ETHOS.md, …) that a per-skill
# symlink never exposes — see lib/gstack-links.sh. The helper tree # symlink never exposes — see lib/gstack-links.sh. The helper tree
+1 -3
View File
@@ -14,9 +14,7 @@ info() { echo -e "${BLUE}→${NC} $1"; }
REPO="$(cd "$(dirname "$0")" && pwd)" REPO="$(cd "$(dirname "$0")" && pwd)"
VERSION=$(cat "$REPO/version.txt" 2>/dev/null || echo "unknown") VERSION=$(cat "$REPO/version.txt" 2>/dev/null || echo "unknown")
# Load shared detection library # Load shared libraries
# shellcheck source=lib/detect-plugins.sh disable=SC1091
source "$REPO/lib/detect-plugins.sh"
# shellcheck source=lib/gstack-playwright.sh disable=SC1091 # shellcheck source=lib/gstack-playwright.sh disable=SC1091
source "$REPO/lib/gstack-playwright.sh" source "$REPO/lib/gstack-playwright.sh"
# shellcheck source=lib/gstack-links.sh disable=SC1091 # shellcheck source=lib/gstack-links.sh disable=SC1091