diff --git a/doctor.sh b/doctor.sh index bd1c44b..12cc1da 100644 --- a/doctor.sh +++ b/doctor.sh @@ -26,6 +26,8 @@ source "$REPO/lib/gstack-playwright.sh" source "$REPO/lib/doctor-vendored.sh" # shellcheck source=lib/doctor-skills.sh disable=SC1091 source "$REPO/lib/doctor-skills.sh" +# shellcheck source=lib/doctor-automem.sh disable=SC1091 +source "$REPO/lib/doctor-automem.sh" # shellcheck source=lib/higgsfield-skills.sh disable=SC1091 source "$REPO/lib/higgsfield-skills.sh" @@ -37,8 +39,8 @@ echo "" # 1. Core symlinks # ──────────────────────────────────────────────────────────── echo "── Symlinks ──" -# Expected: CLAUDE.md, settings.json, agents, skills, templates, hooks/session-start.sh -_EXPECTED_LINKS=7 +# Expected: CLAUDE.md, settings.json, agents, skills, templates, lib, rules, hooks/session-start.sh +_EXPECTED_LINKS=8 _LINK_PASS=0 check_symlink() { @@ -87,6 +89,7 @@ check_symlink "agents" check_symlink "skills" check_symlink "templates" check_symlink "lib" +check_symlink "rules" check_symlink "hooks/session-start.sh" info "Symlinks: ${_LINK_PASS}/${_EXPECTED_LINKS} OK" unset _EXPECTED_LINKS _LINK_PASS @@ -472,6 +475,25 @@ fi unset _sp _sp_fs _sp_opts echo "" +# ──────────────────────────────────────────────────────────── +# 5d. Auto memory (BDR-125 phase 1): "autoMemoryEnabled": false, so a file +# left under ~/.claude/projects//memory/ is never loaded again. +# ──────────────────────────────────────────────────────────── +echo "── Auto memory ──" +if jq -e '.autoMemoryEnabled == false' "$REPO/settings.json" >/dev/null 2>&1; then + pass "settings.json: autoMemoryEnabled false" +else + warn "settings.json: autoMemoryEnabled is not false — the auto-memory section loads every session (BDR-125 phase 1)" +fi +_am=$(automem_leftover_dirs "$HOME/.claude/projects") +if [ "$_am" -gt 0 ]; then + warn "auto memory: $_am project dir(s) still hold files under ~/.claude/projects/*/memory/ (never loaded) — migrate them to the project registries, then remove them by hand" +else + pass "auto memory: no leftover file under ~/.claude/projects/*/memory/" +fi +unset _am +echo "" + # ──────────────────────────────────────────────────────────── # 6. Token budget estimate # ──────────────────────────────────────────────────────────── diff --git a/lib/doctor-automem.sh b/lib/doctor-automem.sh new file mode 100755 index 0000000..b515c53 --- /dev/null +++ b/lib/doctor-automem.sh @@ -0,0 +1,25 @@ +#!/usr/bin/env bash +# ============================================================ +# lib/doctor-automem.sh — doctor.sh's auto-memory leftover check +# +# settings.json sets "autoMemoryEnabled": false (BDR-125 phase 1): Claude +# Code no longer reads ~/.claude/projects//memory/, so a file left +# there is knowledge nobody loads. `automem_leftover_dirs ` +# prints how many /memory dirs hold at least one file and ALWAYS +# exits 0 (doctor.sh runs under `set -euo pipefail`; an absent dir is 0). +# +# No `set -euo pipefail` here: a sourced lib must not change the caller's +# shell options. +# ============================================================ + +# automem_leftover_dirs — see file header. +automem_leftover_dirs() { + local d n=0 + for d in "$1"/*/memory; do + [ -d "$d" ] || continue + if [ -n "$(find "$d" -type f -print -quit 2>/dev/null)" ]; then + n=$((n + 1)) + fi + done + echo "$n" +} diff --git a/lib/tests/doctor-automem.test.sh b/lib/tests/doctor-automem.test.sh new file mode 100755 index 0000000..73f8281 --- /dev/null +++ b/lib/tests/doctor-automem.test.sh @@ -0,0 +1,30 @@ +#!/usr/bin/env bash +# lib/tests/doctor-automem.test.sh — lib/doctor-automem.sh's +# automem_leftover_dirs(): absent dir, empty memory dirs, a file, a nested +# file, an empty subdir only, rc 0 under errexit (doctor.sh runs under +# `set -euo pipefail`) — BDR-125 phase 1. +set -u +ROOT="$(cd "$(dirname "$0")/../.." && pwd)" +LIB="$ROOT/lib/doctor-automem.sh" +# shellcheck source=../doctor-automem.sh disable=SC1091 +source "$LIB" +pass=0; fail=0 +check() { if [ "$2" = "$3" ]; then pass=$((pass+1)); else fail=$((fail+1)); + printf 'FAIL %s: got[%s] want[%s]\n' "$1" "$2" "$3"; fi; } +W="$(mktemp -d)"; trap 'rm -rf "$W"' EXIT + +check T1-absent-dir "$(automem_leftover_dirs "$W/nope")" 0 +mkdir -p "$W/p/-home-a/memory" "$W/p/-home-b/memory" +check T2-empty-dirs "$(automem_leftover_dirs "$W/p")" 0 +echo x > "$W/p/-home-a/memory/MEMORY.md" +check T3-one-file "$(automem_leftover_dirs "$W/p")" 1 +mkdir -p "$W/p/-home-b/memory/sub"; echo y > "$W/p/-home-b/memory/sub/note.md" +check T4-nested-file-counts "$(automem_leftover_dirs "$W/p")" 2 +mkdir -p "$W/p/-home-c/memory/empty-sub" +check T5-empty-subdir-silent "$(automem_leftover_dirs "$W/p")" 2 +check T6-rc0-under-errexit "$(bash -c 'set -euo pipefail; source "$1"; automem_leftover_dirs "$2" >/dev/null; echo "rc$?"' _ "$LIB" "$W/nope")" rc0 +# doctor.sh calls it on "$HOME/.claude/projects": the same call under a temp HOME +mkdir -p "$W/h/.claude/projects/-home-x/memory"; echo z > "$W/h/.claude/projects/-home-x/memory/a.md" +check T7-via-temp-home "$(HOME="$W/h" bash -c 'source "$1"; automem_leftover_dirs "$HOME/.claude/projects"' _ "$LIB")" 1 + +printf 'PASS=%s FAIL=%s\n' "$pass" "$fail"; [ "$fail" -eq 0 ] diff --git a/settings.json b/settings.json index d8e9806..2ef0acd 100644 --- a/settings.json +++ b/settings.json @@ -489,6 +489,7 @@ }, "feedbackDrafts": "off", "effortLevel": "high", + "autoMemoryEnabled": false, "remoteControlAtStartup": true, "inputNeededNotifEnabled": true, "skipAutoPermissionPrompt": true,